From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 29B3E45075 for ; Tue, 3 Jan 2023 14:02:36 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1CA0B68BDAC; Tue, 3 Jan 2023 16:02:33 +0200 (EET) Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AF5F268BBD5 for ; Tue, 3 Jan 2023 16:02:26 +0200 (EET) Received: by mail-pj1-f43.google.com with SMTP id n12so20075147pjp.1 for ; Tue, 03 Jan 2023 06:02:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spin-digital-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=wqAW2kTAeOKuKYm8AEIkQdiX/lPLdnzuADAiuWUXPv4=; b=FIkPkYOACKtQXhQAt+n0LeDeoWrDInPIi9tZbNeaMLJnNpon8rYyZeK1cBtU0AFTyV yGryDfVTPHt+0r3ry9lHOTKwHQC+MlzX5Ie88C7hvULDAVV8fXahbzE9CoCq03tDREcr LToktYhLRAXCoQUx3Yo9U83JZvFRIzTzaNsYFsUbxoy7fCNcau5RZDAh6w6P903vOIMa V/Sgndwbd+5vD2NOX2h1c64vH8uqgCGVD1WHJ2MdC118nC2z/XFV556kELzydkyPgV2O zrYvhGTx5Hq8h3z4kF56q6Uju0nNpTkdpk655JXNKV4Uf5TBnpdnVDZI/nPzLLyu5Sa/ mHdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wqAW2kTAeOKuKYm8AEIkQdiX/lPLdnzuADAiuWUXPv4=; b=sfkahgSQET7bHv46Elpj+k6GtdmOkY/fZunqUGYbWW+vUCqNmcFi95sGldB2gxFFL5 mEebgsGt+ZrcD9I8AYs+ak6aK7kNsXgPpA81tF+ABhxiBefN/kpeX1wbUpdHPCMskSbh hQ1fFEYPoznmQ2JTB/NIQeG2dBHqTwxiZoj4oyO/3EMuZJ67qMMJAaQETXWpLVUiFID5 uA0vgZM0EfcBKOjp4+sVeDCzUr4MyTDUjE6PaqkDTSKyDRpKJ3nTFpS4vpLpxr7k2O9D GkBxLRBpTfeYQ5P3zOS/gveQT65886V+/s53AhsxNxqf19n40nmijD85zRkrCoQmJ8iL 7NJw== X-Gm-Message-State: AFqh2kq5D8d/26i4rDegl2DaG/2hknMtdUk+mpOW0PNpyv3Uqfu73cma 3stzre+qp7fBs8Fbkbomq5C30jCchikBfbBbogB1vtMTzVvBwg== X-Google-Smtp-Source: AMrXdXuEY1cVwGEGMFUsi0K5PJrdkFslqlesjVtWSmtZTjFsAkbjgBcodelzCqD7R9b3Msu4ms8KdksYNIbrierWBtw= X-Received: by 2002:a17:902:b207:b0:189:5ba2:4907 with SMTP id t7-20020a170902b20700b001895ba24907mr3185176plr.113.1672754544670; Tue, 03 Jan 2023 06:02:24 -0800 (PST) MIME-Version: 1.0 References: <20221019072508.23460-1-thomas.ff@spin-digital.com> In-Reply-To: From: Thomas Siedel Date: Tue, 3 Jan 2023 15:02:12 +0100 Message-ID: To: Nuo Mi X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH v1 00/11] Add support for H266/VVC X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 15 Dec 2022 at 10:11, Thomas Siedel wrote: > On Tue, 13 Dec 2022 at 07:19, Nuo Mi wrote: > >> Hi Thomas, >> Thank you for sending the patch set. >> It seems the patchset is based on >> https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=3487 >> Please do not change the author's name. >> >> thank you >> > > Some code regarding VVC parsing is based on another FFmpeg fork. This fork > had been based on your patch set, it seems. > On top of this, I did additional modifications to the parsing code and > added the other code regarding format support and the decoder and encoder > integration. > > It was not my intent to hide you as an author of the parsing code. > Your patch set has been in an unmerged state for over 1.5 years now > without new progress, so I assumed that these patches are kind of > discontinued. > Therefore I started submitting my own patchset to get VVC integrated into > FFmpeg. > I kept your original copyright notices in libavformat/vvcdec.c and > livavcodec/vvc_parser.c. > Apart from this, I am not sure how / where else this could be documented > and how other authors can be appropriately referenced. > > Could you explain in more detail what you mean by changing the author's > name? > Do you have any suggestions on what to do in this case or how to change it? > > I just submitted a new version of the patch set. Among other changes, I now put you as the author of the first three patches, as most of their content is based on your original patch set. I made some modifications to them, so I added myself as a co-author. For patches 4 and 5, I put you as the co-author because some of their content is based on your original patch set, but only to a smaller extent. All other patches are independent. I hope that this solution is OK for you. If not, please let me know. > > On Wed, Oct 19, 2022 at 3:26 PM wrote: >> >>> From: Thomas Siedel >>> >>> This patch set adds H266/VVC support. >>> This includes parsing, muxing, demuxing, decoding and encoding. >>> Decoding is done using the external library VVdeC >>> (https://github.com/fraunhoferhhi/vvdec.git) and can be enabled with >>> --enable-libvvdec. >>> Encoding is done using the external library VVenC >>> (https://github.com/fraunhoferhhi/vvenc.git) and can be enabled with >>> --enable-libvvenc. >>> >>> Thomas Siedel (11): >>> avcodec: add enum types for H266/VVC >>> avcodec: add cbs for H266/VVC >>> avcodec: enable cbs for H266/VVC >>> avcodec: add bitstream parser for H266/VVC >>> avcodec: add MP4 to annexb support for H266/VVC >>> avformat: add demuxer and probe support for H266/VVC >>> avformat: add muxer support for H266/VVC >>> avcodec: add external decoder libvvdec for H266/VVC >>> avcodec: add external encoder libvvenc for H266/VVC >>> avformat: add ts stream types for H266/VVC >>> avcodec: increase minor version for H266/VVC >>> >>> configure | 16 +- >>> libavcodec/Makefile | 6 + >>> libavcodec/allcodecs.c | 2 + >>> libavcodec/bitstream_filters.c | 2 + >>> libavcodec/cbs.c | 6 + >>> libavcodec/cbs_h2645.c | 384 +++- >>> libavcodec/cbs_h266.h | 791 +++++++ >>> libavcodec/cbs_h266_syntax_template.c | 3010 +++++++++++++++++++++++++ >>> libavcodec/cbs_internal.h | 3 +- >>> libavcodec/cbs_sei.c | 29 + >>> libavcodec/h2645_parse.c | 71 +- >>> libavcodec/h266_metadata_bsf.c | 145 ++ >>> libavcodec/libvvdec.c | 511 +++++ >>> libavcodec/libvvenc.c | 432 ++++ >>> libavcodec/parsers.c | 1 + >>> libavcodec/version.h | 2 +- >>> libavcodec/vvc.h | 142 ++ >>> libavcodec/vvc_mp4toannexb_bsf.c | 318 +++ >>> libavcodec/vvc_paramset.c | 972 ++++++++ >>> libavcodec/vvc_paramset.h | 429 ++++ >>> libavcodec/vvc_parse_extradata.c | 241 ++ >>> libavcodec/vvc_parse_extradata.h | 36 + >>> libavcodec/vvc_parser.c | 588 +++++ >>> libavformat/Makefile | 8 +- >>> libavformat/allformats.c | 2 + >>> libavformat/demux.c | 7 +- >>> libavformat/isom.c | 1 + >>> libavformat/isom_tags.c | 3 + >>> libavformat/mov.c | 6 + >>> libavformat/movenc.c | 41 +- >>> libavformat/mpeg.c | 3 + >>> libavformat/mpeg.h | 1 + >>> libavformat/mpegts.c | 2 + >>> libavformat/mpegts.h | 1 + >>> libavformat/mpegtsenc.c | 65 + >>> libavformat/rawenc.c | 23 + >>> libavformat/vvc.c | 918 ++++++++ >>> libavformat/vvc.h | 99 + >>> libavformat/vvcdec.c | 61 + >>> 39 files changed, 9366 insertions(+), 12 deletions(-) >>> create mode 100644 libavcodec/cbs_h266.h >>> create mode 100644 libavcodec/cbs_h266_syntax_template.c >>> create mode 100644 libavcodec/h266_metadata_bsf.c >>> create mode 100644 libavcodec/libvvdec.c >>> create mode 100644 libavcodec/libvvenc.c >>> create mode 100644 libavcodec/vvc.h >>> create mode 100644 libavcodec/vvc_mp4toannexb_bsf.c >>> create mode 100644 libavcodec/vvc_paramset.c >>> create mode 100644 libavcodec/vvc_paramset.h >>> create mode 100644 libavcodec/vvc_parse_extradata.c >>> create mode 100644 libavcodec/vvc_parse_extradata.h >>> create mode 100644 libavcodec/vvc_parser.c >>> create mode 100644 libavformat/vvc.c >>> create mode 100644 libavformat/vvc.h >>> create mode 100644 libavformat/vvcdec.c >>> >>> -- >>> 2.25.1 >>> >>> _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".