From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A5E3544A06 for ; Thu, 29 Sep 2022 18:15:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D3DBB68BA85; Thu, 29 Sep 2022 21:15:20 +0300 (EEST) Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D92F068B9C2 for ; Thu, 29 Sep 2022 21:15:14 +0300 (EEST) Received: by mail-yb1-f172.google.com with SMTP id 65so2538066ybp.6 for ; Thu, 29 Sep 2022 11:15:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=roblox.com; s=google; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=pgOb9oOaA1Tp5krDYsAT0i9+zEqkHmc3Oh/F52Nw0Ss=; b=XhBXvxOlM5amq5nD+aOamwptHDbwvaHfViXn/yU8QiHMjZisl0wFPf9MvjQwO4QEz/ 0GhWYHDMZDr+BnEIdELf9zsAjDU88/xplZ9vK6TtK99+wJJ4+o8aAHuhtCNuGgxH/jDH CVZvEUdMULet63E8EAV4i3VJfLDrdyOFQjBMI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=pgOb9oOaA1Tp5krDYsAT0i9+zEqkHmc3Oh/F52Nw0Ss=; b=30Yj0dFQ7PaxnG8DdT4pAQEs0pkL5po3qkDZ4VRo+pOTrdDYQMIIELOvj5tIqNmKsK Ic5l7yoAUEyhzCRCSJRe98BHPXJ3WevC1lKEAOtDKRGBhFxtAmNlnDeJvg+JzHCLWqhB +X2eTnPTsBNFr5gh/dnNIVzYHWlQG1vY14N8RZJ20aPVPXhi3IekJvOHMxeixZWVmg2O IhOLQ3m5FsELH8TJ6lH0uWubQEopIjFGcCCSUgMIVjMOrh+7xVbVTfxtk1vDSqMZi16/ rV0HH6qbumExw0LgysKWYsfbwL57U7F9Si8XVSHw7lelchotsbp2ZVOjKwu6uA3zxIYs IWHw== X-Gm-Message-State: ACrzQf3YTKrK4xH5hnCzqzrINsoR4KWNsLijDHrqTtBvVmu3jz04XzzS myfCxIWVGQ/JfxdsplLiYPWODmYlsrQHDukQdhQaCL7NTzs= X-Google-Smtp-Source: AMsMyM5/4prjPrVIA2yO6AlkD/bQ0GLGfQ4rO4S9ip0VV6QOMqhW7uwl6qXjY6oIqx3ZsN3l8O6MENo0y+O/SZjEzSc= X-Received: by 2002:a25:7c41:0:b0:6b4:fa81:9803 with SMTP id x62-20020a257c41000000b006b4fa819803mr4693075ybc.592.1664475313128; Thu, 29 Sep 2022 11:15:13 -0700 (PDT) MIME-Version: 1.0 References: <20220919052239.2080-1-gsun@roblox.com> <166437412231.22057.248171982435729520@lain.khirnov.net> In-Reply-To: <166437412231.22057.248171982435729520@lain.khirnov.net> From: Guangyu Sun Date: Thu, 29 Sep 2022 11:15:02 -0700 Message-ID: To: FFmpeg development discussions and patches , Guangyu Sun Subject: Re: [FFmpeg-devel] [PATCH] lavf/async: Fix wrapped_url_read return value X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, Sep 28, 2022 at 7:08 AM Anton Khirnov wrote: > > Quoting Guangyu Sun (2022-09-19 07:22:39) > > This fixes a regression from commit 36117968ad. > > > > wrapped_url_read() used to be able to return positive number from > > ffurl_read(). It relies on the result to check if EOF is reached in > > async_buffer_task(). > > > > Test case: > > ffmpeg -f lavfi -i testsrc -t 1 test.mp4 > > ffmpeg -i async:test.mp4 > > > > Signed-off-by: Guangyu Sun > > --- > > libavformat/async.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavformat/async.c b/libavformat/async.c > > index 547417aa1e..a929f4d16e 100644 > > --- a/libavformat/async.c > > +++ b/libavformat/async.c > > @@ -139,7 +139,7 @@ static int wrapped_url_read(void *src, void *dst, size_t *size) > > *size = ret > 0 ? ret : 0; > > c->inner_io_error = ret < 0 ? ret : 0; > > > > - return c->inner_io_error; > > + return ret; > > This is wrong, FIFO callbacks must return 0 on success. This should be > handled in ring_write() instead. Thanks. I just submitted a new version. Guangyu > > -- > Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".