From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 78C2543BB8 for ; Wed, 20 Jul 2022 16:24:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5EFAF68B680; Wed, 20 Jul 2022 19:23:59 +0300 (EEST) Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BCE3F68B4C6 for ; Wed, 20 Jul 2022 19:23:53 +0300 (EEST) Received: by mail-qk1-f175.google.com with SMTP id f14so14070094qkm.0 for ; Wed, 20 Jul 2022 09:23:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DNNol6JY1Q9z797enkBGrRNLKkZNzQ23h6aRGgWGfG0=; b=C+eUDCn/hg+NwnelqcYzOweTKTeF3L3kMBigilOHJedpx89XSG1v7s2fD/HzjtdJhV 4K5ZkXKpu9A9im4L6j3prr2tX+hB3aPFO4fJ8vU8K9TL8WU6xRuGNr9RShNc+mB4LrYJ exK+28u9GMegmU+hLGkPjpCDCJLM7TLtXfcdaNtwKnZ33wEaS9EQVC77gg8rgnHBlyLe 5L6KtgudbB35V3SwduDyYRoHKAM3HAbG07dNHcAjK78F8/3zgg6QfT/ytF7vkDJYJ4Oy AP1sKmIkmo7wDoM5lWGLXNoAPrBUqAzY6NKZT9PCrHp1aJsllWGTnYdFzEWt/It88jYg q26Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DNNol6JY1Q9z797enkBGrRNLKkZNzQ23h6aRGgWGfG0=; b=NQYCDMXlpw6MT30Uyj4o1HWy6nyIlOSBigsuWSgUO0mJC+P2uSqaoQvPL3T3z+HiXo 3P4hD1D+WILjPPE1JnouzJl+/m9uG0v+yrIS/WML5B6Izg9LEyL3BarwRCM3MY2/aYPQ 441B7FQVBGc+KGe3LzdpXDyIlnVbjKDT0bp3TsW7kcobZeDTDsX2A/qGDL4PsM/H/lah M3Jw+OHJbdEG28IczMNvFWUIp3s/opn8DzL+Jat4gryjQorbOFydLGq7mEJUB0/n8KHs K76HV9KihimhVl7DY0SAKFSDOQUI6Rq+TMU9rE4Uy6rN6imNt4gH1CI547GEyl0JHjqE /R+Q== X-Gm-Message-State: AJIora9yD2oGOUNA/xrB1vBY5tBzd3wsUKQWPlBzzrGLGJh2//baPC7b zQH498ZMali44z99vWvt4MYNs1ebfjExl53ztNKIBvB5hf8= X-Google-Smtp-Source: AGRyM1s1ti76u5qL20ijkc5JD1GEpwL7alo0o2nbyE2mQ5bK9UgwwtKNJbLZIeX3MrhI5cVOFpgS+qRWp7KyDteAgBc= X-Received: by 2002:a05:620a:424d:b0:6a7:9714:9443 with SMTP id w13-20020a05620a424d00b006a797149443mr24632392qko.544.1658334232060; Wed, 20 Jul 2022 09:23:52 -0700 (PDT) MIME-Version: 1.0 References: <20220720105646.716398-1-emil.l.velikov@gmail.com> <20220720105646.716398-2-emil.l.velikov@gmail.com> In-Reply-To: <20220720105646.716398-2-emil.l.velikov@gmail.com> From: Emil Velikov Date: Wed, 20 Jul 2022 17:23:40 +0100 Message-ID: To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH v2 1/3] hwcontext_vaapi: do not link against libva-x11.so X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Mark Thompson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 20 Jul 2022 at 11:56, Emil Velikov wrote: > > From: Emil Velikov > > There is an internal ABI between libva.so the libva-XXX.so libraries. > > With a recent change, the internal va_fool API was removed breaking the > ABI. So if libva.so and libva-x11.so are from different version, the > whole stack will crash. > > Instead we can dlopen() the libva-x11 library and gracefully error out. > > Signed-off-by: Emil Velikov > --- > v2: add libdl dependency > --- > configure | 3 ++- > libavutil/hwcontext_vaapi.c | 34 +++++++++++++++++++++++++++++++++- > 2 files changed, 35 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index 18d9b61a99..605afd58a7 100755 > --- a/configure > +++ b/configure > @@ -3816,7 +3816,8 @@ swscale_suggest="libm stdatomic" > > avcodec_extralibs="pthreads_extralibs iconv_extralibs dxva2_extralibs" > avfilter_extralibs="pthreads_extralibs" > -avutil_extralibs="d3d11va_extralibs nanosleep_extralibs pthreads_extralibs vaapi_drm_extralibs vaapi_x11_extralibs vdpau_x11_extralibs" > +avutil_deps="libdl" Hmm, using _deps seems to be causing issues - "libdl at $avdevice_deps is not at $LIBRARY_LIST". In particular, due to the direct dependency between avutil and avdevice, libdl gets propagated into avdevice_deps and libdl where not part of $LIBRARY_LIST. On the other hand, if we use avutil_deps_any libdl does not end up in avdevice_deps (is this intentional), yet it looks incorrect. We're providing a single entry in an "any" list, where we do need the functionality. Be that explicitly from libdl.so or implicitly from the C runtime. Looking at all the other deps - perhaps deps_select is the best option to use here? Aside: Kicking off `make` after configure is changed does not trigger [config.mak] regeneration. Is that intentional? All the other projects that I've used do so. Thanks in advance, Emil _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".