From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B303A43C90 for ; Fri, 29 Jul 2022 15:35:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2A6AF68B9E0; Fri, 29 Jul 2022 18:35:30 +0300 (EEST) Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3BFF168B87F for ; Fri, 29 Jul 2022 18:35:23 +0300 (EEST) Received: by mail-qt1-f180.google.com with SMTP id y9so3545845qtv.5 for ; Fri, 29 Jul 2022 08:35:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=6pFi9FX6nlvPAqc2VA+ohE5Ak4kYY41HdVzOAV7SHkw=; b=DH4Z/d4ZYX8n/GODbXWkc4yprgECV4wu1zg+/bhpQ1GWeGtxW6lfa7Rfj8e6nR23+v V1Mp3Rr9de/vgCEQIwLBdXGU1nYwzQBKQetDMZzNtNmfs5IYfUnac4D/drRwlVHIFco2 HKQtFVSVlyFvWd9gz/ykHkMDkwBJJ2DQu3SaKqQSkPDAkh4ECtbTn23cnCIAt2xRJDtk xATBDEGg/yalGqnFfqcpqUyCXuWLcM4MS+Xa8EHYJAGfkHJBA24kqkczQdTG8iSl12qt f0LNzymdEII+K0mHVbZkWO/3mqDWAAOtFnoVc5x3pw9UILoMKhMAdCJ3CXYU0eRgGsuo /oaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=6pFi9FX6nlvPAqc2VA+ohE5Ak4kYY41HdVzOAV7SHkw=; b=YMZWyYiUD3cUpcnxXM9BIUqR7O59jw36CG7UK08HcDMPz7SzC0EuljiLAJNcEwCkPO JIjontJAdT8qLoW0vq57eCcAFF1HonOsyxvq/fjqGpy3ZcW6AtWiM2SY8rmQ8lO9J2NP 2/w+Dusy42aAd5B8PjVogz3zckPQQ687VMFRmxgCKhIJwSglYw8vtRmYqd2ehCpNyuqJ HNuzV6YD82+WNhkkRDg3knNi/SOV4fUmZW4ZcFp0WJgZLC5c585di1tyNhVfRuST0uUB 2yRZGolrVV4HouKZpCZK7HoUMufbWXn0hgzEhM+Rzac/SmLXA7LfXLS+7RpnfnYBnQbv Z/9A== X-Gm-Message-State: AJIora9YcLKZxa8TZKFfFjvo6JLp8uFaovEUwf/Bhw/LgMxzIViIdAVm O/HtCCVXQf7BZ+jXCplEfcljOhJ3+sbv4DNakZ5szfmmRcNuzw== X-Google-Smtp-Source: AGRyM1ssq0EBj02KOvjrZEricGUXeR0cUyPGjCHAG9tv4Eom+XKxGWzEvRYF7HQGd8ovgtiMeuuKbyft/bSk1KFaao0= X-Received: by 2002:ac8:5a88:0:b0:320:7963:f6fb with SMTP id c8-20020ac85a88000000b003207963f6fbmr3925159qtc.393.1659108921488; Fri, 29 Jul 2022 08:35:21 -0700 (PDT) MIME-Version: 1.0 References: <20220720105646.716398-1-emil.l.velikov@gmail.com> <20220720105646.716398-4-emil.l.velikov@gmail.com> <165901706487.10012.10422218517545401892@lain.khirnov.net> In-Reply-To: <165901706487.10012.10422218517545401892@lain.khirnov.net> From: Emil Velikov Date: Fri, 29 Jul 2022 16:35:10 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v2 3/3] hwcontext_vaapi: #if guard VAAPI_DRM specifics X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 28 Jul 2022 at 15:04, Anton Khirnov wrote: > > Quoting Emil Velikov (2022-07-22 15:27:26) > > > > Assuming I'm reading the code correctly, currently when both are > > undefined vaapi_device_create() will be basically a dummy, doing some > > basic malloc + opts parsing and erroring out. > > > > So as-is functions like av_hwdevice_ctx_alloc() will return success, > > although as av_hwdevice_ctx_create() is called later on it will always > > fail. > > My aim was to effectively omit the HWContextType vaapi instance in the > > final libavutil, since it cannot work. Perhaps there's a better way to > > achieve that? > > You seem to have missed that av_hwdevice_ctx_create() is entirely > optional. The users _can_ call it to avoid some boilerplate, but they > can just as well use av_hwdevice_ctx_alloc()+av_hwdevice_ctx_init(), > while opening the device themselves using whatever other means. > Indeed, I have. Thanks for the clarification. -Emil _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".