[FFmpeg-devel] Re: [GSoC 2026] Qualification Task – SubViewer Decoder Patch

[Nariman Sayed via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>]

Hi,

Thank you for the detailed feedback and for pointing me to the API
documentation.

You are right — the decode() API already assumes a valid AVCodecContext,
and I agree that adding a null check here is unnecessary and inconsistent
with other subtitle decoders. The patch was mainly an exploratory
contribution to familiarize myself with FFmpeg’s subtitle decoding path and
review process.

I appreciate the note about indentation as well. I will drop this patch and
focus on more relevant contributions, particularly around EIA-608 Closed
Captions, and will follow the transition to Forgejo for future work.

Thanks again for the review.

Best regards,
Nariman

‫في الاثنين، 26 يناير 2026 في 8:40 م تمت كتابة ما يلي بواسطة ‪Yalda via
ffmpeg-devel‬‏ <‪ffmpeg-devel@ffmpeg.org‬‏>:‬

> Hi Nariman,
>
> Thank you for your contribution. Please note that the contribution
> process is transitioning to Forgejo (https://code.ffmpeg.org) and
> would pivot any future patches there.
> With regards to this specific patch can you give some context as to
> why you think it is needed? Is there a known fault or trigger? Also
> return line needs indentation.
> I do not see other subtitle decoders doing this check, and am leaning
> toward trusting the API that decode() should not be called as such.
>
> See callee here in the doxygen (and if you follow into the function in
> decode.c you can see that avctx is already used)
>
> https://ffmpeg.org/doxygen/trunk/group__lavc__decoding.html#ga5c30b73f0ec105f93d4e86464f541f21
> _______________________________________________
> ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
> To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org
>
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org