Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "mypopy@gmail.com" <mypopy@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Jun Zhao <barryjzhao@tencent.com>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] doc/examples/muxing: Remove unnecessary ret
Date: Sat, 25 Feb 2023 23:28:39 +0800
Message-ID: <CACYjbn3kH+S+O_TTG=mXJ5YXiwFb9JEhZ3yr6P3ozi7+8z+itg@mail.gmail.com> (raw)
In-Reply-To: <20230225152509.3086288-1-mypopydev@gmail.com>

ignore the patch 1-2, send with the wrong branch

On Sat, Feb 25, 2023 at 11:25 PM Jun Zhao <mypopydev@gmail.com> wrote:
>
> From: Jun Zhao <barryjzhao@tencent.com>
>
> Remove unnecessary ret and make the code more compact
>
> Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> ---
>  doc/examples/muxing.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/doc/examples/muxing.c b/doc/examples/muxing.c
> index 3acb778322..cd997d5431 100644
> --- a/doc/examples/muxing.c
> +++ b/doc/examples/muxing.c
> @@ -219,8 +219,6 @@ static AVFrame *alloc_audio_frame(enum AVSampleFormat sample_fmt,
>                                    int sample_rate, int nb_samples)
>  {
>      AVFrame *frame = av_frame_alloc();
> -    int ret;
> -
>      if (!frame) {
>          fprintf(stderr, "Error allocating an audio frame\n");
>          exit(1);
> @@ -232,8 +230,7 @@ static AVFrame *alloc_audio_frame(enum AVSampleFormat sample_fmt,
>      frame->nb_samples = nb_samples;
>
>      if (nb_samples) {
> -        ret = av_frame_get_buffer(frame, 0);
> -        if (ret < 0) {
> +        if (av_frame_get_buffer(frame, 0) < 0) {
>              fprintf(stderr, "Error allocating an audio buffer\n");
>              exit(1);
>          }
> --
> 2.25.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".



-- 
=======================================
Jun zhao/赵军
+++++++++++++++++++++++++++++++++++++++
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2023-02-25 15:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-25 15:25 Jun Zhao
2023-02-25 15:25 ` [FFmpeg-devel] [PATCH 2/2] doc/protocols: update rtsp options Jun Zhao
2023-02-25 15:28 ` mypopy [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-10-22 10:49 [FFmpeg-devel] [PATCH 1/2] doc/examples/muxing: Remove unnecessary ret Jun Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACYjbn3kH+S+O_TTG=mXJ5YXiwFb9JEhZ3yr6P3ozi7+8z+itg@mail.gmail.com' \
    --to=mypopy@gmail.com \
    --cc=barryjzhao@tencent.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git