Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "mypopy@gmail.com" <mypopy@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 3/3] lavf/cavsvideodec: Add GuangDian profile support
Date: Sun, 8 May 2022 10:53:50 +0800
Message-ID: <CACYjbn2DWRsNXgMqpdtmiPKT_RUun2zpxscfMcn+MrEDwSJgiQ@mail.gmail.com> (raw)
In-Reply-To: <tencent_36A72638D5162A4D4BA03FCD884F96D51907@qq.com>

On Mon, May 2, 2022 at 1:15 PM "zhilizhao(赵志立)" <quinkblack@foxmail.com> wrote:
>
>
>
> > On May 2, 2022, at 11:36 AM, Jun Zhao <mypopydev@gmail.com> wrote:
> >
> > From: Jun Zhao <barryjzhao@tencent.com>
> >
> > Enable the Guangdian profile support
> >
> > Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> > ---
> > libavformat/cavsvideodec.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/libavformat/cavsvideodec.c b/libavformat/cavsvideodec.c
> > index 1fa3aa5e92..437ad544d3 100644
> > --- a/libavformat/cavsvideodec.c
> > +++ b/libavformat/cavsvideodec.c
> > @@ -29,6 +29,7 @@
> > #define CAVS_PIC_PB_START_CODE    0x000001b6
> > #define CAVS_VIDEO_EDIT_CODE      0x000001b7
> > #define CAVS_PROFILE_JIZHUN       0x20
> > +#define CAVS_PROFILE_GUANGDIAN    0x48
>
> Maybe add a comment here that ‘GUANGDIAN' is broadcasting profile.
>
Applied the patchset and add the comment, thx
> >
> > static int cavsvideo_probe(const AVProbeData *p)
> > {
> > @@ -50,7 +51,7 @@ static int cavsvideo_probe(const AVProbeData *p)
> >             if (code == CAVS_SEQ_START_CODE) {
> >                 seq++;
> >                 /* check for the only currently supported profile */
> > -                if (*ptr != CAVS_PROFILE_JIZHUN)
> > +                if (*ptr != CAVS_PROFILE_JIZHUN && *ptr != CAVS_PROFILE_GUANGDIAN)
> >                     return 0;
> >             } else if ((code == CAVS_PIC_I_START_CODE) ||
> >                        (code == CAVS_PIC_PB_START_CODE)) {
> > @@ -66,4 +67,4 @@ static int cavsvideo_probe(const AVProbeData *p)
> >     return 0;
> > }
> >
> > -FF_DEF_RAWVIDEO_DEMUXER(cavsvideo, "raw Chinese AVS (Audio Video Standard)", cavsvideo_probe, NULL, AV_CODEC_ID_CAVS)
> > +FF_DEF_RAWVIDEO_DEMUXER(cavsvideo, "raw Chinese AVS (Audio Video Standard)", cavsvideo_probe, "avs", AV_CODEC_ID_CAVS)
> > --
> > 2.25.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2022-05-08  2:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-02  3:36 [FFmpeg-devel] [PATCH 1/3] lavc/libuavs3d: fix incorrect comments Jun Zhao
2022-05-02  3:36 ` [FFmpeg-devel] [PATCH 2/3] lavc/cavsdec: Add profile check Jun Zhao
2022-05-02  3:36 ` [FFmpeg-devel] [PATCH 3/3] lavf/cavsvideodec: Add GuangDian profile support Jun Zhao
2022-05-02  5:15   ` "zhilizhao(赵志立)"
2022-05-08  2:53     ` mypopy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACYjbn2DWRsNXgMqpdtmiPKT_RUun2zpxscfMcn+MrEDwSJgiQ@mail.gmail.com \
    --to=mypopy@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git