Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "mypopy@gmail.com" <mypopy@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Jun Zhao <barryjzhao@tencent.com>, Jun Zhao <mypopydev@gmail.com>
Subject: Re: [FFmpeg-devel] [PATCH] lavc/libx264: replace ITU-T T35(A/53 CC) SEI type by enum value
Date: Sun, 27 Aug 2023 09:54:22 +0800
Message-ID: <CACYjbn1fgAcnSVo2=7b0r8wSG3Lgu92A19GXAM6Wq_ybTZ7rwQ@mail.gmail.com> (raw)
In-Reply-To: <CAK+ULv4d4d7CFuh49HkB7ztJ6Z7fkL_oidRcEm_XvPm3uP2uHg@mail.gmail.com>

On Sat, Aug 26, 2023 at 2:40 PM Kieran Kunhya <kierank@obe.tv> wrote:
>
> On Sat, 26 Aug 2023 at 07:32, Jun Zhao <mypopydev@gmail.com> wrote:
>
> > replace ITU-T T35(A/53 CC) SEI type by enum value
> >
> > Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
> > ---
> >  libavcodec/libx264.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c
> > index 1a7dc7bdd5..ce849d6c9a 100644
> > --- a/libavcodec/libx264.c
> > +++ b/libavcodec/libx264.c
> > @@ -563,7 +563,7 @@ FF_ENABLE_DEPRECATION_WARNINGS
> >
> >              sei->payloads[0].payload_size = sei_size;
> >              sei->payloads[0].payload      = sei_data;
> > -            sei->payloads[0].payload_type = 4;
> > +            sei->payloads[0].payload_type =
> > SEI_TYPE_USER_DATA_REGISTERED_ITU_T_T35;
> >              sei->num_payloads = 1;
> >          }
> >      }
> > --
> > 2.25.1
> >
>
> LGTM
thx,will apply
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2023-08-27  1:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-26  6:32 Jun Zhao
2023-08-26  6:40 ` Kieran Kunhya
2023-08-27  1:54   ` mypopy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACYjbn1fgAcnSVo2=7b0r8wSG3Lgu92A19GXAM6Wq_ybTZ7rwQ@mail.gmail.com' \
    --to=mypopy@gmail.com \
    --cc=barryjzhao@tencent.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=mypopydev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git