* Re: [FFmpeg-devel] [PATCH] avformat/libsrt: use a larger buffer for find_info_tag
[not found] <tencent_2A522DEA9A2340B19A6C9F62ABA44E957008@qq.com>
@ 2022-03-29 2:21 ` "zhilizhao(赵志立)"
2022-03-29 6:11 ` mypopy
0 siblings, 1 reply; 3+ messages in thread
From: "zhilizhao(赵志立)" @ 2022-03-29 2:21 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Ping.
> On Aug 14, 2021, at 6:43 PM, Zhao Zhili <quinkblack@foxmail.com> wrote:
>
> The upper limit of strlen(streamid) is 512. Use a larger buffer for
> future proof, for example, deal with percent-encoding.
> ---
> libavformat/libsrt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c
> index e5701625b8..a66c85d3a2 100644
> --- a/libavformat/libsrt.c
> +++ b/libavformat/libsrt.c
> @@ -513,7 +513,7 @@ static int libsrt_open(URLContext *h, const char *uri, int flags)
> {
> SRTContext *s = h->priv_data;
> const char * p;
> - char buf[256];
> + char buf[1024];
> int ret = 0;
>
> if (srt_startup() < 0) {
> --
> 2.31.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avformat/libsrt: use a larger buffer for find_info_tag
2022-03-29 2:21 ` [FFmpeg-devel] [PATCH] avformat/libsrt: use a larger buffer for find_info_tag "zhilizhao(赵志立)"
@ 2022-03-29 6:11 ` mypopy
2022-03-30 2:31 ` Steven Liu
0 siblings, 1 reply; 3+ messages in thread
From: mypopy @ 2022-03-29 6:11 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Tue, Mar 29, 2022 at 10:21 AM "zhilizhao(赵志立)"
<quinkblack@foxmail.com> wrote:
>
> Ping.
>
> > On Aug 14, 2021, at 6:43 PM, Zhao Zhili <quinkblack@foxmail.com> wrote:
> >
> > The upper limit of strlen(streamid) is 512. Use a larger buffer for
> > future proof, for example, deal with percent-encoding.
> > ---
> > libavformat/libsrt.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c
> > index e5701625b8..a66c85d3a2 100644
> > --- a/libavformat/libsrt.c
> > +++ b/libavformat/libsrt.c
> > @@ -513,7 +513,7 @@ static int libsrt_open(URLContext *h, const char *uri, int flags)
> > {
> > SRTContext *s = h->priv_data;
> > const char * p;
> > - char buf[256];
> > + char buf[1024];
> > int ret = 0;
> >
> > if (srt_startup() < 0) {
> > --
> > 2.31.1
LGTM, thx
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avformat/libsrt: use a larger buffer for find_info_tag
2022-03-29 6:11 ` mypopy
@ 2022-03-30 2:31 ` Steven Liu
0 siblings, 0 replies; 3+ messages in thread
From: Steven Liu @ 2022-03-30 2:31 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Steven Liu
> 2022年3月29日 下午2:11，mypopy@gmail.com 写道：
>
> On Tue, Mar 29, 2022 at 10:21 AM "zhilizhao(赵志立)"
> <quinkblack@foxmail.com> wrote:
>>
>> Ping.
>>
>>> On Aug 14, 2021, at 6:43 PM, Zhao Zhili <quinkblack@foxmail.com> wrote:
>>>
>>> The upper limit of strlen(streamid) is 512. Use a larger buffer for
>>> future proof, for example, deal with percent-encoding.
>>> ---
>>> libavformat/libsrt.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c
>>> index e5701625b8..a66c85d3a2 100644
>>> --- a/libavformat/libsrt.c
>>> +++ b/libavformat/libsrt.c
>>> @@ -513,7 +513,7 @@ static int libsrt_open(URLContext *h, const char *uri, int flags)
>>> {
>>> SRTContext *s = h->priv_data;
>>> const char * p;
>>> - char buf[256];
>>> + char buf[1024];
>>> int ret = 0;
>>>
>>> if (srt_startup() < 0) {
>>> --
>>> 2.31.1
>
> LGTM, thx
Applied as 3721aaeaaae9f817abb843117ae8dae1dc280a7f
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Thanks
Steven Liu
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-30 2:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <tencent_2A522DEA9A2340B19A6C9F62ABA44E957008@qq.com>
2022-03-29 2:21 ` [FFmpeg-devel] [PATCH] avformat/libsrt: use a larger buffer for find_info_tag "zhilizhao(赵志立)"
2022-03-29 6:11 ` mypopy
2022-03-30 2:31 ` Steven Liu
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git