From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B67FC405D0 for ; Fri, 25 Feb 2022 21:07:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0F939689F08; Fri, 25 Feb 2022 23:07:58 +0200 (EET) Received: from mail-vk1-f173.google.com (mail-vk1-f173.google.com [209.85.221.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CFCBA687FCE for ; Fri, 25 Feb 2022 23:07:50 +0200 (EET) Received: by mail-vk1-f173.google.com with SMTP id w128so2201680vkd.3 for ; Fri, 25 Feb 2022 13:07:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=MG7CEOlysQLZkPL2HQJYuvLgv+XQXHbJz/nsRufBa9Q=; b=bO++HInO0fxO1QakWJKjnBijjESFU0NSt/vF0INyy6fhqBSMpZTQF/bFM38zLkBqsI Gg2UrqDNuuoAZLZOa46+axmlNGvvUdSTBJ98odJzA29z44Z7vwHeS1/5p/YKDH7qUo4r 05TKbG0UX9Y7TtupT6BOva7SiO9lrJBSFsIRW+OlplbdtebgCkkYgC1zBS9XZtCEFjU0 DAMFN83EBB8YjmG1j120UCb094+uZ5awyriWQyPLA7vCvbIe/k1yoo7yli/9yW3Iy6tJ 9TgYGRKCU6tiIBBTamL1qznLoXlG7jckIxSauPIi8y6eOfaumuzHZdkzHXMpVkE/UuFn Iu2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=MG7CEOlysQLZkPL2HQJYuvLgv+XQXHbJz/nsRufBa9Q=; b=QZqUd6O7IibQLS1jLB2EcmFY/bWwwGypt1BdkqLlkpoXZpgpYCpWLBdP1kPdhWrIlP hLzh9foMBrIRU0OxnHWwn++rbTU4h6Rl4lDHG9WqgYWamSAtFNu0b8NB/AZt097MZcYU J4vRpANQXqd2lO/5uGdFkXq5Ax66a8M+rhOx4XY/k/TzyhieZ58CwMWtefn33v6l3DuG Pz79Rk9gxx3PdxJVWCxTWybz2gBiCHAZc6k7niCGmuVjZFthOsd2KUPiUuTOAFB0RYQS C+jI8TLG27+VC5z+/7PCadK3jmFl9ueI6MOa9HATkwOWaouZWhNeYa1lRtor+5OSIAEu U9rA== X-Gm-Message-State: AOAM5331NAJ6M8S/erDhUHRdln0U+2YI1s6pQP+gl1YxQaHkR/xL+vBI QUmjEExrnlJoePgiUhxxCA0VI+4D3fq2KvaZaZwOmths X-Google-Smtp-Source: ABdhPJwh5tCQeD2t1SM30Rq01kPaFyxz7EHhw5gMZaTY+OYB9HbQeRmliYxquFIP9FoIaHPPvu+NkM068JB7vpeM3HE= X-Received: by 2002:a1f:2189:0:b0:32d:2398:5262 with SMTP id h131-20020a1f2189000000b0032d23985262mr4082297vkh.8.1645823268853; Fri, 25 Feb 2022 13:07:48 -0800 (PST) MIME-Version: 1.0 References: <20220224203039.CD4BB41059B@natalya.videolan.org> In-Reply-To: From: Thierry Foucu Date: Fri, 25 Feb 2022 13:07:11 -0800 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_tpad: if there is no frame to clone return early X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, Feb 24, 2022 at 11:50 PM Paul B Mahol wrote: > On Thu, Feb 24, 2022 at 11:21 PM Thierry Foucu wrote: > > > On Thu, Feb 24, 2022 at 2:19 PM Thierry Foucu wrote: > > > > > > > > > > > On Thu, Feb 24, 2022 at 1:50 PM Paul B Mahol wrote: > > > > > >> On Thu, Feb 24, 2022 at 10:36 PM Thierry Foucu > > wrote: > > >> > > >> > On Thu, Feb 24, 2022 at 1:28 PM Paul B Mahol > > wrote: > > >> > > > >> > > On Thu, Feb 24, 2022 at 10:12 PM Thierry Foucu > > >> wrote: > > >> > > > > >> > > > On Thu, Feb 24, 2022 at 12:30 PM Paul B Mahol > > > >> > wrote: > > >> > > > > > >> > > > > ffmpeg | branch: master | Paul B Mahol | > Thu > > >> Feb > > >> > 24 > > >> > > > > 20:32:41 2022 +0100| > [3715f2f8643695940582ce040b7a052cccfb9db2] > > | > > >> > > > > committer: Paul B Mahol > > >> > > > > > > >> > > > > avfilter/vf_tpad: if there is no frame to clone return early > > >> > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=3715f2f8643695940582ce040b7a052cccfb9db2 > > >> > > > > --- > > >> > > > > > > >> > > > > libavfilter/vf_tpad.c | 5 +++++ > > >> > > > > 1 file changed, 5 insertions(+) > > >> > > > > > > >> > > > > diff --git a/libavfilter/vf_tpad.c b/libavfilter/vf_tpad.c > > >> > > > > index e5acece1e4..120dbcb4d3 100644 > > >> > > > > --- a/libavfilter/vf_tpad.c > > >> > > > > +++ b/libavfilter/vf_tpad.c > > >> > > > > @@ -148,6 +148,11 @@ static int activate(AVFilterContext *ctx) > > >> > > > > frame->data, frame->linesize, > > >> > > > > 0, 0, frame->width, > > frame->height); > > >> > > > > } else if (s->stop_mode == 1) { > > >> > > > > + if (!s->cache_stop) { > > >> > > > > + s->pad_stop = 0; > > >> > > > > + ff_outlink_set_status(outlink, AVERROR_EOF, > > >> s->pts); > > >> > > > > + return 0; > > >> > > > > + } > > >> > > > > frame = av_frame_clone(s->cache_stop); > > >> > > > > if (!frame) > > >> > > > > return AVERROR(ENOMEM); > > >> > > > > > > >> > > > > > > >> > > > The problem with this solution is that the tpad will then not do > > >> what > > >> > we > > >> > > > are expecting, which is padding video track, and the output file > > >> will > > >> > not > > >> > > > have the desired duration. > > >> > > > Will it not be better to just output black frame (aka stop_mode > == > > >> 0) , > > >> > > > something like that? > > >> > > > > > >> > > > > >> > > I doubt that, clone is clone, there is no point in padding stream > > that > > >> > have > > >> > > no frames at all. > > >> > > > > >> > > > > >> > > > > >> > The sample I forwarded to JB has video frames. The problem was that > > >> there > > >> > was a re-init of the filter chain after a resolution change and > after > > >> the > > >> > re-init, there were no frames but got frames before the re-init. > > >> > I will understand for a media file which has NEVER received a video > > >> frame > > >> > and in this case, this is the correct solution. > > >> > > > >> > > >> Hmm, so you encode output with resolution change, why not use scale > > filter > > >> as first filter and then no resolution ever change for rest of graph? > > >> Adding support for resolution changes to all filters is very time > > >> consuming > > >> task and I see no real benefit in doing that now. > > >> > > > > > > We do have the scale filter in front of the tpad filter. Here is the > > > filter chain we are using > > > > > > > > > idet=1.04:1.5,yadif=0:-1:1,scale=+528:+864:flags=bicubic,setsar=1,fps=fps=16.601,tpad=stop_mode=clone:stop_duration=2808ms > > > > > > > Is this just increasing size instead of setting constant one? > Nope. It will just scale the video to 528x864 > > > > > And it does crash. > > > > > > Even just fps=fps=16.601,tpad=stop_mode=clone:stop_duration=2808ms > > > reproduce the problem. > > > > > > > Maybe an option to the tpad filter to decide what should be the output > when > > the stop_mode == 1 and cache_stop is NULL? > > So, in some cases, people may want a color frame, and some other will > just > > want to exit right away? > > > > That is too much for a special option. > I understand. I'm just worried that due to some re-init of the filter chain and the fact there are filters which may or may not output a frame after the re-init, the tpad filter will then have no cache frame to clone. And in this case, the file does not have the length expected. I guess if it is documented or av_log, people will be aware of the potential issue. Anyway, thanks a lot for the quick fix. > > > > > > > > > > > > >> > > >> > > >> > > > >> > > > >> > > > > > >> > > > iff --git a/libavfilter/vf_tpad.c b/libavfilter/vf_tpad.c > > >> > > > index e5acece1e4..5e4062e9f2 100644 > > >> > > > --- a/libavfilter/vf_tpad.c > > >> > > > +++ b/libavfilter/vf_tpad.c > > >> > > > @@ -140,7 +140,7 @@ static int activate(AVFilterContext *ctx) > > >> > > > ff_outlink_set_status(outlink, AVERROR_EOF, > s->pts); > > >> > > > return 0; > > >> > > > } > > >> > > > - if (s->stop_mode == 0) { > > >> > > > + if (s->stop_mode == 0 || !s->cache_stop) { > > >> > > > frame = ff_get_video_buffer(outlink, outlink->w, > > >> > > outlink->h); > > >> > > > if (!frame) > > >> > > > return AVERROR(ENOMEM); > > >> > > > > > >> > > > > > >> > > > > > >> > > > > > >> > > > > _______________________________________________ > > >> > > > > ffmpeg-cvslog mailing list > > >> > > > > ffmpeg-cvslog@ffmpeg.org > > >> > > > > https://ffmpeg.org/mailman/listinfo/ffmpeg-cvslog > > >> > > > > > > >> > > > > To unsubscribe, visit link above, or email > > >> > > > > ffmpeg-cvslog-request@ffmpeg.org with subject "unsubscribe". > > >> > > > > > > >> > > > > > >> > > > > > >> > > > -- > > >> > > > > > >> > > > Thierry Foucu > > >> > > > _______________________________________________ > > >> > > > ffmpeg-devel mailing list > > >> > > > ffmpeg-devel@ffmpeg.org > > >> > > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > >> > > > > > >> > > > To unsubscribe, visit link above, or email > > >> > > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > >> > > > > > >> > > _______________________________________________ > > >> > > ffmpeg-devel mailing list > > >> > > ffmpeg-devel@ffmpeg.org > > >> > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > >> > > > > >> > > To unsubscribe, visit link above, or email > > >> > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > >> > > > > >> > > > >> > > > >> > -- > > >> > > > >> > Thierry Foucu > > >> > _______________________________________________ > > >> > ffmpeg-devel mailing list > > >> > ffmpeg-devel@ffmpeg.org > > >> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > >> > > > >> > To unsubscribe, visit link above, or email > > >> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > >> > > > >> _______________________________________________ > > >> ffmpeg-devel mailing list > > >> ffmpeg-devel@ffmpeg.org > > >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > >> > > >> To unsubscribe, visit link above, or email > > >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > >> > > > > > > > > > -- > > > > > > Thierry Foucu > > > > > > > > > -- > > > > Thierry Foucu > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > -- Thierry Foucu _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".