From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C7E5E421BF for ; Thu, 24 Feb 2022 21:36:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 398EA68B37A; Thu, 24 Feb 2022 23:36:26 +0200 (EET) Received: from mail-vs1-f46.google.com (mail-vs1-f46.google.com [209.85.217.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0372968B10A; Thu, 24 Feb 2022 23:36:15 +0200 (EET) Received: by mail-vs1-f46.google.com with SMTP id y26so3577615vsq.8; Thu, 24 Feb 2022 13:36:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YZmk6OBLPrxmSBJPzU+j6cTGYv/0mevJemBex8OHW3g=; b=FPX96y4Aa0Pc3Ii8H5iypbFLAnnR9nO4lf+vbMTl/oTFTqg7Zbxf+5mEROGZtFFkGW eS+Gc7PJm/nE9Xo+uMJQAYqG6bNa1EEILV+O42QaXNXB5xMZSZOP6sv/tODljSZZsxMt ZG688sQ8xwDsUDEx/x3UeTJBLx4J0d42UhHMgKC3a24zmNCPfot4SeY/0Z88PaUFZFQH J1huMpI6QrxbqILxQs1q0syDC+pH+BKA+8RFbe46Oz/1x4kkCcis4P7lT6lg615ct/OU DoYiRp3/cN0Ii+/QqlGuMdZUpyJDo3QJKiLFnxpeTVZzqL7R53W7vWNLdYGR3CTjfFVk RuEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YZmk6OBLPrxmSBJPzU+j6cTGYv/0mevJemBex8OHW3g=; b=u58WV881uZrEl2si1Xe2CCDOjYeEoi13iT1V3vRW9HZCBhwh2yf4duw8bQZFuJT9Bo kFhJduUkugVT7C6jiRBMNI+dTBacxsE3FVfLkqiS8MJVWMXPkfWiiBoGWZq5d0xTmV6W wTdy+rae5mkwuVKhGkGCxAoqA11UN1ODgkaAo//uE0DhXSzoA9/OCFnQy4V2Y6kjTge/ Jm4LvZrBl2ZyzHSQWrSOPYKiRtDg0Z8lD7XOGpDzlxakfyKqqf2irfZ2KfkcyAR3v69n gqkq3lpj7N3HNMzG1jCcztbJfO1LDbr5OUNOuTMG3fp6tCFmHIV0YFFtlMGJWhgY7U4T D27Q== X-Gm-Message-State: AOAM531jV4BB4w7h/vtYjvjKvu2gNGGJ48jrBsK+9nzZH3qj79D9xg5y p/E6flQbcwxFCFIybEIkj/MImaHwlPV9ptm/htbpVzHY X-Google-Smtp-Source: ABdhPJxFnQ8QbkTIfu1Gdr4aTbCW5nJxsRShD0lUwSlyLPPp4L3V30Ia9rhxjUeIuXA+9FUr7zS38STAoIFaoTjeD3s= X-Received: by 2002:a67:fd4f:0:b0:31b:f151:a502 with SMTP id g15-20020a67fd4f000000b0031bf151a502mr2063911vsr.39.1645738573265; Thu, 24 Feb 2022 13:36:13 -0800 (PST) MIME-Version: 1.0 References: <20220224203039.CD4BB41059B@natalya.videolan.org> In-Reply-To: From: Thierry Foucu Date: Thu, 24 Feb 2022 13:35:36 -0800 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_tpad: if there is no frame to clone return early X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: FFmpeg git commit log and discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, Feb 24, 2022 at 1:28 PM Paul B Mahol wrote: > On Thu, Feb 24, 2022 at 10:12 PM Thierry Foucu wrote: > > > On Thu, Feb 24, 2022 at 12:30 PM Paul B Mahol wrote: > > > > > ffmpeg | branch: master | Paul B Mahol | Thu Feb 24 > > > 20:32:41 2022 +0100| [3715f2f8643695940582ce040b7a052cccfb9db2] | > > > committer: Paul B Mahol > > > > > > avfilter/vf_tpad: if there is no frame to clone return early > > > > > > > > > > > > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=3715f2f8643695940582ce040b7a052cccfb9db2 > > > --- > > > > > > libavfilter/vf_tpad.c | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/libavfilter/vf_tpad.c b/libavfilter/vf_tpad.c > > > index e5acece1e4..120dbcb4d3 100644 > > > --- a/libavfilter/vf_tpad.c > > > +++ b/libavfilter/vf_tpad.c > > > @@ -148,6 +148,11 @@ static int activate(AVFilterContext *ctx) > > > frame->data, frame->linesize, > > > 0, 0, frame->width, frame->height); > > > } else if (s->stop_mode == 1) { > > > + if (!s->cache_stop) { > > > + s->pad_stop = 0; > > > + ff_outlink_set_status(outlink, AVERROR_EOF, s->pts); > > > + return 0; > > > + } > > > frame = av_frame_clone(s->cache_stop); > > > if (!frame) > > > return AVERROR(ENOMEM); > > > > > > > > The problem with this solution is that the tpad will then not do what we > > are expecting, which is padding video track, and the output file will not > > have the desired duration. > > Will it not be better to just output black frame (aka stop_mode == 0) , > > something like that? > > > > I doubt that, clone is clone, there is no point in padding stream that have > no frames at all. > > > The sample I forwarded to JB has video frames. The problem was that there was a re-init of the filter chain after a resolution change and after the re-init, there were no frames but got frames before the re-init. I will understand for a media file which has NEVER received a video frame and in this case, this is the correct solution. > > > > iff --git a/libavfilter/vf_tpad.c b/libavfilter/vf_tpad.c > > index e5acece1e4..5e4062e9f2 100644 > > --- a/libavfilter/vf_tpad.c > > +++ b/libavfilter/vf_tpad.c > > @@ -140,7 +140,7 @@ static int activate(AVFilterContext *ctx) > > ff_outlink_set_status(outlink, AVERROR_EOF, s->pts); > > return 0; > > } > > - if (s->stop_mode == 0) { > > + if (s->stop_mode == 0 || !s->cache_stop) { > > frame = ff_get_video_buffer(outlink, outlink->w, > outlink->h); > > if (!frame) > > return AVERROR(ENOMEM); > > > > > > > > > > > _______________________________________________ > > > ffmpeg-cvslog mailing list > > > ffmpeg-cvslog@ffmpeg.org > > > https://ffmpeg.org/mailman/listinfo/ffmpeg-cvslog > > > > > > To unsubscribe, visit link above, or email > > > ffmpeg-cvslog-request@ffmpeg.org with subject "unsubscribe". > > > > > > > > > -- > > > > Thierry Foucu > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > -- Thierry Foucu _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".