From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2F2B849E9A for ; Wed, 15 May 2024 11:22:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DF8C868D6B9; Wed, 15 May 2024 14:22:39 +0300 (EEST) Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3695F68D274 for ; Wed, 15 May 2024 14:22:33 +0300 (EEST) Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-574ea5184abso1676871a12.3 for ; Wed, 15 May 2024 04:22:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715772151; x=1716376951; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=pnKNe5/A5uFjfqXV7CKeFAMMZ0TBTo9uaDdRuvs6c3I=; b=gvx3UVGTzaksuFW2pgf1Kgkodw62Wd8im9K2PYfAtRtkUA8zQOmPGddISF6WDJxkTA /iOivjrCleL2VCH64e+5c0q31pPennfHB7EfXDtYqBdLKx2BTGckPMgdvUqweJ9nRHr8 FU7GskwgbM1YOTi5xyEYHjKce1kGaq3kXDJuaE76gANTmxjMF44EOP2RyK11U0Ww0/QB jhYF1tC8m3LZoYFkuRtdy5KTFI01H0N/hxkQIs42XuW0ekem6jKtzSbrYunGB6BQ5uvw udZGA1VDePlmAnvbntI6V7N3PGim8gTUr4M3DMkGyfFOB7MreysIMkh6j/+lgWZRNeh6 0vIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715772151; x=1716376951; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pnKNe5/A5uFjfqXV7CKeFAMMZ0TBTo9uaDdRuvs6c3I=; b=Idy3pud2cRF2rrPA2RYAGheSxf98E0pQpYj+nYiTvMAvVlyJ4WL3FiwTutPL88ql9X XLPAlz4i4Qhf0xaGIp1nSuqkU4pWfRPz2GpFM7NYsYKoKo2MfPZLaCaXHD7dWlyo/E4i +z1E2w/y7LGjtXaw+3bySTbK6xjC541n8w7KKwgtl39NSmsKuZl1G0f+K8+ukb731A8x gg73rjTHhhPuVeQrt5+wPp1JlmNKPpekS2IpVdJ18TI4jNv39zfVbe+VQ2+j4iStiRxa JeJC6yMXpn639yM7PLoVPZr8VCntqBTsJsUiv8VeFAydargPBBO1AhN39e27Ip7/GI0m ZOGg== X-Gm-Message-State: AOJu0YyA0+DvkPogNqGK+/3LP+T8dh2hEUW0MsLAeA0/1Xfdaa+NIPAL 5Q3NNlRrB3b1bKsBdnjLVAJqccowb9DgF3ZUWNTuXgWMvkw0SkRbWPIMtZvRMdyv1DYMwzObjII 2ziLcYSQVlmQcaO1W+cgl9crB2ng2mE6X X-Google-Smtp-Source: AGHT+IFw9MFUQrfptheBXZ0BXMjhrn/KWPLsghTjckVM+bob++GosekbIHGz+S23pvMbdMoEpN3EGJnQxOtX0xTzAWo= X-Received: by 2002:a50:c048:0:b0:574:ec30:6c94 with SMTP id 4fb4d7f45d1cf-574ec30710cmr2468812a12.19.1715772151372; Wed, 15 May 2024 04:22:31 -0700 (PDT) MIME-Version: 1.0 References: <20240515094302.1912784-1-hiccupzhu@gmail.com> In-Reply-To: From: Hiccup Zhu Date: Wed, 15 May 2024 19:22:19 +0800 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] libavformar/demux: fix dts being incorrectly set to pts X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas: > > Shiqi Zhu: > > Signed-off-by: Shiqi Zhu > > --- > > libavformat/demux.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavformat/demux.c b/libavformat/demux.c > > index ecefe7e0a7..e19b8b6473 100644 > > --- a/libavformat/demux.c > > +++ b/libavformat/demux.c > > @@ -1112,7 +1112,7 @@ static void compute_pkt_fields(AVFormatContext *s, AVStream *st, > > /* presentation is not delayed : PTS and DTS are the same */ > > if (pkt->pts == AV_NOPTS_VALUE) > > pkt->pts = pkt->dts; > > - update_initial_timestamps(s, pkt->stream_index, pkt->pts, > > + update_initial_timestamps(s, pkt->stream_index, pkt->dts, > > pkt->pts, pkt); > > if (pkt->pts == AV_NOPTS_VALUE) > > pkt->pts = sti->cur_dts; > > Can you provide an example for which this matters? > > - Andreas There is no example yet, I saw this when reviewing the code. So, is it reasonable to use pts instead of dts settings here? - Shiqi _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".