From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BA06D4AB6C for ; Thu, 13 Jun 2024 02:05:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 956B168D979; Thu, 13 Jun 2024 05:05:09 +0300 (EEST) Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6B12268D8FA for ; Thu, 13 Jun 2024 05:05:02 +0300 (EEST) Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-2ebeefb9b56so5011681fa.0 for ; Wed, 12 Jun 2024 19:05:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718244301; x=1718849101; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=rI7AELHX+eQQqgwJlY2/lp0hsiU8ctLd5pdAOBarY9w=; b=WE71ok6O3dH+gVb90CLJ1B1nQjKJAM9He2YMpF5FrjUioh+dtBZlRmpzEXMR7wmXpZ U9p0Smp61DkS8oKRIx4WrPpGWyjZRCBEcupWCjTC2wMVRldaZRKwNReHuX7jkdmZWRTU V+cvNoHYBA65N1bxQPnfp7xYmF331aKieIMA1Nr24Wb2+tWjIi4qppnm9tr+Op2g3SQG 1osab1t5lC85m5u6EzBZl2ELimotsIIz7twKr2mx6NXNSFqqTZ/0fnA4NQBuqFMWUwkI HK59ESUXdak7GYA7w4JvTi26gqEbIa56bqE8COjuvzG5pNFhSgtVhh2ggVbCIfk5Ocnv CCWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718244301; x=1718849101; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rI7AELHX+eQQqgwJlY2/lp0hsiU8ctLd5pdAOBarY9w=; b=FYStNPitbW2brFY/G1LWQ6Dcz7CxgLF329NxvsW6JkRYDRtcAq3jePyAyjBiflJnAN kXRW34RfQB4vJpvl3HMy2JZWh4MKojZFKHkDkHJxlyyoRsThJj1dd1dAqoidmZg2mVjM PC/Jfakhwx9d5tZ1xFy4LvFHhJsVIinFZpJdiy48xpgxqMeYSAnLuLl8KRJSO5k3V8rR chwvF2ZaUEXlrBCuwWNujphb1oot7RuYb5WdrdYkJBWMNx2qWZs8Yeadn53wv7sq1AVI rUwgF6xr7RTsO3WPE7ptVfTwMFjhoXrLy9L7o+ZvJAlrj0l3h7HAytKvcRL5BeIqluM+ WuPw== X-Gm-Message-State: AOJu0YyfSue+Jw4lMWibpBruLapCOw8QSQdHUpiD7oBJ5Zq4GbjxT4tJ aCJ6Ineg7m3pdS2ZTXyKX/bl1nkoQdbIgMz4J4w7IVWyMJob+OYgR5jmULZ7gh2ECI6tFx2Ypt1 2/aVbFqEqr45XCKQ093dxkuFIWPkc9PB8 X-Google-Smtp-Source: AGHT+IE2a7XiXjxrZBKcpd+m/PmM325f+yGv5KUbLsgX6YdjFeokIoEBPmY5dt3J6g2bJ8q46wWwdl4Rv/r9p94Brkk= X-Received: by 2002:a2e:bc17:0:b0:2eb:fdd4:cd5c with SMTP id 38308e7fff4ca-2ebfdd4cdf7mr28084761fa.42.1718244301043; Wed, 12 Jun 2024 19:05:01 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Shiqi Zhu Date: Thu, 13 Jun 2024 10:04:49 +0800 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] tests/checkasm: Remove check on linux perf fd in uninit X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 13 Jun 2024 at 01:36, Zhao Zhili wrote: > > From: Zhao Zhili > > The check should be >= 0, not > 0. The check itself is redundant > since uninit only being called after init is success. > --- > tests/checkasm/checkasm.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c > index 28237b4d25..bbcc90f91f 100644 > --- a/tests/checkasm/checkasm.c > +++ b/tests/checkasm/checkasm.c > @@ -814,8 +814,7 @@ static int bench_init(void) > static void bench_uninit(void) > { > #if CONFIG_LINUX_PERF > - if (state.sysfd > 0) > - close(state.sysfd); > + close(state.sysfd); Is this better? if (state.sysfd >= 0) { close(state.sysfd); state.sysfd = -1; } > #endif > } > > -- > 2.42.0 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".