From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E0EBC4A40C for ; Wed, 27 Mar 2024 18:58:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A330A68D6A8; Wed, 27 Mar 2024 20:58:03 +0200 (EET) Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5E6A968D0BD for ; Wed, 27 Mar 2024 20:57:57 +0200 (EET) Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-513ccc70a6dso139617e87.1 for ; Wed, 27 Mar 2024 11:57:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711565876; x=1712170676; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7MLzG+MhE0ZtuE68kkCwPNO317GqSVPS0oJyziWWL6c=; b=VOfUcjHsP4Ayu8hIG/RQSPzpk0KTV98tg0ylSNykSK32k8Mi7aOX1FCdC28D8PdFGM oq6e7mp0sEQxHfCfwZYUHX8VieVy8HBT++w0dA52WxYGk1mWTE7casAz4EjUr2vmUiNp kTjmpxcaKo2Eu/NhqvBQv0ZeY1sYXrZKgLd2qYz+v1X4PRuhts2FsFDxZWle7P5wL5qm U/jDi8/WAFkjsKCqbY0Cnu3KNHaowMtI06yATIM6SPlMA58PIz7fcDhwSMf1pNpiYwgs 5PaFAjm7mg880ucGrxlSoyozxXzyRT9/Q0pbI4ftjNd4wDQq/9e23CZnYmd6tv591f2k cO1Q== X-Gm-Message-State: AOJu0YwSv0iNtRZuDD2CNEqjDlzvt/qCiGvw3faBFKKcYWEXNORau5+8 NxwEUXUmUFgFmOy94uIrZvc6swR83suDRgPUkd+rH+dwjQl3VJk/0F72lBJg+yYXs30JR2aHVqf PozNr9ZeU1m8sdNrERA1oAgu2pl5Q/4M4P2YywGmhNrQpM2nuUuz/BQ== X-Google-Smtp-Source: AGHT+IE5YGLgjKY9twpEea3nbidSk5LWIp1bew8MO9ogSpoAI0iZ/OKpd/DonINyWgCRU9U4cr8tHsUW+VhMXcTU3Vk= X-Received: by 2002:ac2:5d44:0:b0:515:c113:381c with SMTP id w4-20020ac25d44000000b00515c113381cmr288543lfd.30.1711565876168; Wed, 27 Mar 2024 11:57:56 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Date: Wed, 27 Mar 2024 18:57:45 +0000 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avformat/rtmpproto: Fix segfault X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Armin Hasitzka via ffmpeg-devel Reply-To: FFmpeg development discussions and patches Cc: Armin Hasitzka Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Ooooh interesting, I see (makes a lot of sense)! I can confirm, btw; your updated fix (from 324509) works for me (no segfault + clean shutdown)! ... I will comment on the other thread as soon as the email comes through! Thanks a lot! Armin On Wed, 27 Mar 2024 at 18:21, Andreas Rheinhardt < andreas.rheinhardt@outlook.com> wrote: > Armin Hasitzka via ffmpeg-devel: > > Hi, > > > > we found this when testing with rejected RTMP streams. > > > > Best > > Armin > > Thanks for the report and the patch; yet actually freeing them manually > is not only harmful, but also unnecessary, as these strings can be set > via AVOptions; therefore they will be freed generically (which is also > the reason why rtmp_close() does not have code to free them). I sent a > patch for this here: > https://ffmpeg.org/pipermail/ffmpeg-devel/2024-March/324509.html Would > be nice if you could test it. > > - Andreas > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".