From: Armin Hasitzka via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Armin Hasitzka <armin@grabyo.com>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/rtmpproto: Fix segfault
Date: Wed, 27 Mar 2024 18:57:45 +0000
Message-ID: <CACVm-AennDHB8U9Xjr-wPtKFBSrwWeMUtOPo=JA6TMMp=x_E9w@mail.gmail.com> (raw)
In-Reply-To: <GV1P250MB0737FAB69DAB397E147FF11D8F342@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>
Ooooh interesting, I see (makes a lot of sense)! I can confirm, btw; your
updated fix (from 324509) works for me (no segfault + clean shutdown)! ...
I will comment on the other thread as soon as the email comes through!
Thanks a lot!
Armin
On Wed, 27 Mar 2024 at 18:21, Andreas Rheinhardt <
andreas.rheinhardt@outlook.com> wrote:
> Armin Hasitzka via ffmpeg-devel:
> > Hi,
> >
> > we found this when testing with rejected RTMP streams.
> >
> > Best
> > Armin
>
> Thanks for the report and the patch; yet actually freeing them manually
> is not only harmful, but also unnecessary, as these strings can be set
> via AVOptions; therefore they will be freed generically (which is also
> the reason why rtmp_close() does not have code to free them). I sent a
> patch for this here:
> https://ffmpeg.org/pipermail/ffmpeg-devel/2024-March/324509.html Would
> be nice if you could test it.
>
> - Andreas
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-03-27 18:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 17:04 Armin Hasitzka via ffmpeg-devel
2024-03-27 18:21 ` Andreas Rheinhardt
2024-03-27 18:57 ` Armin Hasitzka via ffmpeg-devel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACVm-AennDHB8U9Xjr-wPtKFBSrwWeMUtOPo=JA6TMMp=x_E9w@mail.gmail.com' \
--to=ffmpeg-devel@ffmpeg.org \
--cc=armin@grabyo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git