From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 0FB364E307 for ; Mon, 10 Mar 2025 20:24:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 46EEB68E0D0; Mon, 10 Mar 2025 22:24:23 +0200 (EET) Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C8FC468DF62 for ; Mon, 10 Mar 2025 22:24:16 +0200 (EET) Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-54963160818so5454254e87.2 for ; Mon, 10 Mar 2025 13:24:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=onemimir.com; s=google; t=1741638256; x=1742243056; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=vz4/FvdJuLacxaXntO8ZVj1DdkSorqez1onvropeWbQ=; b=D8+EPCopWojUnDKYvhKardROTBMdheDkWhkeOgcVosKEJShMlW76rVLb5kGyxObJFN i/3ztJjZcyiBvbcbcNVs6ZKvMxCGPTKQeXSi3LNqdGV5CnS4nNhwjzEuvgzj390hWX+3 +RvnepQD+3/zhr1u7mZ54I8wwbrW2s1QwhcwRZuVLgQFqYEg9f+ZNp8pBsykE0hb+Cjl Jc7bP/ILLNrgBR8RpzQ6mPOCdQdp9x8PS0xIVx03yYpz3OZG7HJgKELY+lwWCAJbUi19 zaaUDw1g4n1nacU0mGnUHK2TqeTA9lvyjePFAwfzg3uCggLn9sXef0VRKqdLMsOB7HNO MeQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741638256; x=1742243056; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vz4/FvdJuLacxaXntO8ZVj1DdkSorqez1onvropeWbQ=; b=Uo+gOa6inIg6o5AaO36itSswtZxD+qdPDJ04rWAxPBHoYppt9HMMc7ul5XaQQkfBqO XH5GfXleo+zZrpz3gDqfBITBE3SM8UVK2Torspeq0j0N5B37vU7wWEZbC6SUym3xd42f ugbePqzRjAq+wb/NxScTOv32/k4da2gWSCweD/D6ab8i0/Ju+AsjS75WO5BZ0WFiM3Oa zAJhdhlqIvMYLvN2zhfp+hNPojJNHzmd584ckHdepWQ34+NRYjUIcELgFi4TSgMPfL7k vHAY31KrVhwCzYDrS9v9FmgVRu//gr8+oSH16i8GTQcN1OqKdeXFosvqhXNafntwoKOQ 7jOg== X-Gm-Message-State: AOJu0YzRSW3AkjG00Zq11sKDaK1e6C+C8jR0wRPVIOvo7f0QHZ+6iUcS L8F5fzrcGFrpghgEj/9Cr2XZBPSzyAlZuVWxuZlY37RyeLdNI5POiiXLBECJMiteVzi/KQehAaL Zk8wL8ptIBS3y08eQPhMk8pVuJb78Qi5WpuA+0n186X8WjDIVxtxC4TlmjRTzLYAO2KlaUaQj2Q nnsoaKIRJ665NYqsSzU/X0Xbvc/bxGQcyDkr0= X-Gm-Gg: ASbGncv+9c/zz/EBS7VKuoI77bHYK6w0mFlHCNQREjJz5yRsAe9WH//MH/ExV9T5NjE IPYcMrCxtSuKQR90kNUs/dvlVBwcRIqHGntdaWW4Aixvtf4VHwDxVB9CokGxX1fzBOW2BMQn86f mxOlyWIu785F1xazualCJeXObMsxjFfxXcauKxBoUK10UO3923ccQ31XWm X-Google-Smtp-Source: AGHT+IEXCyK4NpTf+BebTNakPOa1U/oECnziaNlyuBiRhsW2vWfL4EyQI9BtSM7zEi50cI+mnDkQ6A97DcIJL5yXlxg= X-Received: by 2002:a05:6512:118a:b0:549:7145:5d28 with SMTP id 2adb3069b0e04-54990e67465mr4034604e87.25.1741638255867; Mon, 10 Mar 2025 13:24:15 -0700 (PDT) MIME-Version: 1.0 References: <20250309180813.GI4991@pb2> <20250310164423.1998883-1-anders@onemimir.com> <20250310201846.GM4991@pb2> In-Reply-To: <20250310201846.GM4991@pb2> From: Anders Rein Date: Mon, 10 Mar 2025 21:24:05 +0100 X-Gm-Features: AQ5f1JozwZ0vLJqm2Nr_Ab4KCboMIVeOfqle4YWv4fQ3LaVqH_sthD1iLfnJH68 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] Include field_mode information in NUT stream info X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi! Thanks for the feedback.I have no problem adding the "X-" prefix to the field order key, however I was just following the way "r_frame_rate" was passed. As far as I can see this field is not mentioned in nut.txt either and should also be using the X- prefix. Or am I missing something? On Mon, 10 Mar 2025 at 21:19, Michael Niedermayer wrote: > > Hi > > On Mon, Mar 10, 2025 at 05:44:22PM +0100, Anders Rein wrote: > > This will make it possible to transmit raw video over NUT without losing > > the field order information. > > [...] > > > diff --git a/libavformat/nutenc.c b/libavformat/nutenc.c > > index 55efb114c3..abe4e3fb98 100644 > > --- a/libavformat/nutenc.c > > +++ b/libavformat/nutenc.c > > @@ -21,6 +21,7 @@ > > > > #include > > > > +#include "libavcodec/defs.h" > > #include "libavutil/intreadwrite.h" > > #include "libavutil/mathematics.h" > > #include "libavutil/mem.h" > > @@ -560,12 +561,22 @@ static int write_streaminfo(NUTContext *nut, AVIOContext *bc, int stream_id) { > > count += add_info(dyn_bc, "Disposition", ff_nut_dispositions[i].str); > > } > > if (st->codecpar->codec_type == AVMEDIA_TYPE_VIDEO) { > > + const char* field_order; > > uint8_t buf[256]; > > if (st->r_frame_rate.num>0 && st->r_frame_rate.den>0) > > snprintf(buf, sizeof(buf), "%d/%d", st->r_frame_rate.num, st->r_frame_rate.den); > > else > > snprintf(buf, sizeof(buf), "%d/%d", st->avg_frame_rate.num, st->avg_frame_rate.den); > > count += add_info(dyn_bc, "r_frame_rate", buf); > > + > > + // Since the NUT specifications (nut.txt) do not support field order information, > > + // the stream_info side channel is used as a means to transfer this information. > > + // This is strictly not a part of the NUT specifications and should not be required. > > + field_order = ff_nut_serialized_field_order_value_or_null(st->codecpar->field_order); > > + if (field_order != NULL) { > > + count += add_info(dyn_bc, "field_order", field_order); > > + } > > either send a patch to nut.txt or it should be "X-field_order" for non > standard fields > > thx > > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Freedom in capitalist society always remains about the same as it was in > ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". -- Disclaimer: This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error or are not the named addressee, you should not disseminate, distribute or copy this email. Please notify the author by replying to this e-mail and destroy this email and any attachments. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".