From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C337141103 for ; Wed, 16 Mar 2022 12:13:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1437F68AE9E; Wed, 16 Mar 2022 14:13:27 +0200 (EET) Received: from mail-il1-f170.google.com (mail-il1-f170.google.com [209.85.166.170]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E5E7F680C35 for ; Wed, 16 Mar 2022 14:13:20 +0200 (EET) Received: by mail-il1-f170.google.com with SMTP id r11so1374258ila.1 for ; Wed, 16 Mar 2022 05:13:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=4PLoSytDe/lVa4knTlJZEhFWeo/rs8ZilRM9HO/eG50=; b=SLHlX48RqwzS8p6ZpMQ4X4Vrb9R7GBXZBmqd5rN2uG95a0P1jCFv3yY/lNVnu8+kCh WR4NkCKVLlOurFWa+AiV9xf2eNohIz/zTGcJvIPYfLjQcomRgzLGgUhqf1oABXhIzwM9 Pc+lRw+6my4ATE0+CAy/gFHRwIxL+hjbuHQyEISV3sWBEKoJKfr1Nfp9QxTfwEIOK7nr S8S6k9BWZLO+HZoUTRPeOi87qcqI9cw+7sz8zwP2guMikkwnzOHO3jRNcIL07IZiEN1U xbjJYYXNkQ3eFPtvbFSmgzJ5rIAN/3nxPvU4gCxA4PfFI6N6SomQ8xSlGAZ8Kp3z+GN6 TZqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=4PLoSytDe/lVa4knTlJZEhFWeo/rs8ZilRM9HO/eG50=; b=FqzywTOBpc77dVY0KCNfVBbCUPX/dIaoBC20PaPTZGILuB5i9A+l0dLii0NoIhhc05 VLJO9dC/XqHY24LFppQnOBF3ZWYbPWU6Q01SVglXvU16W0LsHUqJYU7TeaD5M78UikDO PsEmunGrRzIOEoEzpwMp/+kumn4Vph7TP+Zpn+uCeif69bEFWy2ap/IrJTpsDZp9PAPD UPE+nFJJG9LQREvN9t6ytN8J81fx3XUYnmxCcBwM7UVV2mI/gHEKTnNFcl+JIFdHzu3x puOydG701HkUIlgMquJalB+/frakN9lTAlJne6LamWZ7NxKSmNFWDDAdDX/c/Vf/cSbY XujQ== X-Gm-Message-State: AOAM5313HZEfQxksKrmNacArfNk/hbl8mAAC3qUWgcpunUatW8MUNybt wVUYxQF9863IvnrQ28QwDG36Ovi0SyF09EK/88AuQfLz5NV4Rg== X-Google-Smtp-Source: ABdhPJwgjIjw5hp6O/aHwrZ5HuiBSMxpcEHmMD1x4amaD+1aCwccx6GT26Nvr4gZ5WH4Ei6B7IqKXcMrfhl3yaKagWE= X-Received: by 2002:a92:6606:0:b0:2c6:254e:dce1 with SMTP id a6-20020a926606000000b002c6254edce1mr23310677ilc.139.1647432798119; Wed, 16 Mar 2022 05:13:18 -0700 (PDT) MIME-Version: 1.0 References: <20220314130459.88494-1-danilchap@google.com> In-Reply-To: From: Danil Chapovalov Date: Wed, 16 Mar 2022 13:13:05 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] Allow to modify max qp configuration parameter in libvpx without reseting the encoder X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0211714138826923829==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0211714138826923829== Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000c2680b05da54d632" --000000000000c2680b05da54d632 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Mar 14, 2022 at 4:28 PM Jan Ekstr=C3=B6m wrote: > > On Mon, Mar 14, 2022 at 3:05 PM Danil Chapovalov > wrote: > > > > --- > > Probably something a la > > avcodec/libvpxenc: enable dynamic quantizer reconfiguration > > ? Thank you, resubmitted with new title > > > libavcodec/libvpxenc.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > > index 8f94ba15dc..45baeed435 100644 > > --- a/libavcodec/libvpxenc.c > > +++ b/libavcodec/libvpxenc.c > > @@ -1658,6 +1658,13 @@ static int vpx_encode(AVCodecContext *avctx, AVP= acket *pkt, > > flags |=3D strtoul(en->value, NULL, 10); > > } > > > > + en =3D av_dict_get(frame->metadata, "max-quantizer", NULL,= 0); > > + if (en) { > > + struct vpx_codec_enc_cfg cfg =3D *enccfg; > > + cfg.rc_max_quantizer =3D strtoul(en->value, NULL, 10); > > + vpx_codec_enc_config_set(&ctx->encoder, &cfg); > > + } > > + > > There is side data already defined for quantizers, AVVideoEncParams / > AV_FRAME_DATA_VIDEO_ENC_PARAMS . > > In other words, this should be handled in a similar manner to ROI, not > as an ad-hoc metadata key in the AVFrame. I've checked struct AVVideoEncParams, it doesn't look fitting: it contains exact qp (plus qp per plane), while my patch suggests changing max-qp limit for current and following frames. AVVideoEncParams also has some extra fields that I'm unsure how to handle (they are unrelated to what I'm trying to do), I haven't found any other struct that would contain something like max qp. What is ROI? What code can I use as an example of your suggestion? > > Cheers, > Jan > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --000000000000c2680b05da54d632 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIPngYJKoZIhvcNAQcCoIIPjzCCD4sCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg ggz4MIIEtjCCA56gAwIBAgIQeAMYYHb81ngUVR0WyMTzqzANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA3MjgwMDAwMDBaFw0yOTAzMTgwMDAwMDBaMFQxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMSowKAYDVQQDEyFHbG9iYWxTaWduIEF0bGFz IFIzIFNNSU1FIENBIDIwMjAwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQCvLe9xPU9W dpiHLAvX7kFnaFZPuJLey7LYaMO8P/xSngB9IN73mVc7YiLov12Fekdtn5kL8PjmDBEvTYmWsuQS 6VBo3vdlqqXZ0M9eMkjcKqijrmDRleudEoPDzTumwQ18VB/3I+vbN039HIaRQ5x+NHGiPHVfk6Rx c6KAbYceyeqqfuJEcq23vhTdium/Bf5hHqYUhuJwnBQ+dAUcFndUKMJrth6lHeoifkbw2bv81zxJ I9cvIy516+oUekqiSFGfzAqByv41OrgLV4fLGCDH3yRh1tj7EtV3l2TngqtrDLUs5R+sWIItPa/4 AJXB1Q3nGNl2tNjVpcSn0uJ7aFPbAgMBAAGjggGKMIIBhjAOBgNVHQ8BAf8EBAMCAYYwHQYDVR0l BBYwFAYIKwYBBQUHAwIGCCsGAQUFBwMEMBIGA1UdEwEB/wQIMAYBAf8CAQAwHQYDVR0OBBYEFHzM CmjXouseLHIb0c1dlW+N+/JjMB8GA1UdIwQYMBaAFI/wS3+oLkUkrk1Q+mOai97i3Ru8MHsGCCsG AQUFBwEBBG8wbTAuBggrBgEFBQcwAYYiaHR0cDovL29jc3AyLmdsb2JhbHNpZ24uY29tL3Jvb3Ry MzA7BggrBgEFBQcwAoYvaHR0cDovL3NlY3VyZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvcm9vdC1y My5jcnQwNgYDVR0fBC8wLTAroCmgJ4YlaHR0cDovL2NybC5nbG9iYWxzaWduLmNvbS9yb290LXIz LmNybDBMBgNVHSAERTBDMEEGCSsGAQQBoDIBKDA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5n bG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzANBgkqhkiG9w0BAQsFAAOCAQEANyYcO+9JZYyqQt41 TMwvFWAw3vLoLOQIfIn48/yea/ekOcParTb0mbhsvVSZ6sGn+txYAZb33wIb1f4wK4xQ7+RUYBfI TuTPL7olF9hDpojC2F6Eu8nuEf1XD9qNI8zFd4kfjg4rb+AME0L81WaCL/WhP2kDCnRU4jm6TryB CHhZqtxkIvXGPGHjwJJazJBnX5NayIce4fGuUEJ7HkuCthVZ3Rws0UyHSAXesT/0tXATND4mNr1X El6adiSQy619ybVERnRi5aDe1PTwE+qNiotEEaeujz1a/+yYaaTY+k+qJcVxi7tbyQ0hi0UB3myM A/z2HmGEwO8hx7hDjKmKbDCCA18wggJHoAMCAQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUA MEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9vdCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWdu MRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEg MB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENBIC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzAR BgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4 Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0EXyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuu l9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+JJ5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJ pij2aTv2y8gokeWdimFXN6x0FNx04Druci8unPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh 6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTvriBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti +w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGjQjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8E BTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5NUPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEA S0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigHM8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9u bG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmUY/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaM ld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88 q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcya5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/f hO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/XzCCBNcwggO/oAMCAQICEAGVVZ3vJrb1Ifr2nE1K x08wDQYJKoZIhvcNAQELBQAwVDELMAkGA1UEBhMCQkUxGTAXBgNVBAoTEEdsb2JhbFNpZ24gbnYt c2ExKjAoBgNVBAMTIUdsb2JhbFNpZ24gQXRsYXMgUjMgU01JTUUgQ0EgMjAyMDAeFw0yMjAxMTYx MzA1NDBaFw0yMjA3MTUxMzA1NDBaMCUxIzAhBgkqhkiG9w0BCQEWFGRhbmlsY2hhcEBnb29nbGUu Y29tMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA2mJN44nt/MX1ajXGX6YfNorxJ//g xZGAbKllrzk7mk3QDo8L02k/AnxLii6cijbZ97ms2qKv+77kG7gbNhUfdQBj+PWdDe4Q83Os47e6 96GQrYu3gRaV6WobNP14bdTre5I2xZlKAtjJotKc86KdLKkfPspOB3Dpws9qYa9CLdN7CK3U6Njs /chca6URQjRr0QnPT77AvQQ9Bpj3FUzsKQVzZ2Pt4vXXgfK9A89debaucZCQef3XKiSBUiAh7e6W Uq3Ceqe7ofS5w/47v2l9K+1+JkiBA36eAhqqB6c9wEmk8wLVhDW1KdLukKo3b0hEGMWD5FZ3qTC+ ACFPXrqHQwIDAQABo4IB0jCCAc4wHwYDVR0RBBgwFoEUZGFuaWxjaGFwQGdvb2dsZS5jb20wDgYD VR0PAQH/BAQDAgWgMB0GA1UdJQQWMBQGCCsGAQUFBwMEBggrBgEFBQcDAjAdBgNVHQ4EFgQUj1mz DZzXirX+LnJ5h+pFPd+te4UwTAYDVR0gBEUwQzBBBgkrBgEEAaAyASgwNDAyBggrBgEFBQcCARYm aHR0cHM6Ly93d3cuZ2xvYmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADCBmgYIKwYB BQUHAQEEgY0wgYowPgYIKwYBBQUHMAGGMmh0dHA6Ly9vY3NwLmdsb2JhbHNpZ24uY29tL2NhL2dz YXRsYXNyM3NtaW1lY2EyMDIwMEgGCCsGAQUFBzAChjxodHRwOi8vc2VjdXJlLmdsb2JhbHNpZ24u Y29tL2NhY2VydC9nc2F0bGFzcjNzbWltZWNhMjAyMC5jcnQwHwYDVR0jBBgwFoAUfMwKaNei6x4s chvRzV2Vb4378mMwRgYDVR0fBD8wPTA7oDmgN4Y1aHR0cDovL2NybC5nbG9iYWxzaWduLmNvbS9j YS9nc2F0bGFzcjNzbWltZWNhMjAyMC5jcmwwDQYJKoZIhvcNAQELBQADggEBADRwU1tRwdP7W24n wsWFsBoDUYBGbJsr88hNGjfitt3nlekMHf2aKqFRL2yltYmenV5FiIKJm5sKNMU24W/MIFB+PQ59 uY97mcB1pTJFkMBTlo9g0lb08Ku+Z9oFn3EirDuCXEmp8BA2aGAkvvVgyOB5ZTrhkeiZ/5Zrnyoy djqSlqb6FT9Afm2HORb7L514CQ3xLqdGpShBc43zmvFlqareeAw/qTSDcWJGMt6mBmFmzIzQ2FON 4RM7vX2cj8fQVUdvslktqlZg/Cu6KMFB5pztzXZDsvXpY9dZrhXXvzlB0Jsqs7M11J9MYDuJ0AIc 1Uk04sEK22MEHxhvq2v7frwxggJqMIICZgIBATBoMFQxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBH bG9iYWxTaWduIG52LXNhMSowKAYDVQQDEyFHbG9iYWxTaWduIEF0bGFzIFIzIFNNSU1FIENBIDIw MjACEAGVVZ3vJrb1Ifr2nE1Kx08wDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIM1R mMRFioF0SMn5glJdy7pMiY/AgkI0JPxLLXOjMYD4MBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEw HAYJKoZIhvcNAQkFMQ8XDTIyMDMxNjEyMTMxOFowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQME ASowCwYJYIZIAWUDBAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJ KoZIhvcNAQEHMAsGCWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQDT95L45PvCmc77svu3G6uw c8cH6AYuYEuUzo3oyOxyW0mFoA2J8xao9MDJh/Hrsp2WbTIl8OvlyK7cdREQ1gEKLzx5IymxjEFq SE1VbWq5kvSkk4744itIvZlva6lSQf/RzvBK6LoWg8HnPLMghbtFdpcis8dfAkPTiLeys2n5GheK r1LvtugyMk2tutRDrlSSMLFn+WuDvP6eujiFipKJNSEe+c1wS0WgazwOCZDCuwqiUg5dxX///bYr r3TNutx8XXNbbt/cHNfemSAJXPvEjmVgd906YHiP9qUUI+tDrYHc58EEe8GVpbAJspDeORzADvb/ MOQiNClqsviYwA68 --000000000000c2680b05da54d632-- --===============0211714138826923829== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0211714138826923829==--