From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6396D428A3 for ; Tue, 5 Apr 2022 14:23:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1A7BC68B1E7; Tue, 5 Apr 2022 17:23:07 +0300 (EEST) Received: from mail-il1-f181.google.com (mail-il1-f181.google.com [209.85.166.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7A43D68A466 for ; Tue, 5 Apr 2022 17:23:00 +0300 (EEST) Received: by mail-il1-f181.google.com with SMTP id r11so9333825ila.1 for ; Tue, 05 Apr 2022 07:23:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=F9RqH+9XaHknnw+k5vhzetQr7oOnD1Qf4j+IS2V8yns=; b=Q89ridNBSmuBSbp67rd9MiYJfdSWYAULL6z2G6YRhE2sXZl0eWsXRxyYqPUGVBisEM 7nAR+/4IXrYDZzscdbaWWFmTFgx5oL+wg8wbAU5oifNNUzH1Ghn1RRgyX5mq5nkLCG/g leOc2aFAT8BWTcKEQ3g8v6Sah1SsO2UkQabuCsA+hiuri2Y/ynD24+MLob9eGQetPx31 bsmclG41q9ETiYD5xzzecea8La3YWmc8CODSYUXaZCpX0lvsL+LiBLjdxVykD2FTQWDP 56cKwGghfJvRx0yhGrjYp1MYk1p+3boJFDikVJRYWPjBluFp4oKzHiNWqG/cmqvkTJfV 2Abw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=F9RqH+9XaHknnw+k5vhzetQr7oOnD1Qf4j+IS2V8yns=; b=CGvk/FpGwNJCYz77xZIDtxwNTOnx3ZT4DPKHauGMuzFxNo7jlWkA+0vob9pDKfBp3L 1nTE5KC49Wq2q2n6TUej6VpbZs+ii0jjVeXQJ2gx+2/wsKggtzpSdVGurbPQe51MV0Tn yZCKIRZtxcJid0+APSG69qICkPSRMBXy+3dY5LQaGqAogUhiEEWyMWZJSD6Cd948/tqQ vJoWdVIh/A/h3Xz9PvTo26dEyIXUbExVsTQrYSeVNJJsBf2TNeR5zxAciahg6EGKbGih 642+uW/3U5EoB3ongUxrYnLmsnMwj8vRB/6ZZJaGYIO9Z0JLMfKM8auYjlzmRa/7ELC8 0v1g== X-Gm-Message-State: AOAM533LXac/FOJvBhiymQIHACqEW20auDqu4C6gvoSphVVmq8Ie015X Xr0AOoy4ZD189IeOdj/kEwlELZCEKW89fwz5Q4yKc0Q4QfQWYw== X-Google-Smtp-Source: ABdhPJzm/mPhWU9soXb8G9MY4uH2V5Ypsvy2gwaZcJV0eeDe3txu1aNwE7VIDlihAOMDdx2yytlCCc0gnkXPIPV+6Pw= X-Received: by 2002:a92:ca8e:0:b0:2c9:ca5b:f98d with SMTP id t14-20020a92ca8e000000b002c9ca5bf98dmr1868787ilo.182.1649168578525; Tue, 05 Apr 2022 07:22:58 -0700 (PDT) MIME-Version: 1.0 References: <164915298959.21047.64072881760748019@lain.red.khirnov.net> <20220405121539.1773869-1-danilchap@google.com> In-Reply-To: From: Danil Chapovalov Date: Tue, 5 Apr 2022 16:22:45 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: return quantizer parameter for an encoded frame X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3120991545931062759==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3120991545931062759== Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="00000000000054a9b205dbe8fb38" --00000000000054a9b205dbe8fb38 Content-Type: text/plain; charset="UTF-8" I've rechecked documentation for the "vpx_codec_control" - can't find any guarantee about the last parameter when the function fails, thus prefer to be on the safe side. On Tue, Apr 5, 2022 at 3:59 PM James Almer wrote: > > On 4/5/2022 9:15 AM, Danil Chapovalov wrote: > > --- > > libavcodec/libvpxenc.c | 9 ++++++++- > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > > index dff1d06b0e..0705863450 100644 > > --- a/libavcodec/libvpxenc.c > > +++ b/libavcodec/libvpxenc.c > > @@ -1250,6 +1250,8 @@ static int storeframe(AVCodecContext *avctx, struct FrameListData *cx_frame, > > int ret = ff_get_encode_buffer(avctx, pkt, cx_frame->sz, 0); > > uint8_t *side_data; > > int pict_type; > > + int quality; > > + VPxContext *ctx = avctx->priv_data; > > > > if (ret < 0) > > return ret; > > @@ -1264,7 +1266,12 @@ static int storeframe(AVCodecContext *avctx, struct FrameListData *cx_frame, > > pict_type = AV_PICTURE_TYPE_P; > > } > > > > - ff_side_data_set_encoder_stats(pkt, 0, cx_frame->sse + 1, > > + ret = vpx_codec_control(&ctx->encoder, VP8E_GET_LAST_QUANTIZER_64, &quality); > > + if (ret != VPX_CODEC_OK) { > > Is the last argument guaranteed to be untouched when the return value of > vpx_codec_control() is not VPX_CODEC_OK? If so, you can initialize > quality to 0 above, and remove this part. > > > + quality = 0; > > + } > > + > > + ff_side_data_set_encoder_stats(pkt, quality * FF_QP2LAMBDA, cx_frame->sse + 1, > > cx_frame->have_sse ? 3 : 0, pict_type); > > > > if (cx_frame->have_sse) { > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --00000000000054a9b205dbe8fb38 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIPngYJKoZIhvcNAQcCoIIPjzCCD4sCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg ggz4MIIEtjCCA56gAwIBAgIQeAMYYHb81ngUVR0WyMTzqzANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA3MjgwMDAwMDBaFw0yOTAzMTgwMDAwMDBaMFQxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMSowKAYDVQQDEyFHbG9iYWxTaWduIEF0bGFz IFIzIFNNSU1FIENBIDIwMjAwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQCvLe9xPU9W dpiHLAvX7kFnaFZPuJLey7LYaMO8P/xSngB9IN73mVc7YiLov12Fekdtn5kL8PjmDBEvTYmWsuQS 6VBo3vdlqqXZ0M9eMkjcKqijrmDRleudEoPDzTumwQ18VB/3I+vbN039HIaRQ5x+NHGiPHVfk6Rx c6KAbYceyeqqfuJEcq23vhTdium/Bf5hHqYUhuJwnBQ+dAUcFndUKMJrth6lHeoifkbw2bv81zxJ I9cvIy516+oUekqiSFGfzAqByv41OrgLV4fLGCDH3yRh1tj7EtV3l2TngqtrDLUs5R+sWIItPa/4 AJXB1Q3nGNl2tNjVpcSn0uJ7aFPbAgMBAAGjggGKMIIBhjAOBgNVHQ8BAf8EBAMCAYYwHQYDVR0l BBYwFAYIKwYBBQUHAwIGCCsGAQUFBwMEMBIGA1UdEwEB/wQIMAYBAf8CAQAwHQYDVR0OBBYEFHzM CmjXouseLHIb0c1dlW+N+/JjMB8GA1UdIwQYMBaAFI/wS3+oLkUkrk1Q+mOai97i3Ru8MHsGCCsG AQUFBwEBBG8wbTAuBggrBgEFBQcwAYYiaHR0cDovL29jc3AyLmdsb2JhbHNpZ24uY29tL3Jvb3Ry MzA7BggrBgEFBQcwAoYvaHR0cDovL3NlY3VyZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvcm9vdC1y My5jcnQwNgYDVR0fBC8wLTAroCmgJ4YlaHR0cDovL2NybC5nbG9iYWxzaWduLmNvbS9yb290LXIz LmNybDBMBgNVHSAERTBDMEEGCSsGAQQBoDIBKDA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5n bG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzANBgkqhkiG9w0BAQsFAAOCAQEANyYcO+9JZYyqQt41 TMwvFWAw3vLoLOQIfIn48/yea/ekOcParTb0mbhsvVSZ6sGn+txYAZb33wIb1f4wK4xQ7+RUYBfI TuTPL7olF9hDpojC2F6Eu8nuEf1XD9qNI8zFd4kfjg4rb+AME0L81WaCL/WhP2kDCnRU4jm6TryB CHhZqtxkIvXGPGHjwJJazJBnX5NayIce4fGuUEJ7HkuCthVZ3Rws0UyHSAXesT/0tXATND4mNr1X El6adiSQy619ybVERnRi5aDe1PTwE+qNiotEEaeujz1a/+yYaaTY+k+qJcVxi7tbyQ0hi0UB3myM A/z2HmGEwO8hx7hDjKmKbDCCA18wggJHoAMCAQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUA MEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9vdCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWdu MRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEg MB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENBIC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzAR BgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4 Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0EXyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuu l9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+JJ5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJ pij2aTv2y8gokeWdimFXN6x0FNx04Druci8unPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh 6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTvriBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti +w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGjQjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8E BTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5NUPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEA S0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigHM8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9u bG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmUY/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaM ld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88 q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcya5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/f hO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/XzCCBNcwggO/oAMCAQICEAGVVZ3vJrb1Ifr2nE1K x08wDQYJKoZIhvcNAQELBQAwVDELMAkGA1UEBhMCQkUxGTAXBgNVBAoTEEdsb2JhbFNpZ24gbnYt c2ExKjAoBgNVBAMTIUdsb2JhbFNpZ24gQXRsYXMgUjMgU01JTUUgQ0EgMjAyMDAeFw0yMjAxMTYx MzA1NDBaFw0yMjA3MTUxMzA1NDBaMCUxIzAhBgkqhkiG9w0BCQEWFGRhbmlsY2hhcEBnb29nbGUu Y29tMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA2mJN44nt/MX1ajXGX6YfNorxJ//g xZGAbKllrzk7mk3QDo8L02k/AnxLii6cijbZ97ms2qKv+77kG7gbNhUfdQBj+PWdDe4Q83Os47e6 96GQrYu3gRaV6WobNP14bdTre5I2xZlKAtjJotKc86KdLKkfPspOB3Dpws9qYa9CLdN7CK3U6Njs /chca6URQjRr0QnPT77AvQQ9Bpj3FUzsKQVzZ2Pt4vXXgfK9A89debaucZCQef3XKiSBUiAh7e6W Uq3Ceqe7ofS5w/47v2l9K+1+JkiBA36eAhqqB6c9wEmk8wLVhDW1KdLukKo3b0hEGMWD5FZ3qTC+ ACFPXrqHQwIDAQABo4IB0jCCAc4wHwYDVR0RBBgwFoEUZGFuaWxjaGFwQGdvb2dsZS5jb20wDgYD VR0PAQH/BAQDAgWgMB0GA1UdJQQWMBQGCCsGAQUFBwMEBggrBgEFBQcDAjAdBgNVHQ4EFgQUj1mz DZzXirX+LnJ5h+pFPd+te4UwTAYDVR0gBEUwQzBBBgkrBgEEAaAyASgwNDAyBggrBgEFBQcCARYm aHR0cHM6Ly93d3cuZ2xvYmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADCBmgYIKwYB BQUHAQEEgY0wgYowPgYIKwYBBQUHMAGGMmh0dHA6Ly9vY3NwLmdsb2JhbHNpZ24uY29tL2NhL2dz YXRsYXNyM3NtaW1lY2EyMDIwMEgGCCsGAQUFBzAChjxodHRwOi8vc2VjdXJlLmdsb2JhbHNpZ24u Y29tL2NhY2VydC9nc2F0bGFzcjNzbWltZWNhMjAyMC5jcnQwHwYDVR0jBBgwFoAUfMwKaNei6x4s chvRzV2Vb4378mMwRgYDVR0fBD8wPTA7oDmgN4Y1aHR0cDovL2NybC5nbG9iYWxzaWduLmNvbS9j YS9nc2F0bGFzcjNzbWltZWNhMjAyMC5jcmwwDQYJKoZIhvcNAQELBQADggEBADRwU1tRwdP7W24n wsWFsBoDUYBGbJsr88hNGjfitt3nlekMHf2aKqFRL2yltYmenV5FiIKJm5sKNMU24W/MIFB+PQ59 uY97mcB1pTJFkMBTlo9g0lb08Ku+Z9oFn3EirDuCXEmp8BA2aGAkvvVgyOB5ZTrhkeiZ/5Zrnyoy djqSlqb6FT9Afm2HORb7L514CQ3xLqdGpShBc43zmvFlqareeAw/qTSDcWJGMt6mBmFmzIzQ2FON 4RM7vX2cj8fQVUdvslktqlZg/Cu6KMFB5pztzXZDsvXpY9dZrhXXvzlB0Jsqs7M11J9MYDuJ0AIc 1Uk04sEK22MEHxhvq2v7frwxggJqMIICZgIBATBoMFQxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBH bG9iYWxTaWduIG52LXNhMSowKAYDVQQDEyFHbG9iYWxTaWduIEF0bGFzIFIzIFNNSU1FIENBIDIw MjACEAGVVZ3vJrb1Ifr2nE1Kx08wDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIL7M KiIJnjxEa3aPuTKe6Lmq7OMHnJ6ijq47XWG6SWKSMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEw HAYJKoZIhvcNAQkFMQ8XDTIyMDQwNTE0MjI1OVowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQME ASowCwYJYIZIAWUDBAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJ KoZIhvcNAQEHMAsGCWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQDL7LEmZrH8G8c3xX1hNdvX kD6T3qGTF8IVJ8FUNB4CzhAsb3MOaagJWOsVDOpBpxdaub1oIETxj+zdjdcMq9+PwMhJ5uLUKBIM aVxQYclEoSwrl/JbZ5uAEEW3d/nW/IowipEtSCekoyi0MyeiOHQTkyKosjVQNOokMspWrji7prcs VZ5ZRPPyp/6Gy15Ip8pCgSjsmRD8zto3LR667kdGML6ih2FFcei8Dd+Myf7anAfmaXsMcbSRgQFQ igCyooQgByq1qbyLiMwMFp7ti4cTvEXYeBr/OMYAoRKz/AT+p/pJOaZ2YsknnrM7CZyvgbxRHKHB 3lyL0/A/dcTdwjI8 --00000000000054a9b205dbe8fb38-- --===============3120991545931062759== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3120991545931062759==--