From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A9CE340639 for ; Mon, 28 Mar 2022 14:05:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CCD2068B1F9; Mon, 28 Mar 2022 17:05:08 +0300 (EEST) Received: from mail-il1-f182.google.com (mail-il1-f182.google.com [209.85.166.182]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 04B32689B39 for ; Mon, 28 Mar 2022 17:05:01 +0300 (EEST) Received: by mail-il1-f182.google.com with SMTP id y16so1964925ilc.7 for ; Mon, 28 Mar 2022 07:05:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CNYo8VBV68L/bBA58pqCB3wC1GGi6GQNt0bkxBuIiQ4=; b=nikeLZaowYWS+mWC6+fkHzeBofB3i0W6xCU1JVw+PSplppkbv14x0ne57bHTA3v0C7 nlJya3kRZTM8ECArZ4/+QXO1oXYsI7dlnHNX9mKHLrFQTwq/bvfqEVBpZEc4G3TmhIfT rBKi3R44EnCOaC5Bk527Sc31WlGCwj9jQMuZX1ZawXeKz0zUJ7sjAv7EU/t2GyLAUY5X i3Imz5mwAQp8GUczTvV8hDpDVDySk3yth7e78cxMKbk4IrCgoOyavyBOdODkI76iVdOr alwyQ4gKb4kH2huLrx2QY4hAgZBcwOPCjE4+LymTqLLbXl7+aZwxQt1YvxG5FPNPuviD F+RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CNYo8VBV68L/bBA58pqCB3wC1GGi6GQNt0bkxBuIiQ4=; b=EYMof4q5s1zylqSfQpRItljxlo+BgJ3li/XdG4oFXlzqqu5i26xoJeV+i6Pzr7T7md 4H3kAnG2ADRD6IjHVe22jR6GBJCQQ3hKINZCSKStgb20SG1OYGGMYC/MtW75UjdrplXw nga6qdkgGq4zectKf0hstltcB4IqMI2/AJW8kadj+J2YQzYcAnhFlZdSnJJ4rnyC45XP 8ZzfUPLK6EsJWlNXPGje1uYt2Pu2/SorbSJv08bRJSzsyxncu7Qt52BVitC1rXsOzrf+ taTO/DuCjr3TTJdAOVbxDrDlrK8hNHAxnkeq09pQvLRlPUCN7UscJcZGrMwpVBBRMV1O 8hkA== X-Gm-Message-State: AOAM532VBU3ZeOpzjU+FmSSyCPJEeAkruxvduJQb8WQMyJSVoWqyQiGv xWOifQsFgBt5znHp7eo34LX7txV5N+/fRcle9DaByw== X-Google-Smtp-Source: ABdhPJwTLleCcI2Cs3l+5nvVPxYuGngABMqS40HOibcLnRdFuqdaXVL/pIydf9u5A2HFJiXvYYZXLcMxx6C5J+6lEwY= X-Received: by 2002:a05:6e02:198c:b0:2c8:4e15:7cb9 with SMTP id g12-20020a056e02198c00b002c84e157cb9mr5696578ilf.24.1648476299998; Mon, 28 Mar 2022 07:04:59 -0700 (PDT) MIME-Version: 1.0 References: <20220316120759.2292546-1-danilchap@google.com> <20220324131116.825587-1-danilchap@google.com> In-Reply-To: From: Danil Chapovalov Date: Mon, 28 Mar 2022 16:04:47 +0200 Message-ID: To: James Zern Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: enable dynamic max quantizer parameter reconfiguration X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8515917550833816412==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8515917550833816412== Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000004e26c305db47cc96" --0000000000004e26c305db47cc96 Content-Type: text/plain; charset="UTF-8" On Thu, Mar 24, 2022 at 7:27 PM James Zern wrote: > > On Thu, Mar 24, 2022 at 6:12 AM Danil Chapovalov > wrote: > > > > --- > > libavcodec/libvpxenc.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > > index dff1d06b0e..463a658bb0 100644 > > --- a/libavcodec/libvpxenc.c > > +++ b/libavcodec/libvpxenc.c > > @@ -1625,6 +1625,12 @@ static int vpx_encode(AVCodecContext *avctx, AVPacket *pkt, > > vpx_svc_layer_id_t layer_id; > > int layer_id_valid = 0; > > > > + if (avctx->qmax >= 0 && enccfg->rc_max_quantizer != avctx->qmax) { > > + struct vpx_codec_enc_cfg cfg = *enccfg; > > + cfg.rc_max_quantizer = avctx->qmax; > > + vpx_codec_enc_config_set(&ctx->encoder, &cfg); > > + } > > + > > Jan, I think this was what you were suggesting, no? > The docs could be updated to note qmax can be changed per-frame > [1][2]. Saying that, it does seem a bit unbalanced to only do qmax > here. > > [1] https://ffmpeg.org/ffmpeg-codecs.html#libvpx > [2] https://git.ffmpeg.org/gitweb/ffmpeg.git/blob/HEAD:/doc/encoders.texi#l2000 As I understand, docs describe command line options. I do not plan to expose changing qmax per frame as a command line option, I do not see how that can be reasonably done. My intent is to change max qp when ffmpeg is used as a library. I agree it looks unbalanced to change just the qmax, but that is the only parameter I currently need for my usecase. Personally I prefer to only add features that are planned to be used. Are there any particular configuration settings you want me to make configurable, or do you think it is better to support all settings that can be configurable? --0000000000004e26c305db47cc96 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIPngYJKoZIhvcNAQcCoIIPjzCCD4sCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg ggz4MIIEtjCCA56gAwIBAgIQeAMYYHb81ngUVR0WyMTzqzANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA3MjgwMDAwMDBaFw0yOTAzMTgwMDAwMDBaMFQxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMSowKAYDVQQDEyFHbG9iYWxTaWduIEF0bGFz IFIzIFNNSU1FIENBIDIwMjAwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQCvLe9xPU9W dpiHLAvX7kFnaFZPuJLey7LYaMO8P/xSngB9IN73mVc7YiLov12Fekdtn5kL8PjmDBEvTYmWsuQS 6VBo3vdlqqXZ0M9eMkjcKqijrmDRleudEoPDzTumwQ18VB/3I+vbN039HIaRQ5x+NHGiPHVfk6Rx c6KAbYceyeqqfuJEcq23vhTdium/Bf5hHqYUhuJwnBQ+dAUcFndUKMJrth6lHeoifkbw2bv81zxJ I9cvIy516+oUekqiSFGfzAqByv41OrgLV4fLGCDH3yRh1tj7EtV3l2TngqtrDLUs5R+sWIItPa/4 AJXB1Q3nGNl2tNjVpcSn0uJ7aFPbAgMBAAGjggGKMIIBhjAOBgNVHQ8BAf8EBAMCAYYwHQYDVR0l BBYwFAYIKwYBBQUHAwIGCCsGAQUFBwMEMBIGA1UdEwEB/wQIMAYBAf8CAQAwHQYDVR0OBBYEFHzM CmjXouseLHIb0c1dlW+N+/JjMB8GA1UdIwQYMBaAFI/wS3+oLkUkrk1Q+mOai97i3Ru8MHsGCCsG AQUFBwEBBG8wbTAuBggrBgEFBQcwAYYiaHR0cDovL29jc3AyLmdsb2JhbHNpZ24uY29tL3Jvb3Ry MzA7BggrBgEFBQcwAoYvaHR0cDovL3NlY3VyZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvcm9vdC1y My5jcnQwNgYDVR0fBC8wLTAroCmgJ4YlaHR0cDovL2NybC5nbG9iYWxzaWduLmNvbS9yb290LXIz LmNybDBMBgNVHSAERTBDMEEGCSsGAQQBoDIBKDA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5n bG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzANBgkqhkiG9w0BAQsFAAOCAQEANyYcO+9JZYyqQt41 TMwvFWAw3vLoLOQIfIn48/yea/ekOcParTb0mbhsvVSZ6sGn+txYAZb33wIb1f4wK4xQ7+RUYBfI TuTPL7olF9hDpojC2F6Eu8nuEf1XD9qNI8zFd4kfjg4rb+AME0L81WaCL/WhP2kDCnRU4jm6TryB CHhZqtxkIvXGPGHjwJJazJBnX5NayIce4fGuUEJ7HkuCthVZ3Rws0UyHSAXesT/0tXATND4mNr1X El6adiSQy619ybVERnRi5aDe1PTwE+qNiotEEaeujz1a/+yYaaTY+k+qJcVxi7tbyQ0hi0UB3myM A/z2HmGEwO8hx7hDjKmKbDCCA18wggJHoAMCAQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUA MEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9vdCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWdu MRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEg MB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENBIC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzAR BgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4 Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0EXyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuu l9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+JJ5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJ pij2aTv2y8gokeWdimFXN6x0FNx04Druci8unPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh 6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTvriBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti +w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGjQjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8E BTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5NUPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEA S0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigHM8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9u bG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmUY/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaM ld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88 q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcya5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/f hO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/XzCCBNcwggO/oAMCAQICEAGVVZ3vJrb1Ifr2nE1K x08wDQYJKoZIhvcNAQELBQAwVDELMAkGA1UEBhMCQkUxGTAXBgNVBAoTEEdsb2JhbFNpZ24gbnYt c2ExKjAoBgNVBAMTIUdsb2JhbFNpZ24gQXRsYXMgUjMgU01JTUUgQ0EgMjAyMDAeFw0yMjAxMTYx MzA1NDBaFw0yMjA3MTUxMzA1NDBaMCUxIzAhBgkqhkiG9w0BCQEWFGRhbmlsY2hhcEBnb29nbGUu Y29tMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA2mJN44nt/MX1ajXGX6YfNorxJ//g xZGAbKllrzk7mk3QDo8L02k/AnxLii6cijbZ97ms2qKv+77kG7gbNhUfdQBj+PWdDe4Q83Os47e6 96GQrYu3gRaV6WobNP14bdTre5I2xZlKAtjJotKc86KdLKkfPspOB3Dpws9qYa9CLdN7CK3U6Njs /chca6URQjRr0QnPT77AvQQ9Bpj3FUzsKQVzZ2Pt4vXXgfK9A89debaucZCQef3XKiSBUiAh7e6W Uq3Ceqe7ofS5w/47v2l9K+1+JkiBA36eAhqqB6c9wEmk8wLVhDW1KdLukKo3b0hEGMWD5FZ3qTC+ ACFPXrqHQwIDAQABo4IB0jCCAc4wHwYDVR0RBBgwFoEUZGFuaWxjaGFwQGdvb2dsZS5jb20wDgYD VR0PAQH/BAQDAgWgMB0GA1UdJQQWMBQGCCsGAQUFBwMEBggrBgEFBQcDAjAdBgNVHQ4EFgQUj1mz DZzXirX+LnJ5h+pFPd+te4UwTAYDVR0gBEUwQzBBBgkrBgEEAaAyASgwNDAyBggrBgEFBQcCARYm aHR0cHM6Ly93d3cuZ2xvYmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADCBmgYIKwYB BQUHAQEEgY0wgYowPgYIKwYBBQUHMAGGMmh0dHA6Ly9vY3NwLmdsb2JhbHNpZ24uY29tL2NhL2dz YXRsYXNyM3NtaW1lY2EyMDIwMEgGCCsGAQUFBzAChjxodHRwOi8vc2VjdXJlLmdsb2JhbHNpZ24u Y29tL2NhY2VydC9nc2F0bGFzcjNzbWltZWNhMjAyMC5jcnQwHwYDVR0jBBgwFoAUfMwKaNei6x4s chvRzV2Vb4378mMwRgYDVR0fBD8wPTA7oDmgN4Y1aHR0cDovL2NybC5nbG9iYWxzaWduLmNvbS9j YS9nc2F0bGFzcjNzbWltZWNhMjAyMC5jcmwwDQYJKoZIhvcNAQELBQADggEBADRwU1tRwdP7W24n wsWFsBoDUYBGbJsr88hNGjfitt3nlekMHf2aKqFRL2yltYmenV5FiIKJm5sKNMU24W/MIFB+PQ59 uY97mcB1pTJFkMBTlo9g0lb08Ku+Z9oFn3EirDuCXEmp8BA2aGAkvvVgyOB5ZTrhkeiZ/5Zrnyoy djqSlqb6FT9Afm2HORb7L514CQ3xLqdGpShBc43zmvFlqareeAw/qTSDcWJGMt6mBmFmzIzQ2FON 4RM7vX2cj8fQVUdvslktqlZg/Cu6KMFB5pztzXZDsvXpY9dZrhXXvzlB0Jsqs7M11J9MYDuJ0AIc 1Uk04sEK22MEHxhvq2v7frwxggJqMIICZgIBATBoMFQxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBH bG9iYWxTaWduIG52LXNhMSowKAYDVQQDEyFHbG9iYWxTaWduIEF0bGFzIFIzIFNNSU1FIENBIDIw MjACEAGVVZ3vJrb1Ifr2nE1Kx08wDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIMQx t7pCTvAcaemKXoykhfG9TyzdhgV+wpj6rHy13wz1MBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEw HAYJKoZIhvcNAQkFMQ8XDTIyMDMyODE0MDUwMFowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQME ASowCwYJYIZIAWUDBAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJ KoZIhvcNAQEHMAsGCWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQBcKrmAOJ5Z6/ui2yrFvwmB LEezoBHQWyLJbvgMHyGHgKZ1cLEEfsDic9h+yd72n/Vo7eqDsnOBde+2ubis/5RoydmXLIJ7+fOq VsRq1W411byT3cI8Cg4CehDT23HXPBAZQahvA0Nu1gK8VVe7Xc2WtWOIcK3su9Tumg9ALnsxN+Js 0C5shVw4t/9jkyuH/TtecXhlH9dPSKEq5DaMhu1BcSDCA9a1HUQ9tDSriYyvPHolTGlff5nePVsw qifhUjWbaB+VjMtY1dM3XgNB/5fMKOGJZmgtvDeeQUM64lsuL7HRDub2Y/CJXZ6cdk17cKOfOp3x ozRx81QVENRdzsbW --0000000000004e26c305db47cc96-- --===============8515917550833816412== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8515917550833816412==--