From: Mattias Wadman <mattias.wadman@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] x86/tx_float: add support for calling assembly functions from assembly
Date: Tue, 6 Sep 2022 15:46:48 +0200
Message-ID: <CACHq7jfQ_PpSgL6Fs6gqfbwp5n3W13_UQc2OBsqdhTO9WCcmNw@mail.gmail.com> (raw)
In-Reply-To: <d182058-19b2-f02d-d648-f04a4d181e11@martin.st>
On Tue, Sep 6, 2022 at 3:45 PM Martin Storsjö <martin@martin.st> wrote:
> On Tue, 6 Sep 2022, Mattias Wadman wrote:
>
> > On Sat, Sep 3, 2022 at 3:41 AM Lynne <dev@lynne.ee> wrote:
> >
> >> Needed for the next patch.
> >> We get this for the extremely small cost of a branch on _ns functions,
> >> which wouldn't be used anyway with assembly.
> >>
> >> Patch attached.
> >>
> >
> > Hi, I have issues building on macOS (12.5.1) with this patch. Maybe I'm
> > missing something? old nasm version?
>
> That patch needed manually adding the symbol prefix in a few places, for
> platforms that do use symbol prefixes. See the patch that I just posted,
> which should fix this.
>
>
Great, thanks!
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-09-06 13:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-03 1:41 Lynne
[not found] ` <NB0-fO---3-2@lynne.ee-NB0-j8B----2>
2022-09-03 1:42 ` [FFmpeg-devel] [PATCH 2/2] x86/tx_float: implement inverse MDCT AVX2 assembly Lynne
2022-09-03 20:55 ` Michael Niedermayer
2022-09-03 21:35 ` Lynne
2022-09-06 13:21 ` [FFmpeg-devel] [PATCH 1/2] x86/tx_float: add support for calling assembly functions from assembly Mattias Wadman
2022-09-06 13:45 ` Martin Storsjö
2022-09-06 13:46 ` Mattias Wadman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACHq7jfQ_PpSgL6Fs6gqfbwp5n3W13_UQc2OBsqdhTO9WCcmNw@mail.gmail.com \
--to=mattias.wadman@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git