From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A8C2E43CFB for ; Wed, 7 Sep 2022 10:31:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D895068BB83; Wed, 7 Sep 2022 13:31:29 +0300 (EEST) Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2508568B743 for ; Wed, 7 Sep 2022 13:31:24 +0300 (EEST) Received: by mail-lf1-f52.google.com with SMTP id k10so7116986lfm.4 for ; Wed, 07 Sep 2022 03:31:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=LhpIslWq9ckq+mv20JHcdutCKy2sgs7q+BI7tTT4Bnc=; b=B429UxEL7cK9lN9rg3E+GTlQ/0bYp8P4kzrg2BLCASlKiMz97d2DOXfHeAerYVJNsm QHYwLvwHtKs98TVARFzloUHHH0ZjOhYvs9gc/SmOUJf75o+MOf7mIlK5PlHt3neQJ2Bl epLx55WOJiDJSSpTSRUY0+BNBIuFDUZy2FJpwMpHW3r+17A0Y/JQDFozPT9iU3aUvlCJ UlY0R9UO+yiOn5WsL2tJyQpGHa6jvKtxRE95hVFCd1u+4bm5fX5+phppYiC6T8Za93F+ RAw/5K9pYqod4SZtfOkjEBvO5n7PYshlNijFwWciaX0bSUPEIhe4/gScnUbgxn2HguXx JVfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=LhpIslWq9ckq+mv20JHcdutCKy2sgs7q+BI7tTT4Bnc=; b=a1j3qFuzLhtq3i7w66gVq0x6aHLsMZ5hc2ZNz0EZOq2HK4RK2nd253oiY+xerd2vGw NZNUG+2ctxkctebbr5M50xZbakUQML9RVFBBqX0LJ/8DelyOwTCIgE1oLLKGuJe6HtCK bxNzlWk738ffad7Ga+LMWhIwjT6W+wJcvZ5tBI2VATR9AU/j/8oO/PIM12x7wUByzV9Y WvLkanEvoPjmxWVJhMZFKmlsgNm1uI1+3C38hwK0lU+DnS0H6eMycpQ+5SaKb0/lXqPz Za7A94l2byHlD9UhmM2CSROfYQVj+YZOo6FFfkLAxsABIdMtUyF6WUCz36sBXDrbN0h/ HkJA== X-Gm-Message-State: ACgBeo06uR4lBrd/OCp/2mRPTgxEX5vtVZpK72pltfr+9YfjkHP8q/mU EWDbxLlRS/rk5lqXa2JAggi2XHNx/XbsnGxrX6ITUPjk0d4= X-Google-Smtp-Source: AA6agR5cqO+i+3pxjIHgy4zz9evHLbUSTF9Ctv9B9ux/CpaN9hbGzjN8mKiJRDlz7BMWdqyQ+bzYa5TNJJOvjdseuJM= X-Received: by 2002:a05:6512:1110:b0:494:73fe:f960 with SMTP id l16-20020a056512111000b0049473fef960mr1015229lfg.453.1662546682600; Wed, 07 Sep 2022 03:31:22 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Mattias Wadman Date: Wed, 7 Sep 2022 12:31:11 +0200 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avocdec/flac_parser: another fix X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, Sep 5, 2022 at 8:16 PM Paul B Mahol wrote: > Patch attached. > Thanks and can confirm that the patch produces the same samples as the flac reference decoder for the original file in https://trac.ffmpeg.org/ticket/9621 that I could not share. But I'm not sure I follow how the patch works. I read it as we skip checking CRC if the current frame or sample number is the expected next one? + if ((fpc->last_fi.frame_or_sample_num + 1 == header_fi->frame_or_sample_num) || + (fpc->last_fi.frame_or_sample_num + fpc->last_fi.blocksize == header_fi->frame_or_sample_num)) { Would it make sense to look at the blocking strategy bit to know which one to check? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".