From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 408D644366 for ; Tue, 6 Sep 2022 13:21:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8C5A068BB00; Tue, 6 Sep 2022 16:21:36 +0300 (EEST) Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B084D68B85A for ; Tue, 6 Sep 2022 16:21:29 +0300 (EEST) Received: by mail-lj1-f181.google.com with SMTP id by6so12242297ljb.11 for ; Tue, 06 Sep 2022 06:21:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=L9gPMOVp+kiJQhNdAuTvHXC/1SJ3YD2FhZqIxFF8jwI=; b=cR/6BmZplL+Vu84l6B+BkkKxzUfcMcXF6Lxe1iS7zSqsJBvoq0TGCCQXpUEZerHtBD mqaZvv+Oz45DnNz1qdCduRCINWeA76uR3hoqpyIO2VJQnIegYILXuY7IFxLJmYe9n6Sx 5lXklFV/gZcLE8dcUhU5fHlHEO9Qi0VpHfrXQT4Uj+C+i1ZRgi48CpQVgpaggLmVQi4U /me8c2Y2k27sb9Fcu4Nb5a8dHYXFkpITkxnHkK3H8HS8RHQoYLQpj8IamD6SuREZ0hBx 4Bx3MnUzI7qAzMzN7ZCrgviP58PYU+sNx2UuUg9bhq1nT2hYlS8f3BZtcE/lcEzjU3Rn aDpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=L9gPMOVp+kiJQhNdAuTvHXC/1SJ3YD2FhZqIxFF8jwI=; b=v2n/qcX9hm3EiqhYUK9DIMbFi4LJhVvnkgOGWXIxFRxL50tBNUWMdYofK1B6Hlp2ry yvEb//U99bEKF0iAITdOZRPoOPjmMiKTlR8HV0Rt4GR0aj0Hds6+GtfShb5A8R0zqUc5 Ybm7dV3yLQ/WLIDvlbkwSowFgmppQPdMQ908BsBRLFqGovmaT4T0ZYAQAtglaps4S4GB LKTosQWfrQPUfducriNK15CF9vpkBSKaUoog8RUbmpqz4BgrR7oXbBWs9RBHvgHM/RGg VizX9Ll8y20DZ1hSX8J2zYNn1gCE1MSNIKEfH8Gi3iML3RSyCadtZWhAPWHW7Jbpyjz6 oGDg== X-Gm-Message-State: ACgBeo03PsxDmjD5UVWEemiVBkAdkS6kpRIGCJfHgcg6GGWcN/hW5nVT t7DCAbA+HrW+qkqz4flKbVgzfsj164Zrh+xoyClH7afjcXs= X-Google-Smtp-Source: AA6agR5QHpOxo0nRtQxe7viDYsbfeEStBXFg0kgr0OzBf3Fm8p64cVQ834SNdqcBjqgSftaj6iRkUpeJ7wdXvYD/9ow= X-Received: by 2002:a05:651c:11cd:b0:268:bc0c:3d38 with SMTP id z13-20020a05651c11cd00b00268bc0c3d38mr7133692ljo.530.1662470488487; Tue, 06 Sep 2022 06:21:28 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Mattias Wadman Date: Tue, 6 Sep 2022 15:21:17 +0200 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 1/2] x86/tx_float: add support for calling assembly functions from assembly X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, Sep 3, 2022 at 3:41 AM Lynne wrote: > Needed for the next patch. > We get this for the extremely small cost of a branch on _ns functions, > which wouldn't be used anyway with assembly. > > Patch attached. > Hi, I have issues building on macOS (12.5.1) with this patch. Maybe I'm missing something? old nasm version? $ make V=1 nasm -f macho64 -DPIC -DPREFIX -I./ -I.// -Ilibavutil/x86/ -Pconfig.asm -MD libavutil/x86/tx_float.d -o libavutil/x86/tx_float.o libavutil/x86/tx_float.asm libavutil/x86/tx_float.asm:753: error: symbol `ff_tx_fft8_asm_float_sse3' not defined libavutil/x86/tx_float.asm:747: ... from macro `FFT8_SSE_FN' defined here libavutil/x86/x86util.asm:1180: ... from macro `call' defined here libavutil/x86/x86util.asm:1192: ... from macro `call_internal' defined here libavutil/x86/tx_float.asm:793: error: symbol `ff_tx_fft8_asm_float_avx' not defined libavutil/x86/tx_float.asm:787: ... from macro `FFT8_AVX_FN' defined here libavutil/x86/x86util.asm:1180: ... from macro `call' defined here libavutil/x86/x86util.asm:1192: ... from macro `call_internal' defined here libavutil/x86/tx_float.asm:842: error: symbol `ff_tx_fft16_asm_float_avx' not defined libavutil/x86/tx_float.asm:836: ... from macro `FFT16_FN' defined here libavutil/x86/x86util.asm:1180: ... from macro `call' defined here libavutil/x86/x86util.asm:1192: ... from macro `call_internal' defined here libavutil/x86/tx_float.asm:844: error: symbol `ff_tx_fft16_asm_float_fma3' not defined libavutil/x86/tx_float.asm:836: ... from macro `FFT16_FN' defined here libavutil/x86/x86util.asm:1180: ... from macro `call' defined here libavutil/x86/x86util.asm:1192: ... from macro `call_internal' defined here libavutil/x86/tx_float.asm:927: error: symbol `ff_tx_fft32_asm_float_avx' not defined libavutil/x86/tx_float.asm:920: ... from macro `FFT32_FN' defined here libavutil/x86/x86util.asm:1180: ... from macro `call' defined here libavutil/x86/x86util.asm:1192: ... from macro `call_internal' defined here libavutil/x86/tx_float.asm:929: error: symbol `ff_tx_fft32_asm_float_fma3' not defined libavutil/x86/tx_float.asm:920: ... from macro `FFT32_FN' defined here libavutil/x86/x86util.asm:1180: ... from macro `call' defined here libavutil/x86/x86util.asm:1192: ... from macro `call_internal' defined here libavutil/x86/tx_float.asm:1352: error: symbol `ff_tx_fft_sr_asm_float_fma3' not defined libavutil/x86/tx_float.asm:1345: ... from macro `FFT_SPLIT_RADIX_FN' defined here libavutil/x86/x86util.asm:1180: ... from macro `call' defined here libavutil/x86/x86util.asm:1192: ... from macro `call_internal' defined here libavutil/x86/tx_float.asm:1355: error: symbol `ff_tx_fft_sr_asm_float_avx2' not defined libavutil/x86/tx_float.asm:1345: ... from macro `FFT_SPLIT_RADIX_FN' defined here libavutil/x86/x86util.asm:1180: ... from macro `call' defined here libavutil/x86/x86util.asm:1192: ... from macro `call_internal' defined here $ nasm --version NASM version 2.15.05 compiled on Nov 14 2020 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".