From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0791F42690 for ; Wed, 25 May 2022 16:23:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9D98968B53F; Wed, 25 May 2022 19:23:56 +0300 (EEST) Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2BEF568B49E for ; Wed, 25 May 2022 19:23:50 +0300 (EEST) Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-2ef5380669cso220131317b3.9 for ; Wed, 25 May 2022 09:23:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Q6TEiwr2bBd8IEKvAFCY3Q7kp81mr1cJ1JlP5dcokXI=; b=KAtMdGTkAg9wNm6FxBTeHAPHuLVewkAeT80W0w+pwXCV5eqd81MJuSeaP3Vecp6WK3 WgHN9pJ8OLW0RX+WRg9DMC5vhqufLcK7E7aQlp6PnaOmr6cpk8qooujsXNtwP0ClXpYe xGyc7AqPDQ+3ay0EHZyiZ5AAv1XBy75lLQJ5IhSmlt1N1ueuy3tpQVZYhyx0CGG8q9mg UqUBldKqHPZyPEk4NrKlFBoDXUBPsuOnbtK4cB98t2tEJdDttd11avfUeZ8VE8lQgjLU IKtNjoe9jc3v1/wnJJGeTUwRScaV/y5h9xAKmsaz40nTak55cd+F682VIB08nKF+N1N3 eSWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Q6TEiwr2bBd8IEKvAFCY3Q7kp81mr1cJ1JlP5dcokXI=; b=k7YuW1Vb0xZLP9B/qtH6qfoJmlGL8q23AXDRHvQW25RRbKII0pKNg07aYy6cNUPQ88 DcIk6whRa4DM6qq+XueaWr3luGc9EACUxyGBW5peCaT3lCccNDrfOf63IIqy+DFYk+iZ l2rpBKRjVA3gk2SSqy1uOZoTCGq+NvZmuSTWYO63Z3b2yoJSRXJog830gQoDABtidoZP 9gPO25MhhP7xeYO/M3IZllRqZ3Fu8pfWnryuvHbCao5MO2NWAEs2tGA0duybhdk1S2Dd BgICaig6HaEyYXGtIgX3oz2hZbds0L2WHLkOiEceskJ8opfKn7Q8g3wT2E4/gM4j+Gnt D3aQ== X-Gm-Message-State: AOAM533yWwlot7+4PuyLqSYp4ylfFgjswkwVl3TY/2OWPBr0znNDbN3g tEFmezDw7FwCS4YTNpDGnFBTlU5NYWhywMvpFJMhUA== X-Google-Smtp-Source: ABdhPJzZfoILL+Zcmp2ZDZCAuT7N7QKoFbFFE3abWl8tXblZDhvi0RJqvbkX9s+QRW2BJYIivl2jGBFuGDMV8JyuTlc= X-Received: by 2002:a05:690c:804:b0:300:3294:cac8 with SMTP id bx4-20020a05690c080400b003003294cac8mr7796379ywb.349.1653495828570; Wed, 25 May 2022 09:23:48 -0700 (PDT) MIME-Version: 1.0 References: <20220419170324.3342219-1-bohanli@google.com> <20220419181850.3392814-1-bohanli@google.com> In-Reply-To: From: Bohan Li Date: Wed, 25 May 2022 09:23:12 -0700 Message-ID: To: James Zern X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/libaomenc: Add unmet target level warning X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Thanks for the reply, James! This is indeed not the intended behaviour, but it is due to libaom not initializing all the indices correctly. I've submitted a patch for review in libaom that fixes this, and after that patch the levels are only logged when a target level is given with this ffmpeg patch. Best, Bohan On Tue, May 24, 2022 at 5:43 PM James Zern wrote: > On Tue, May 17, 2022 at 12:45 PM James Zern wrote: > > > > On Tue, Apr 19, 2022 at 11:20 AM Bohan Li > > wrote: > > > > > > When target levels are set, this patch checks whether they are > > > satisfied by libaom. If not, a warning is shown. Otherwise the output > > > levels are also logged. > > > > > > This patch applies basically the same approach used for libvpx. > > > > > > Signed-off-by: Bohan Li > > > --- > > > libavcodec/libaomenc.c | 64 ++++++++++++++++++++++++++++++++++++++++++ > > > 1 file changed, 64 insertions(+) > > > > > > > lgtm. > > > + } else if (target_levels[i] < 31) { > > + // Log the encoded level if a target level was given > > + av_log(avctx, AV_LOG_INFO, > > + "Output level for operating point %d is > %d.%d.", > > + i, 2 + (levels[i] >> 2), levels[i] & 3); > > + } > > Actually this is a bit spammy. If there's only one operating point set > then I'd expect a single line output, but this seems to print all 32 > regardless. Is that expected? > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".