From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0B53B43B0E for ; Sat, 11 Mar 2023 16:18:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 28C6768BB04; Sat, 11 Mar 2023 18:18:48 +0200 (EET) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B9DA568B8C5 for ; Sat, 11 Mar 2023 18:18:41 +0200 (EET) Received: by mail-pl1-f176.google.com with SMTP id n6so8677424plf.5 for ; Sat, 11 Mar 2023 08:18:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678551520; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=QpcPITNmOwvLAVnKv2UqTEZOe88/4mSo0s1UZ6elTrk=; b=PnrdS1nLVLzq37cLTPtNYQAd6cWNA7ukfatehVM0sXrXgAdowepim2zuPhPwtGcxqN 8irZQISkcTv5ns4nTA6AIeuAQ4WXLlcswXZmj8bBQWyJPjSIpTmg40uR01ah9wwP8kAY 0RPGqqTFwrDgsMcO37tgY8eRKNon2w/KeQ8ZiRCetRvjs8BrkSrKHMAOPvICyzAdioI/ yaYtmRBSFqdgC7KuW8MugWH9JcXG1Jn479aRqqutKojTkLMoroi+88QEe/GoWN7F445n pP1yKiccdzrheUZlMP22fSnAE3R98cvd105cmBllGBlcGswcriReeiG+t19ugNbdAKbR 3aoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678551520; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QpcPITNmOwvLAVnKv2UqTEZOe88/4mSo0s1UZ6elTrk=; b=1XVGgoeVA6j0X5lAc6KCKCtjYp0swQU6gAjg1UDdEMpveNblr8ZxPm16u5CdfEz9Bh dTB/1E82JcS/lGqk5VoChM1S9u2uya7E6Lk6JbljsY9D6UIgTw3F3hNZDi56sTctOcfR UmICLNidHkVhTeK6Hi13TiqTLwBSo9w+nX0dri8tgDmM8HnwFuKQ7TUmBellzg9gfCu/ fTGz2AtwD1EUY8573ybkkJ0OsmJzZu4Ph47/cpLW8aPOYIWncRzs6G25Py58R1E06fem XIRooVLOfbvo5jOH/i3RUvpcByCu/gQNtu/pp6iyah2cPLoN/QOpULLvOo9Pmwg5EQ0P IDsw== X-Gm-Message-State: AO0yUKV1/mTT1mF0EbpQBsRjkNMdvUoLF7cARFTjSwLiLWyj0coeAryK pCWZe+G2HkrrxdBWYd5TPVQzW2W3PLQcZbPln7l5DDc+jsMckwJKiI8= X-Google-Smtp-Source: AK7set/u/LOlEvfBqXIvSeq84aWKqdSnOQjfa8rWlyJ9gTdnRGuOcJofnYlECCaJ1hFZZOysxFj8yesc98iSosLfTU4= X-Received: by 2002:a17:903:2c1:b0:199:1aba:b1d7 with SMTP id s1-20020a17090302c100b001991abab1d7mr11486195plk.5.1678551519720; Sat, 11 Mar 2023 08:18:39 -0800 (PST) MIME-Version: 1.0 References: <20230220195703.1297421-1-jdarnley@obe.tv> <20230220195703.1297421-2-jdarnley@obe.tv> In-Reply-To: <20230220195703.1297421-2-jdarnley@obe.tv> From: Thomas Mundt Date: Sat, 11 Mar 2023 17:18:28 +0100 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 2/3] checkasm: add test for bwdif X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi James, Am Mo., 20. Feb. 2023 um 20:59 Uhr schrieb James Darnley : > --- > tests/checkasm/Makefile | 1 + > tests/checkasm/checkasm.c | 3 ++ > tests/checkasm/checkasm.h | 1 + > tests/checkasm/vf_bwdif.c | 70 +++++++++++++++++++++++++++++++++++++++ > tests/fate/checkasm.mak | 1 + > 5 files changed, 76 insertions(+) > create mode 100644 tests/checkasm/vf_bwdif.c > > diff --git a/tests/checkasm/Makefile b/tests/checkasm/Makefile > index a6f06c7007..b6a43f181f 100644 > --- a/tests/checkasm/Makefile > +++ b/tests/checkasm/Makefile > @@ -40,6 +40,7 @@ CHECKASMOBJS-$(CONFIG_AVCODEC) += > $(AVCODECOBJS-yes) > # libavfilter tests > AVFILTEROBJS-$(CONFIG_AFIR_FILTER) += af_afir.o > AVFILTEROBJS-$(CONFIG_BLEND_FILTER) += vf_blend.o > +AVFILTEROBJS-$(CONFIG_BWDIF_FILTER) += vf_bwdif.o > AVFILTEROBJS-$(CONFIG_COLORSPACE_FILTER) += vf_colorspace.o > AVFILTEROBJS-$(CONFIG_EQ_FILTER) += vf_eq.o > AVFILTEROBJS-$(CONFIG_GBLUR_FILTER) += vf_gblur.o > diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c > index e96d84a7da..5e729cf0e0 100644 > --- a/tests/checkasm/checkasm.c > +++ b/tests/checkasm/checkasm.c > @@ -179,6 +179,9 @@ static const struct { > #if CONFIG_BLEND_FILTER > { "vf_blend", checkasm_check_blend }, > #endif > + #if CONFIG_BWDIF_FILTER > + { "vf_bwdif", checkasm_check_vf_bwdif }, > + #endif > #if CONFIG_COLORSPACE_FILTER > { "vf_colorspace", checkasm_check_colorspace }, > #endif > diff --git a/tests/checkasm/checkasm.h b/tests/checkasm/checkasm.h > index 8744a81218..e9e73c6fa0 100644 > --- a/tests/checkasm/checkasm.h > +++ b/tests/checkasm/checkasm.h > @@ -82,6 +82,7 @@ void checkasm_check_utvideodsp(void); > void checkasm_check_v210dec(void); > void checkasm_check_v210enc(void); > void checkasm_check_vc1dsp(void); > +void checkasm_check_vf_bwdif(void); > void checkasm_check_vf_eq(void); > void checkasm_check_vf_gblur(void); > void checkasm_check_vf_hflip(void); > diff --git a/tests/checkasm/vf_bwdif.c b/tests/checkasm/vf_bwdif.c > new file mode 100644 > index 0000000000..e27f9b7494 > --- /dev/null > +++ b/tests/checkasm/vf_bwdif.c > @@ -0,0 +1,70 @@ > +/* > + * This file is part of FFmpeg. > + * > + * FFmpeg is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * FFmpeg is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License along > + * with FFmpeg; if not, write to the Free Software Foundation, Inc., > + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > + */ > + > +#include > +#include "checkasm.h" > +#include "libavcodec/internal.h" > +#include "libavfilter/bwdif.h" > + > +#define WIDTH 256 > + > +#define randomize_buffers(buf0, buf1, mask, count) \ > + for (size_t i; i < count; i++) \ > + buf0[i] = buf1[i] = rnd() & mask > + > +void checkasm_check_vf_bwdif(void) > +{ > + BWDIFContext ctx_8, ctx_10, ctx_16; > + > + ff_bwdif_init_filter_line(&ctx_8, 8); > + ff_bwdif_init_filter_line(&ctx_10, 10); > + ff_bwdif_init_filter_line(&ctx_16, 16); > + > + if (check_func(ctx_8.filter_line, "bwdif8")) { > + uint8_t prev0[9*WIDTH], prev1[9*WIDTH]; > + uint8_t next0[9*WIDTH], next1[9*WIDTH]; > + uint8_t cur0[9*WIDTH], cur1[9*WIDTH]; > + uint8_t dst0[WIDTH], dst1[WIDTH]; > + > + declare_func(void, void *dst, void *prev, void *cur, void *next, > + int w, int prefs, int mrefs, int prefs2, int > mrefs2, > + int prefs3, int mrefs3, int prefs4, int mrefs4, > + int parity, int clip_max); > + > + randomize_buffers(prev0, prev1, 0xff, 9*WIDTH); > + randomize_buffers(next0, next1, 0xff, 9*WIDTH); > + randomize_buffers(cur0, cur1, 0xff, 9*WIDTH); > + > + call_ref(dst0, prev0 + 4*WIDTH, cur0 + 4*WIDTH, next0 + 4*WIDTH, > WIDTH, > + WIDTH, -WIDTH, 2*WIDTH, -2*WIDTH, 3*WIDTH, -3*WIDTH, > 4*WIDTH, -4*WIDTH, > + 0, 0xff); > + call_new(dst1, prev1 + 4*WIDTH, cur1 + 4*WIDTH, next1 + 4*WIDTH, > WIDTH, > + WIDTH, -WIDTH, 2*WIDTH, -2*WIDTH, 3*WIDTH, -3*WIDTH, > 4*WIDTH, -4*WIDTH, > + 0, 0xff); > + > + if (memcmp(dst0, dst1, WIDTH) > + || memcmp(prev0, prev1, sizeof prev0) > + || memcmp(next0, next1, sizeof next0) > + || memcmp(cur0, cur1, sizeof cur0)) > + fail(); > + bench_new(dst1, prev1 + 4*WIDTH, cur1 + 4*WIDTH, next1 + 4*WIDTH, > WIDTH, > + WIDTH, -WIDTH, 2*WIDTH, -2*WIDTH, 3*WIDTH, -3*WIDTH, > 4*WIDTH, -4*WIDTH, > + 0, 0xff); > + } > + report("bwdif8"); > +} > I'm not familiar with checkasm tests, but isn't this one limited to a bit depth of 8? > diff --git a/tests/fate/checkasm.mak b/tests/fate/checkasm.mak > index a4e95541f5..6a7d4a1226 100644 > --- a/tests/fate/checkasm.mak > +++ b/tests/fate/checkasm.mak > @@ -37,6 +37,7 @@ FATE_CHECKASM = fate-checkasm-aacpsdsp > \ > fate-checkasm-v210enc \ > fate-checkasm-vc1dsp \ > fate-checkasm-vf_blend \ > + fate-checkasm-vf_bwdif \ > fate-checkasm-vf_colorspace \ > fate-checkasm-vf_eq \ > fate-checkasm-vf_gblur \ > -- > 2.39.1 > Best Regards, Thomas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".