From: Thomas Mundt <tmundt75@gmail.com>
To: Devin Heitmueller <devin.heitmueller@ltnglobal.com>
Cc: Devin Heitmueller <dheitmueller@ltnglobal.com>,
FFmpeg development discussions and patches
<ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [RFC PATCH 4/5] tinterlace: Properly preserve CEA-708 closed captions
Date: Sun, 19 Mar 2023 17:50:01 +0100
Message-ID: <CAC5+Sy5o9pQLeQkVgJEtTX4c2df89rfa_Ygo-EE=R3drog__WA@mail.gmail.com> (raw)
In-Reply-To: <CAHGibzHsoKwFaGC5WCBDsSUgW_wBXKvbyQ+fnbW-bYdDErX8WA@mail.gmail.com>
Am So., 19. März 2023 um 00:22 Uhr schrieb Devin Heitmueller <
devin.heitmueller@ltnglobal.com>:
> On Sat, Mar 18, 2023 at 1:12 PM Thomas Mundt <tmundt75@gmail.com> wrote:
> > Not all modes of tinterlace halve the frame rate. mergex2 and pad keep
> it, interlacex2 even doubles it.
>
> Sorry, I should have been more clear with the patch description in
> that I realize that interlacing doesn't necessarily halve the
> framerate, depending on the mode. That said, I was pretty sure I got
> it working with all the code paths, but if you think I've missed one
> or more then please let me know. Or if you have an alternative patch
> which you think is cleaner for the tinterlace filter, I would be happy
> to review it.
>
>
I haven't worked with closed captions yet and also don't have the expertise
to test them reliably.
I just would like to roughly understand as maintainer of the tinterlace
filter how your patch works in order not to break the functionality in
future changes.
Looking through it, I wonder for example why av_ccfifo_inject is set for
the interleave modes and not for the drop modes.
Under which conditions must av_ccfifo_inject be set? Whenever a frame is
created at the output of the filter, or are there other conditions?
Regards,
Thomas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-03-19 16:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 20:09 [FFmpeg-devel] [RFC PATCH 0/5] Properly handle CEA-708 caption data when transcoding Devin Heitmueller
2023-03-17 20:09 ` [FFmpeg-devel] [RFC PATCH 1/5] ccfifo: Properly handle CEA-708 captions through framerate conversion Devin Heitmueller
2023-03-17 20:09 ` [FFmpeg-devel] [RFC PATCH 2/5] vf_fps: properly preserve CEA-708 captions Devin Heitmueller
2023-03-17 20:09 ` [FFmpeg-devel] [RFC PATCH 3/5] yadif: Properly preserve CEA-708 closed captions Devin Heitmueller
2023-03-18 15:48 ` Dennis Mungai
2023-03-18 23:20 ` Devin Heitmueller
2023-03-17 20:09 ` [FFmpeg-devel] [RFC PATCH 4/5] tinterlace: " Devin Heitmueller
2023-03-18 17:12 ` Thomas Mundt
2023-03-18 23:22 ` Devin Heitmueller
2023-03-19 16:50 ` Thomas Mundt [this message]
2023-03-19 17:33 ` Devin Heitmueller
2023-03-17 20:09 ` [FFmpeg-devel] [RFC PATCH 5/5] vf_ccrepack: Add new filter to repack CEA-708 side data Devin Heitmueller
2023-03-17 23:23 ` [FFmpeg-devel] [RFC PATCH 0/5] Properly handle CEA-708 caption data when transcoding BUCCIANTINI Francesco - ADECCO
2023-03-18 23:16 ` Devin Heitmueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAC5+Sy5o9pQLeQkVgJEtTX4c2df89rfa_Ygo-EE=R3drog__WA@mail.gmail.com' \
--to=tmundt75@gmail.com \
--cc=devin.heitmueller@ltnglobal.com \
--cc=dheitmueller@ltnglobal.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git