From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8AEB64833A for ; Tue, 28 Nov 2023 13:30:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7AB7C68CF6C; Tue, 28 Nov 2023 15:30:32 +0200 (EET) Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3CD3568CDCA for ; Tue, 28 Nov 2023 15:30:25 +0200 (EET) Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-5ab94fc098cso3228279a12.1 for ; Tue, 28 Nov 2023 05:30:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701178223; x=1701783023; darn=ffmpeg.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=3hiAW3RccP9Bynv0zHxiXY67rrWP2qeXV1L63A/yeBo=; b=JshCmUNpoPVDBF/nFLoYLstf7c/O/plc/aQyGQd9gMsBqsI9h/Jl0UzL5EkNqFA3d0 rZVdUR5YXgUX6ChjfvIXB4R+bitLMyyvPfXvkvh6WHDVqyD24jA+aYrCnonkr83d7DKC UaYojhAacWsFJSn1Tyx2m580uxAiWB/AqEDayB08EknE1/xlKiO0tvVHZbtxffiaRosM tV2cKCUfgbUXtHIxbNbYxY3bILLc4YZNSQqPcWdzZUl/BlLiZ8up+ZpYDAbLhUN4hA9n H6TXwK6/kSADqN1ci0jxv+pFgq7UdPA+Ut+nJUIVsmEGpGVPr9ZEeQkHcvnJqF7xG3Us 8Q1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701178223; x=1701783023; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3hiAW3RccP9Bynv0zHxiXY67rrWP2qeXV1L63A/yeBo=; b=vld+qUxXZIbURswwGV131SJ8tfL0tYzxi6VjW8847MG+bE6pN+kasuDAj8p18nT3ai QjsPgnc0E2XaCOYjXBcMTPwVztRe2DJ/N6y/jgArrcIvnZqQquXYbDo/YuqaRnWQCd2+ CfxlzhhOFxWEwSf3FMRljJmlAwqpJN/+ZbRvHYR1fTYSMfCieR1eAN4GLQw78bDGcQiX ik9fIy+9AegpKqews5kEkZCBSUda/otj644PDf/WsZ5nnUbfgNuiMPAhWUe5hZbeKR/7 JB2zagGnFjjTQQjlKIEIaWsC5l5MojV4T+Xfz97GTTp10AgSuyrPWGKBf4JRjAkBGsXE K+cA== X-Gm-Message-State: AOJu0YzWKsKkIq1PjiaOebravpN9h3yDzYC13jmsU7QHOn0JL0eVX3Xj Gyvju9wJvGfc0hrMJQYCL1fbUuRdx78NaPzQOOz1KVQulTE= X-Google-Smtp-Source: AGHT+IERYHou7LD4yC/jUNObQne17UUnPgjlz9MrzOHao7v6+ePWd3BxiXcbGlAlmG0Gj9qT197RuPFmjSkWW2T7CaY= X-Received: by 2002:a17:90b:3507:b0:285:ada4:e170 with SMTP id ls7-20020a17090b350700b00285ada4e170mr10038041pjb.16.1701178223014; Tue, 28 Nov 2023 05:30:23 -0800 (PST) MIME-Version: 1.0 References: <20231125203938.76291-1-cosmin@cosmin.at> <0101018c0835aafa-0a570ead-e0fc-4e1f-98c1-cf44ae96b7c3-000000@us-west-2.amazonses.com> In-Reply-To: <0101018c0835aafa-0a570ead-e0fc-4e1f-98c1-cf44ae96b7c3-000000@us-west-2.amazonses.com> From: Thomas Mundt Date: Tue, 28 Nov 2023 14:30:11 +0100 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vf_bwdif: consider chroma subsampling when enforcing minimum dimensions X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Cosmin Stejerean Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi Cosmin, Cosmin Stejerean via ffmpeg-devel schrieb am Sa., 25. Nov. 2023, 21:39: > Fixes #10688 > > Signed-off-by: Cosmin Stejerean > --- > libavfilter/vf_bwdif.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/libavfilter/vf_bwdif.c b/libavfilter/vf_bwdif.c > index 137cd5ef13..bce11c39f7 100644 > --- a/libavfilter/vf_bwdif.c > +++ b/libavfilter/vf_bwdif.c > @@ -197,6 +197,18 @@ static int config_props(AVFilterLink *link) > } > > yadif->csp = av_pix_fmt_desc_get(link->format); > + > + if (yadif->csp->nb_components > 1) { > + int w_chroma, h_chroma; > + h_chroma = AV_CEIL_RSHIFT(link->h, yadif->csp->log2_chroma_h); > + w_chroma = AV_CEIL_RSHIFT(link->w, yadif->csp->log2_chroma_w); > + > + if (w_chroma < 3 || h_chroma < 4) { > + av_log(ctx, AV_LOG_ERROR, "Video with planes less than 3 > columns or 4 lines is not supported\n"); > + return AVERROR(EINVAL); > + } > + } > + > Thanks for your quick patch. Could you please make the size check for all components and remove the old one to avoid having two size checks in a row? Regards, Thomas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".