From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2CE29460A2 for ; Mon, 3 Jul 2023 22:08:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4ABC868C5AF; Tue, 4 Jul 2023 01:08:15 +0300 (EEST) Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2B48E68C48A for ; Tue, 4 Jul 2023 01:08:09 +0300 (EEST) Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-262e3c597b9so3583492a91.0 for ; Mon, 03 Jul 2023 15:08:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688422087; x=1691014087; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=wP0tgp9gs+RbbLZ/b7XgS1kzacx3fvfPigJeUPkXIEI=; b=WCWu+IHxG5oXiFyvM1YNqLhyMti4sq0DAmBUlYy6UqLMivZhbyEz4XD9ZD9Lz0O5bE LlgEPUnBzylkQMClxkwxTos5eULgGN8gMNyp4j9vko3r/nv2CrOa986+dEgRtQAcykwe +I3qDJxqTJnjeeDjKP5O8P6WfOHe6CO5w5M4iohxP4E8S1YcLRZc2fcP+ZbMKDtnsAlj dyuHMTo2QoLlBycGbyWtmGWzG3ngH9aaXvH51C/Vzo8pEfCXEo1MDPP6TI6ke946nf96 WDIbrD3EhSGjIqEEmgj1A6xZDngiMUDqIypY1j4NVniclkzQKEcsPBrxg0gdYKjKxlxg FKiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688422087; x=1691014087; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wP0tgp9gs+RbbLZ/b7XgS1kzacx3fvfPigJeUPkXIEI=; b=B8mP26S5i6MAv/gr9oHcx+QNSN17G2V8C/E7WFmey7gKP4GvzqzMcLdc2pPQpACRT8 QxUN64OgLYVmK52zzYS84NN2JsxPA6dohlDnvAv5neXVM5mBWAFtoxRS+HqazEbkY6Xs +BJ4Xq53dtte8EVoml4q1+ZLsbSIZiXPj7uaXoT+PbyIuBCDbaOz4jqhgvoem+ajJYW3 n3Z3fONS2OnWKakgbdbBjASAi6nXPwaUjOYp8s+jEYUqpnASXTGD/TI3YAhkRK7vSKGn K0/X8Kriw0Z+C+MIAR0a9/Mx7gey0dGA8Q2E0D3dnZ+037DymTAHSLlPCU6f4mfLEcrY KOXw== X-Gm-Message-State: ABy/qLZBNMRoB+Dt6rbKzRavm2eGewPmesRjdIV/xThNBG40Xu/uyvFQ QOMSLzviwCIF2+Kf/+YefOq4ubgOw2GmsYnDlyN1IDvF0pk= X-Google-Smtp-Source: APBJJlGkGCywnt3BTKTf2weP1WBazXpFN1QdlgNLx3un8pghraZhPCAbMMFsfcuGOgM7+3LyLoICOdWfNcY5M5R8Usk= X-Received: by 2002:a17:90a:fd0d:b0:25e:a643:adeb with SMTP id cv13-20020a17090afd0d00b0025ea643adebmr11083676pjb.39.1688422086743; Mon, 03 Jul 2023 15:08:06 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Thomas Mundt Date: Tue, 4 Jul 2023 00:11:39 +0200 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] lavfi/bwdif: remove interpolated sample clipping X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Am So., 2. Juli 2023 um 20:58 Uhr schrieb Lynne : > Jul 2, 2023, 20:41 by tmundt75@gmail.com: > > > Am So., 2. Juli 2023 um 18:57 Uhr schrieb Lynne : > > > >> Jul 2, 2023, 18:54 by dev@lynne.ee: > >> > >> > The issue is that clipping the interpolated temporal sample against > >> > the spatially predicted sample causes artifacts to appear. > >> > > >> > Discovered while writing the Vulkan version (where I omitted the > >> > same check). > >> > > >> > The clipping in the code is carried over from yadif. Removing the > >> > same code in yadif does not make any difference to the output. > >> > I think that the check was simply ill-adapted to the new prediction > >> > code and does more harm. > >> > > >> > I tested replacing the range clip with only an FFMAX, and only an > >> > FFMIN, but in both cases, artifacts still appeared. > >> > > >> > Test sample 1: > >> https://files.lynne.ee/testsamples/mbaff_1080i60_idx.mkvTest sample 2: > >> https://files.lynne.ee/testsamples/mbaff_bdmv_1080i60_8slice.mkv > >> > > >> > Command line: > >> > ./ffmpeg_g -cpuflags 0 -i -vf bwdif=mode=send_field -c:v > >> rawvideo -y .nut > >> > Make sure to disable the assembly. > >> > > >> > Comparisons: > >> > https://files.lynne.ee/bwdif_01_before.png > >> > https://files.lynne.ee/bwdif_01_after.png > >> > Generated from sample 1 via: > >> > ffmpeg -ss 00:00:00.184 -i .nut -vf > >> crop=w=420:h=240:x=700:y=300,scale=iw*2:ih*2 -y .png > >> > > >> > https://files.lynne.ee/bwdif_02_before.png > >> > https://files.lynne.ee/bwdif_02_after.pngffmpeg -ss 00:00:00.417 -i > >> .nut -vf crop=w=420:h=240:x=1100:y=200,scale=iw*2:ih*2 -y > >> .png > >> > > >> > >> Corrected links for the second sample: > >> > >> https://files.lynne.ee/bwdif_02_before.png > >> https://files.lynne.ee/bwdif_02_after.png > >> ffmpeg -ss 00:00:00.417 -i .nut -vf > >> crop=w=420:h=240:x=1100:y=200,scale=iw*2:ih*2 -y .png > >> > >> I'm sure I hit a newline. The artifacts are a lot more noticeable in the > >> second sample. > >> > > > > I developed the bwdif to achieve the best possible balance between speed > > and quality of all different image contents from the broadcast point of > > view. This includes moving video as well as moving and static graphic > > elements. Unfortunately, the improvement of one image content often leads > > to the degradation of another. The code you removed fundamentally > > stabilizes the static graphic elements. This outweighs the slightly more > > frequent artifacts in moving video considering the general purpose of the > > filter. > > > > Could you post examples? I've been unable to find any that look worse > with the patch. > Unfortunately, I no longer have most of the test material that I used years ago at the development of the bwdif. But on the quick I have this clip with an "Archiv" insert. With your patch the letters are jumping. Without your patch they stay static. https://www.dropbox.com/s/jzoezjbi3ho9nja/bwdif-test.mov?dl=1 ffmpeg.exe -cpuflags 0 -i "bwdif-test.mov" -vf "bwdif=1:-1:1, scale=1920:1080" -sws_flags lanczos -aspect 16:9 -c:v libx264 -crf 21 "bwdif_original.mp4" ffmpeg_lynne_patch.exe -cpuflags 0 -i "bwdif-test.mov" -vf "bwdif=1:-1:1, scale=1920:1080" -sws_flags lanczos -aspect 16:9 -c:v libx264 -crf 21 "bwdif_lynne_patch.mp4" https://www.dropbox.com/s/tonsomtkhyaha91/bwdif_original.mp4?dl=1 https://www.dropbox.com/s/aaj8o5yzlocu55z/bwdif_lynne_patch.mp4?dl=1 Regards, Thomas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".