* [FFmpeg-devel] [PATCH] fftools/ffmpeg: Fix EOF pts for libavfilter in send_filter_eof()
@ 2022-09-11 20:44 Li-Heng Chen
2022-09-13 11:40 ` Paul B Mahol
0 siblings, 1 reply; 4+ messages in thread
From: Li-Heng Chen @ 2022-09-11 20:44 UTC (permalink / raw)
To: ffmpeg-devel
When input is video bitstream (e.g. *.264) with framerate set by -r, ist->pts could be a nonsense value.
In libavfilter/vf_fps, the pts value of EOF from above is compared to pts derived from inlink. The wrong EOF pts may trigger a bug, where ffmpeg keeps writting the last video frame to the output. This bug can be easily reproduced by the ffmpeg cmd below (h264 bitstreams in fate-suite can reproduce this issue):
ffmpeg -r num_in/den_in -i bitstream -vf fps=num_out/den_out -f rawvideo out.yuv
Example: ffmpeg -r 24/1 -i fate-suite/h264/bbc2.sample.h264 -vf fps=24/1 -f rawvideo out.yuv
Signed-off-by: Li-Heng Chen <lihengc@netflix.com>
---
fftools/ffmpeg.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index 0e1477299d..e9a986c95b 100644
--- a/fftools/ffmpeg.c
+++ b/fftools/ffmpeg.c
@@ -2383,6 +2383,9 @@ static int send_filter_eof(InputStream *ist)
int64_t pts = av_rescale_q_rnd(ist->pts, AV_TIME_BASE_Q, ist->st->time_base,
AV_ROUND_NEAR_INF | AV_ROUND_PASS_MINMAX);
+ if(ist->framerate.num)
+ pts = ist->cfr_next_pts;
+
for (i = 0; i < ist->nb_filters; i++) {
ret = ifilter_send_eof(ist->filters[i], pts);
if (ret < 0)
--
2.32.1 (Apple Git-133)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Fix EOF pts for libavfilter in send_filter_eof()
2022-09-11 20:44 [FFmpeg-devel] [PATCH] fftools/ffmpeg: Fix EOF pts for libavfilter in send_filter_eof() Li-Heng Chen
@ 2022-09-13 11:40 ` Paul B Mahol
2022-09-13 16:46 ` [FFmpeg-devel] [PATCH v2] " Li-Heng Chen
0 siblings, 1 reply; 4+ messages in thread
From: Paul B Mahol @ 2022-09-13 11:40 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On 9/11/22, Li-Heng Chen <lihengc@netflix.com> wrote:
> When input is video bitstream (e.g. *.264) with framerate set by -r,
> ist->pts could be a nonsense value.
>
> In libavfilter/vf_fps, the pts value of EOF from above is compared to pts
> derived from inlink. The wrong EOF pts may trigger a bug, where ffmpeg keeps
> writting the last video frame to the output. This bug can be easily
> reproduced by the ffmpeg cmd below (h264 bitstreams in fate-suite can
> reproduce this issue):
>
> ffmpeg -r num_in/den_in -i bitstream -vf fps=num_out/den_out -f rawvideo
> out.yuv
>
> Example: ffmpeg -r 24/1 -i fate-suite/h264/bbc2.sample.h264 -vf fps=24/1 -f
> rawvideo out.yuv
> Signed-off-by: Li-Heng Chen <lihengc@netflix.com>
> ---
> fftools/ffmpeg.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
> index 0e1477299d..e9a986c95b 100644
> --- a/fftools/ffmpeg.c
> +++ b/fftools/ffmpeg.c
> @@ -2383,6 +2383,9 @@ static int send_filter_eof(InputStream *ist)
> int64_t pts = av_rescale_q_rnd(ist->pts, AV_TIME_BASE_Q,
> ist->st->time_base,
> AV_ROUND_NEAR_INF |
> AV_ROUND_PASS_MINMAX);
>
> + if(ist->framerate.num)
> + pts = ist->cfr_next_pts;
> +
Style is wrong
> for (i = 0; i < ist->nb_filters; i++) {
> ret = ifilter_send_eof(ist->filters[i], pts);
> if (ret < 0)
> --
> 2.32.1 (Apple Git-133)
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [FFmpeg-devel] [PATCH v2] fftools/ffmpeg: Fix EOF pts for libavfilter in send_filter_eof()
2022-09-13 11:40 ` Paul B Mahol
@ 2022-09-13 16:46 ` Li-Heng Chen
2022-09-17 15:51 ` [FFmpeg-devel] [PATCH] " Li-Heng Chen
0 siblings, 1 reply; 4+ messages in thread
From: Li-Heng Chen @ 2022-09-13 16:46 UTC (permalink / raw)
To: FFmpeg development discussions and patches
[-- Attachment #1: Type: text/plain, Size: 2152 bytes --]
On Tue, Sep 13, 2022 at 4:40 AM Paul B Mahol <onemda@gmail.com> wrote:
>
> On 9/11/22, Li-Heng Chen <lihengc@netflix.com> wrote:
> > When input is video bitstream (e.g. *.264) with framerate set by -r,
> > ist->pts could be a nonsense value.
> >
> > In libavfilter/vf_fps, the pts value of EOF from above is compared to pts
> > derived from inlink. The wrong EOF pts may trigger a bug, where ffmpeg keeps
> > writting the last video frame to the output. This bug can be easily
> > reproduced by the ffmpeg cmd below (h264 bitstreams in fate-suite can
> > reproduce this issue):
> >
> > ffmpeg -r num_in/den_in -i bitstream -vf fps=num_out/den_out -f rawvideo
> > out.yuv
> >
> > Example: ffmpeg -r 24/1 -i fate-suite/h264/bbc2.sample.h264 -vf fps=24/1 -f
> > rawvideo out.yuv
> > Signed-off-by: Li-Heng Chen <lihengc@netflix.com>
> > ---
> > fftools/ffmpeg.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
> > index 0e1477299d..e9a986c95b 100644
> > --- a/fftools/ffmpeg.c
> > +++ b/fftools/ffmpeg.c
> > @@ -2383,6 +2383,9 @@ static int send_filter_eof(InputStream *ist)
> > int64_t pts = av_rescale_q_rnd(ist->pts, AV_TIME_BASE_Q,
> > ist->st->time_base,
> > AV_ROUND_NEAR_INF |
> > AV_ROUND_PASS_MINMAX);
> >
> > + if(ist->framerate.num)
> > + pts = ist->cfr_next_pts;
> > +
>
> Style is wrong
Style fixed in the attached patch
>
> > for (i = 0; i < ist->nb_filters; i++) {
> > ret = ifilter_send_eof(ist->filters[i], pts);
> > if (ret < 0)
> > --
> > 2.32.1 (Apple Git-133)
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> >
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
[-- Attachment #2: 0001-fftools-ffmpeg-Fix-EOF-pts-for-libavfilter-in-send_f.patch --]
[-- Type: application/x-patch, Size: 1518 bytes --]
[-- Attachment #3: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Fix EOF pts for libavfilter in send_filter_eof()
2022-09-13 16:46 ` [FFmpeg-devel] [PATCH v2] " Li-Heng Chen
@ 2022-09-17 15:51 ` Li-Heng Chen
0 siblings, 0 replies; 4+ messages in thread
From: Li-Heng Chen @ 2022-09-17 15:51 UTC (permalink / raw)
To: FFmpeg development discussions and patches
[-- Attachment #1: Type: text/plain, Size: 2392 bytes --]
Ping. Any comments on the updated patch?
On Tue, Sep 13, 2022 at 9:46 AM Li-Heng Chen <lihengc@netflix.com> wrote:
>
> On Tue, Sep 13, 2022 at 4:40 AM Paul B Mahol <onemda@gmail.com> wrote:
> >
> > On 9/11/22, Li-Heng Chen <lihengc@netflix.com> wrote:
> > > When input is video bitstream (e.g. *.264) with framerate set by -r,
> > > ist->pts could be a nonsense value.
> > >
> > > In libavfilter/vf_fps, the pts value of EOF from above is compared to pts
> > > derived from inlink. The wrong EOF pts may trigger a bug, where ffmpeg keeps
> > > writting the last video frame to the output. This bug can be easily
> > > reproduced by the ffmpeg cmd below (h264 bitstreams in fate-suite can
> > > reproduce this issue):
> > >
> > > ffmpeg -r num_in/den_in -i bitstream -vf fps=num_out/den_out -f rawvideo
> > > out.yuv
> > >
> > > Example: ffmpeg -r 24/1 -i fate-suite/h264/bbc2.sample.h264 -vf fps=24/1 -f
> > > rawvideo out.yuv
> > > Signed-off-by: Li-Heng Chen <lihengc@netflix.com>
> > > ---
> > > fftools/ffmpeg.c | 3 +++
> > > 1 file changed, 3 insertions(+)
> > >
> > > diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
> > > index 0e1477299d..e9a986c95b 100644
> > > --- a/fftools/ffmpeg.c
> > > +++ b/fftools/ffmpeg.c
> > > @@ -2383,6 +2383,9 @@ static int send_filter_eof(InputStream *ist)
> > > int64_t pts = av_rescale_q_rnd(ist->pts, AV_TIME_BASE_Q,
> > > ist->st->time_base,
> > > AV_ROUND_NEAR_INF |
> > > AV_ROUND_PASS_MINMAX);
> > >
> > > + if(ist->framerate.num)
> > > + pts = ist->cfr_next_pts;
> > > +
> >
> > Style is wrong
>
> Style fixed in the attached patch
>
> >
> > > for (i = 0; i < ist->nb_filters; i++) {
> > > ret = ifilter_send_eof(ist->filters[i], pts);
> > > if (ret < 0)
> > > --
> > > 2.32.1 (Apple Git-133)
> > >
> > > _______________________________________________
> > > ffmpeg-devel mailing list
> > > ffmpeg-devel@ffmpeg.org
> > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > >
> > > To unsubscribe, visit link above, or email
> > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> > >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
[-- Attachment #2: 0001-fftools-ffmpeg-Fix-EOF-pts-for-libavfilter-in-send_f.patch --]
[-- Type: application/octet-stream, Size: 1427 bytes --]
[-- Attachment #3: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-17 15:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-11 20:44 [FFmpeg-devel] [PATCH] fftools/ffmpeg: Fix EOF pts for libavfilter in send_filter_eof() Li-Heng Chen
2022-09-13 11:40 ` Paul B Mahol
2022-09-13 16:46 ` [FFmpeg-devel] [PATCH v2] " Li-Heng Chen
2022-09-17 15:51 ` [FFmpeg-devel] [PATCH] " Li-Heng Chen
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git