From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8A88144446 for ; Fri, 9 Sep 2022 18:52:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2B84F68BB02; Fri, 9 Sep 2022 21:52:26 +0300 (EEST) Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 167B368BAA3 for ; Fri, 9 Sep 2022 21:52:20 +0300 (EEST) Received: by mail-ed1-f46.google.com with SMTP id t5so3852078edc.11 for ; Fri, 09 Sep 2022 11:52:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netflix.com; s=google; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date; bh=L68tZRaQCofYeGojgYWgqkysQ0o714HdGVpZlxk1qiQ=; b=juNvtCeFdBAyvSPFEzUTETI/fxX0h1+j443LvTp4WF7Zg0j8yMQn/VJvv4KYmUkxBm xtJ1RPfwfFZUTUD0zH0c4S11W56lTJCLdQiqPqFcnRihvvO7/kxW7RGLezsdeMQp8KGs ysye95PX4yJOuywLwO44+cnTRBp+A/TkkNle4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date; bh=L68tZRaQCofYeGojgYWgqkysQ0o714HdGVpZlxk1qiQ=; b=DoiGyin/GJTMNtIPvZEsAzXOreDJCk3dLN50bEcHeoQlqRGSJk+WNRkWSXrNZxdkcj axrObQDvJF62bU2Biymezl8u0usLhDmx05XbNxwdraUhUmI4rrxa06etX7hKeVKhSWIY fBtwlZPIAVdxw4IlmI7f19x3VTLZCgi/H/PrM1mtpYmVvbDqpGGDK8oJ22CRu2fWjxvd oI93PRDsWapp2Ni3chd9Lb8hFrIUvyLPltKPIzHsktSqxVYGO4CxqHmJW9bbDBO2jWJ/ c8Ylp9Ga9gyMfRykgk0k27JopTk++7Cq4xqsI9VduOCszQ9Qtulip+2bPAf9OW/s8DGc nRmQ== X-Gm-Message-State: ACgBeo3JLJMyYqufgRUZ7QXqfmFTZaPvLRYYd5L/osr5oAGJdbrr+sUu Kjp6bGaY2c4cySkL9rXLJmg0ABiQrgHVcvsfUSrCXRmTTzzfNg== X-Google-Smtp-Source: AA6agR5vDlrlhNnSSGVfi6hBoRusKpCE7UJdl6XF3j073VhvvM1OdS9Oub6GZYw9me83WSK7j0iBgGIuOXsidkWOWJo= X-Received: by 2002:a05:6402:d6b:b0:44e:82bf:28e5 with SMTP id ec43-20020a0564020d6b00b0044e82bf28e5mr12241314edb.83.1662749539167; Fri, 09 Sep 2022 11:52:19 -0700 (PDT) MIME-Version: 1.0 From: Li-Heng Chen Date: Fri, 9 Sep 2022 11:52:08 -0700 Message-ID: To: ffmpeg-devel@ffmpeg.org Content-Type: multipart/mixed; boundary="000000000000a2a73405e8430b9a" Subject: [FFmpeg-devel] [PATCH] fftools/ffmpeg: fix EOF pts for libavfilter in send_filter_eof() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --000000000000a2a73405e8430b9a Content-Type: text/plain; charset="UTF-8" Hi, When input is video bitstream (e.g. *.264) with framerate set by -r, ist->pts could be a nonsense value. In libavfilter/vf_fps, the pts value of EOF from above is compared to pts derived from inlink. The wrong EOF pts may trigger a bug, where ffmpeg keeps writing the last video frame to the output. This bug can be easily reproduced by the ffmpeg cmd below (h264 bitstreams in fate-suite can reproduce this issue): ffmpeg -r num_in/den_in -i bitstream -vf fps=num_out/den_out -f rawvideo out.yuv Example: ffmpeg -r 24/1 -i fate-suite/h264/bbc2.sample.h264 -vf fps=24/1 -f rawvideo out.yuv Li-Heng Chen --000000000000a2a73405e8430b9a Content-Type: application/octet-stream; name="0001-fftools-ffmpeg-Fix-EOF-pts-for-libavfilter-in-send_f.patch" Content-Disposition: attachment; filename="0001-fftools-ffmpeg-Fix-EOF-pts-for-libavfilter-in-send_f.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l7uu37cm0 RnJvbSA5NTExZmI5YzE5MmY3Y2U2MTVlNmJmYmY0NmMzNzUyYmM0ODM2NjBkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMaS1IZW5nIENoZW4gPGxpaGVuZ2NAbmV0ZmxpeC5jb20+CkRh dGU6IEZyaSwgOSBTZXAgMjAyMiAxMDo1MzoyMCAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIGZmdG9v bHMvZmZtcGVnOiBGaXggRU9GIHB0cyBmb3IgbGliYXZmaWx0ZXIgaW4KIHNlbmRfZmlsdGVyX2Vv ZigpCgpXaGVuIGlucHV0IGlzIHZpZGVvIGJpdHN0cmVhbSAoZS5nLiAqLjI2NCkgd2l0aCBmcmFt ZXJhdGUgc2V0IGJ5IC1yLCBpc3QtPnB0cyBjb3VsZCBiZSBhIG5vbnNlbnNlIHZhbHVlLgoKSW4g bGliYXZmaWx0ZXIvdmZfZnBzLCB0aGUgcHRzIHZhbHVlIG9mIEVPRiBmcm9tIGFib3ZlIGlzIGNv bXBhcmVkIHRvIHB0cyBkZXJpdmVkIGZyb20gaW5saW5rLiBUaGUgd3JvbmcgRU9GIHB0cyBtYXkg dHJpZ2dlciBhIGJ1Zywgd2hlcmUgZmZtcGVnIGtlZXBzIHdyaXR0aW5nIHRoZSBsYXN0IHZpZGVv IGZyYW1lIHRvIHRoZSBvdXRwdXQuIFRoaXMgYnVnIGNhbiBiZSBlYXNpbHkgcmVwcm9kdWNlZCBi eSB0aGUgZmZtcGVnIGNtZCBiZWxvdyAoaDI2NCBiaXRzdHJlYW1zIGluIGZhdGUtc3VpdGUgY2Fu IHJlcHJvZHVjZSB0aGlzIGlzc3VlKToKCmZmbXBlZyAtciBudW1faW4vZGVuX2luIC1pIGJpdHN0 cmVhbSAtdmYgZnBzPW51bV9vdXQvZGVuX291dCAtZiByYXd2aWRlbyBvdXQueXV2CgpFeGFtcGxl OiBmZm1wZWcgLXIgMjQvMSAtaSBmYXRlLXN1aXRlL2gyNjQvYmJjMi5zYW1wbGUuaDI2NCAtdmYg ZnBzPTI0LzEgLWYgcmF3dmlkZW8gb3V0Lnl1dgotLS0KIGZmdG9vbHMvZmZtcGVnLmMgfCAzICsr KwogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2ZmdG9vbHMv ZmZtcGVnLmMgYi9mZnRvb2xzL2ZmbXBlZy5jCmluZGV4IDBlMTQ3NzI5OWQuLmU5YTk4NmM5NWIg MTAwNjQ0Ci0tLSBhL2ZmdG9vbHMvZmZtcGVnLmMKKysrIGIvZmZ0b29scy9mZm1wZWcuYwpAQCAt MjM4Myw2ICsyMzgzLDkgQEAgc3RhdGljIGludCBzZW5kX2ZpbHRlcl9lb2YoSW5wdXRTdHJlYW0g KmlzdCkKICAgICBpbnQ2NF90IHB0cyA9IGF2X3Jlc2NhbGVfcV9ybmQoaXN0LT5wdHMsIEFWX1RJ TUVfQkFTRV9RLCBpc3QtPnN0LT50aW1lX2Jhc2UsCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIEFWX1JPVU5EX05FQVJfSU5GIHwgQVZfUk9VTkRfUEFTU19NSU5NQVgpOwogCisg ICAgaWYoaXN0LT5mcmFtZXJhdGUubnVtKQorICAgICAgICBwdHMgPSBpc3QtPmNmcl9uZXh0X3B0 czsKKwogICAgIGZvciAoaSA9IDA7IGkgPCBpc3QtPm5iX2ZpbHRlcnM7IGkrKykgewogICAgICAg ICByZXQgPSBpZmlsdGVyX3NlbmRfZW9mKGlzdC0+ZmlsdGVyc1tpXSwgcHRzKTsKICAgICAgICAg aWYgKHJldCA8IDApCi0tIAoyLjMyLjEgKEFwcGxlIEdpdC0xMzMpCgo= --000000000000a2a73405e8430b9a Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --000000000000a2a73405e8430b9a--