From: Li-Heng Chen <lihengc@netflix.com>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH] fftools/ffmpeg: fix EOF pts for libavfilter in send_filter_eof()
Date: Fri, 9 Sep 2022 11:52:08 -0700
Message-ID: <CAC1ZW2i6RRy41Q23pmVDY8BVQqzXOFyP5JZLiJU6T4XMns5yFg@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 613 bytes --]
Hi,
When input is video bitstream (e.g. *.264) with framerate set by -r,
ist->pts could be a nonsense value.
In libavfilter/vf_fps, the pts value of EOF from above is compared to
pts derived from inlink. The wrong EOF pts may trigger a bug, where
ffmpeg keeps writing the last video frame to the output. This bug can
be easily reproduced by the ffmpeg cmd below (h264 bitstreams in
fate-suite can reproduce this issue):
ffmpeg -r num_in/den_in -i bitstream -vf fps=num_out/den_out -f rawvideo out.yuv
Example: ffmpeg -r 24/1 -i fate-suite/h264/bbc2.sample.h264 -vf
fps=24/1 -f rawvideo out.yuv
Li-Heng Chen
[-- Attachment #2: 0001-fftools-ffmpeg-Fix-EOF-pts-for-libavfilter-in-send_f.patch --]
[-- Type: application/octet-stream, Size: 1466 bytes --]
[-- Attachment #3: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2022-09-09 18:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 18:52 Li-Heng Chen [this message]
2022-09-11 20:44 [FFmpeg-devel] [PATCH] fftools/ffmpeg: Fix " Li-Heng Chen
2022-09-13 11:40 ` Paul B Mahol
2022-09-13 16:46 ` [FFmpeg-devel] [PATCH v2] " Li-Heng Chen
2022-09-17 15:51 ` [FFmpeg-devel] [PATCH] " Li-Heng Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAC1ZW2i6RRy41Q23pmVDY8BVQqzXOFyP5JZLiJU6T4XMns5yFg@mail.gmail.com \
--to=lihengc@netflix.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git