From: Rick Kern <kernrj@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: "zhilizhao(赵志立)" <quinkblack@foxmail.com>
Subject: Re: [FFmpeg-devel] 回复： [PATCH] avcodec/videotoolboxenc: add low-latency encoding
Date: Fri, 19 May 2023 09:36:38 -0400
Message-ID: <CABmg8gX5nPkc06vSMgZpNyEi9oKkdD2OwzN+gxDhRw=64g5O3w@mail.gmail.com> (raw)
In-Reply-To: <tencent_ABA33A3873364E5EC3F2BE505EF6468C1506@qq.com>
On Fri, May 19, 2023 at 1:56 AM 徐福隆 <839789740@qq.com> wrote:
> Thank you for your review, and point out the details.
> Actually, I have also considered this issue.
> I see that some keys are used directly, some are used by compatibility.
>
The compat_keys are used for symbols that might not exist. For constants
available in the earliest version of VideoToolbox, compat_keys doesn't need
to be used.
Your patch looks good - I'll push it shortly.
> I will use compat_key instead, and submit a new patch.
>
>
> ------------------ 原始邮件 ------------------
> 发件人:
> ""zhilizhao(赵志立)""
>
> <quinkblack@foxmail.com>;
> 发送时间: 2023年5月19日(星期五) 中午11:34
> 收件人: "FFmpeg development discussions and patches"<
> ffmpeg-devel@ffmpeg.org>;
> 抄送: "徐福隆"<839789740@qq.com>;
> 主题: Re: [FFmpeg-devel] [PATCH] avcodec/videotoolboxenc: add
> low-latency encoding
>
>
>
>
>
> > On May 19, 2023, at 11:17, xufuji456 <839789740@qq.com> wrote:
> >
> > When using low-latency mode, it eliminates frame reordering
> > and follows a one-in-one-out encoding mode
> >
> > Signed-off-by: xufuji456 <839789740@qq.com>
> > ---
> > libavcodec/videotoolboxenc.c | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/libavcodec/videotoolboxenc.c
> b/libavcodec/videotoolboxenc.c
> > index c6f22723d6..ae1ef32b2d 100644
> > --- a/libavcodec/videotoolboxenc.c
> > +++ b/libavcodec/videotoolboxenc.c
> > @@ -1441,6 +1441,17 @@ static int
> vtenc_create_encoder(AVCodecContext *avctx,
> > }
> > }
> >
> > + // low-latency mode: eliminate frame reordering,
> follow a one-in-one-out encoding mode
> > + if ((avctx->flags &
> AV_CODEC_FLAG_LOW_DELAY) && avctx->codec_id == AV_CODEC_ID_H264)
> {
> > + status =
> VTSessionSetProperty(vtctx->session,
> >
> +
> kVTVideoEncoderSpecification_EnableLowLatencyRateControl,
> >
> +
> kCFBooleanTrue);
>
> Please use compat_keys in case of
> kVTVideoEncoderSpecification_EnableLowLatencyRateControl
> isn’t available.
>
> > +
> > + if (status) {
> > +
> av_log(avctx, AV_LOG_ERROR, "Error setting low latency property: %d\n",
> status);
> > + }
> > + }
> > +
> > status =
> VTCompressionSessionPrepareToEncodeFrames(vtctx->session);
> > if (status) {
> > av_log(avctx,
> AV_LOG_ERROR, "Error: cannot prepare encoder: %d\n", status);
> > --
> > 2.32.0 (Apple Git-132)
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-05-19 13:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 3:17 [FFmpeg-devel] " xufuji456
2023-05-19 3:34 ` "zhilizhao(赵志立)"
2023-05-19 5:55 ` [FFmpeg-devel] =?gb18030?b?u9i4tKO6ICBbUEFUQ0hdIGF2Y29kZWMvdmlk?= =?gb18030?q?eotoolboxenc=3A_add_low-latency_encoding?= =?gb18030?B?0Oy4o8Kh?=
2023-05-19 13:36 ` Rick Kern [this message]
2023-05-19 18:05 ` [FFmpeg-devel] 回复： [PATCH] avcodec/videotoolboxenc: add low-latency encoding Zhao Zhili
2023-05-20 15:00 ` Rick Kern
2023-05-20 16:54 ` Zhao Zhili
-- strict thread matches above, loose matches on Subject: below --
2023-05-19 6:05 [FFmpeg-devel] " xufuji456
2023-05-18 10:15 xufuji456
2023-05-18 11:36 ` James Almer
2023-05-19 1:57 ` =?gb18030?B?0Oy4o8Kh?=
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABmg8gX5nPkc06vSMgZpNyEi9oKkdD2OwzN+gxDhRw=64g5O3w@mail.gmail.com' \
--to=kernrj@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=quinkblack@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git