From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 347434015E for ; Sun, 4 Dec 2022 15:01:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DA73868BA6B; Sun, 4 Dec 2022 17:01:03 +0200 (EET) Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 395F968B14E for ; Sun, 4 Dec 2022 17:00:57 +0200 (EET) Received: by mail-pj1-f52.google.com with SMTP id hd14-20020a17090b458e00b0021909875bccso9538957pjb.1 for ; Sun, 04 Dec 2022 07:00:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=Wso3yDnnLsIpFIoZJxaI8r0+YssfAJh/XrP7QDm4bBI=; b=T8R3/H4hxFKcsc4+514B313V9KtrMK27MWQWoHcPRZ75eoh4bkuOoBOB4dmKGq/iA0 RWnwbT3EtYrPzuKyD5ST5uaAGjuVzl2MUvQfwdrkXkDBd93Hxigvu0lpRwf3iZVan5lZ 3s1yAZybdjWQFLrgDduqAvQwsy4Uu7oqK7SgwznbcdfcKDvCpxNKz3iUeOVbBzzC/x0p +z55w+ZoZyLt5l2y1uVh9eBYn4WmqySoumvwYocaHWyjxbbnbLjnQM00gGY8gc1hOfr8 wdjSkU9hVtuO5ke8blFwt8JSuFNzDVHQwj9DWkTaBKAzq99TPUvDFjF67j+lyVmo0jLw pDPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Wso3yDnnLsIpFIoZJxaI8r0+YssfAJh/XrP7QDm4bBI=; b=g+DEzUvwr+EoR/zvLngOLIiurDWp9S0P81JP+LDR7/jsEpW6N+UOdP2lcKINMzX0yI z7jzJOR1iyyBW5DUuZJdhnmM/sc4BxDQTFIk0IEmKjhCiRQvudhY74An99GpM8Pzh3cf 2CuxaglPgoPAEH+3PtG7ujFNc97KA3p+OGBZu+Rj3/V9SkSta1aLjvzhxUUyI1VFgFRp y6k8UOFGY3Ozh+TcHutaBVyX+QRNIra54e4eEb0/F7NEekLOOmx3RVcloDtP7i9c1h6b 5M5NhQzRFOtbinmMcwlrnBTzfw4lyJ8RRlx+IAJhddkWmawg1M+pb8ziHJ5O+5Sh+hGS BTcQ== X-Gm-Message-State: ANoB5pkEi4jwG/xc/tYT0GdqPw+uwenVYxLv7SYFgYL/3QaXdomhIRzh Z/ozxV5TKcTm+CbSLXrVPBkENAU8m9L+baLFIVs/5FCj X-Google-Smtp-Source: AA0mqf61lCIZ5rTecXMNL58S4T59r8QzuT/pP/7WWhoDwl3cOogUz2FBcrqdSVdFpk+gYBW2tiW9BynMoraXLvsCtJ8= X-Received: by 2002:a17:902:a418:b0:187:edc:82f3 with SMTP id p24-20020a170902a41800b001870edc82f3mr61611696plq.161.1670166054641; Sun, 04 Dec 2022 07:00:54 -0800 (PST) MIME-Version: 1.0 References: <20221127173343.2577-1-alessandro.dinepi@gmail.com> <579ffa65-32b2-4f60-bbc3-4376e34fa892@Spark> In-Reply-To: <579ffa65-32b2-4f60-bbc3-4376e34fa892@Spark> From: Rick Kern Date: Sun, 4 Dec 2022 10:00:43 -0500 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] lavc/videotoolbox: validate vt context in the decoder callback X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, Nov 29, 2022 at 11:47 AM Alessandro Di Nepi < alessandro.dinepi@gmail.com> wrote: > Just to add that this fix, once approved, should be cherry-picked to all > the release branches where d7f4ad88a0df3c1339e142957bf2c40cd056b8ce has > been cherry-picked. > Basically, 4.4, 5.0, and 5.1. > > Thanks > On 27 Nov 2022, 19:34 +0200, Alessandro Di Nepi < > alessandro.dinepi@gmail.com>, wrote: > > The commit d7f4ad88a0df3c1339e142957bf2c40cd056b8ce introduced a race > > condition where the passed opaque pointer reference might be NULL, > > when the decoding process starts. > > This patch checks that vtctx has a value before accessing it. > > > > This patch fixes #10079. > > > > Signed-off-by: Alessandro Di Nepi > > --- > > libavcodec/videotoolbox.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c > > index 1b1be8ddb4..615e2b087a 100644 > > --- a/libavcodec/videotoolbox.c > > +++ b/libavcodec/videotoolbox.c > > @@ -692,6 +692,11 @@ static void videotoolbox_decoder_callback(void > *opaque, > > { > > VTContext *vtctx = opaque; > > > > + if (!vtctx) { > When this happens, does it continue happening, or is it transient? My main concern is log spamming. > > + av_log(NULL, AV_LOG_WARNING, "vt decoder cb: vt context is null"); > > + return; > > + } > > + > > if (vtctx->frame) { > > CVPixelBufferRelease(vtctx->frame); > > vtctx->frame = NULL; > > -- > > 2.37.1 (Apple Git-137.1) > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".