From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 8381F4C034 for ; Tue, 6 Jan 2026 02:11:14 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'bC50+oFMB2LwEBQ9GJR1bulr+kUubpl4QXIwUQjgw24=', expected b'LYzlmkPl+Sa3crHtWbpntTu1Lg7nshXANutLq2ifxVg=')) header.d=gmail.com header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1767665422; h=mime-version : date : message-id : to : content-type : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : from; bh=DuRnWwKR51abdKqi8khumB7mfZDFgXyvnw3aHjCS0UY=; b=NiPmBix16QIMJvp7dMgRD7Z6yuvtkey3zB+ntAaMeVJykRHcU6QLgRIodFW00uZLisb/R SmMgNcJWqp7uZEg1iV4FeBNSECszu1G0L1Cxjb/3LKsJYzkb9IunXUzAM81tKLutI29wekY R05pmnJ69/ke+tJa5NtLjuEcDV/DyzcOrNugpoR34XNjfIUBHcLJ4mmhmWdMeHOegkMKGvI MkNfdoMZaUCAZSEoyQ3GV4bCMdwksQnvF1Iogr5zH1SGxsZhDXiVncD1ZPc5/mbJpFHW3Xe cgr5Qk8wlxHnH3PsQM1zBe30Grds/v2P0OogteGi2Y6yNWT5T4NS+V2p3sqg== Received: from [172.20.0.4] (unknown [172.20.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 28656690E66; Tue, 6 Jan 2026 04:10:22 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1767665398; b=XvszhJkk/7cwDLxgw4QUHc/9ej69FaZ0PwonMlQBhNbXRk1EF9s+CT0dljz9vFOApJHDC 0GNHYgjGSCDriNLiv6puRG5FrJPBbYnZmAY+tJgavU9mGNO6NLlWfhVcu+/DEwvOF1zfnKU iTFxkCOFNPf5eKeMGNecoAIuimmRFCR1nrR49Us+ooPF5XzpxS5EaEpEbTq8QlBQMgh3ZR9 DoecUicOmHcIc/Ud5nDr8aMFqk5fYmTjDB1rEwGP92+AFhdUnGqwEHJ0B2ZkiX7lo18ctiL KMdjZH34xgTzH70ST+U8zTkVaVdukRc9TojNgIy0JMrO9UTrMRs9gFoSr9Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1767665398; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=mxYT1/KokOEPuV6zgmr11dmqhI/poHiKRUqIBZ3t+h8=; b=PeBGHzEeIvZxKdVu0fIksHKNPxI9fNfbA9D2618Ckp5K1SXQr2NGhSJPnhE+UqKU3o6Z0 lNVf81lNo1UPe71aHVGhWS0vKRFjr7WlIJ0RtIJSM3dgvyTa/iL8raKOafBWBK626PQeAzD Ar5enuTd9DHg7Rem8+gZyGagZkOpJ6NP8184I5YP4FsOB/KwJi1xlOw3kXezCYz8Z/2aqNx o6U/KYy6T8UNWHLjjPkzUGqwRv6YiW6YX9/YTdxZV8IE/1AjEaywHH1v1tPY9AeRq0PoQnw XYmkrokv7i5n6djddD/BX5hOLvJ3a7Uqqst9oInn+eRsTFwC4vVrREEfxZ8Q== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=fail header.d=gmail.com; arc=none; dmarc=fail header.from=gmail.com policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=fail header.d=gmail.com; arc=none (Message is not ARC signed); dmarc=fail (Used From Domain Record) header.from=gmail.com policy.dmarc=quarantine Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id ABB7568FEE0 for ; Sat, 3 Jan 2026 20:28:51 +0200 (EET) Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-786a822e73aso115410527b3.3 for ; Sat, 03 Jan 2026 10:28:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767464930; x=1768069730; darn=ffmpeg.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=LYzlmkPl+Sa3crHtWbpntTu1Lg7nshXANutLq2ifxVg=; b=A1iOh7J6/WzySyAmJfXBcT6Vipi1ieTlQrpGDzXwsHPQNGunC5XjR2HLop3NU2fUrw 6Sw1eIPNy6LWSJm9+JBRwmoebPCOKvB7EeQRf2N7OEGA0PJy8rNRsNMeXefcy8FCAeMt zlUaY3oCgIun8LnTGuiw6X+ctbP+29jIFs4Xu3uQclaGBL+bnAMKtDywGMSoPy+UmJ+x UK02LLrO3L17ywzW7YvMlxYsaF278ZhvXxWwuPMl9gva5M3IPcTX6j/JCJvhITvFsmxb oUzfjQHkrjRK2zuA/LUHFJREDSn6qgykGaH72CByDBcWlYUMG8q39Ki5DRBjQkivceXG TK3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767464930; x=1768069730; h=to:subject:message-id:date:from:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LYzlmkPl+Sa3crHtWbpntTu1Lg7nshXANutLq2ifxVg=; b=ixHegPhvf2oJwvp/QyFbB48pvi1RvuitJKiG2TyZ6l7ZPsVDA/CZwTKtaFIoV+nBEX EKuk2jtOlN9VDIVOhFkL23mfv+tsdmBmcy+6/RiwrGqcRXALVROvF2+JTLD0SnJrpyox HCxR/aVnhBqU/RC6USIMMHeqiOe7cqEpoGILmQnOiUSCeLnuhIpgOCN0oqJIeVNYg5U1 8gE9R1bzec8goo7PM8pf3bo/8uSau49kPn1RPu/XC7zKzA3pCu0oUoWNJTyOeBgpDE2k s09MNpbQu8BZzuLpySNGGfNEAaD2XA8gKEJURSfigx9K+cUdO6HCuZkFlk57bgtDqeaL jD9g== X-Gm-Message-State: AOJu0YysSguEUN+oYV7Tp1/Dtx18hZZQnXoIeK9jcr6Dh5VsJ2eiuTwH swItXaf/OaAL7pn7KOh/Isrvjds4sDUP1yP4u3E8lYc5jybPQva4YtxvLXoZ7/zE3a0G/ysgofg ER/5uLrUvKLx5WB1xhufWWaoMQbcbfJsYE8Rw X-Gm-Gg: AY/fxX5WDGFuCDu3r+t6652j9JGUoKBYuZO2w6gkRlXIMTWyXeGoBTM4UJkhGGGg/xT /+NEqcoGlKW/Ny7H8c6uGMKFwFf/cToF9NIs8umFr+v3cLAp/FQTKYgktw7zgnme4fGAvudAo/t Rgze6FmBvUqworBIpoVNUVVHtpvxEMkJEzEcyXWiOgGnAcgvVvhCd8aY6X0Sus8TM+eCmTANtgS 0S9NBSm75zHAgzJnY1iq7PmHU9x4GiOb/tAvGzH4S6Pfyuy0AG23vMIkmvAdbgROfldvtAWwCqu T+dPUgLcxTSYm0u86/k1tc9/FrWv X-Google-Smtp-Source: AGHT+IHMBdmMp21UMBg4+p2rDPVXtfa8i2MRjZHc1QC397dTnr75PZXh97N/bnm3lsRnMj1PmVM6RzyCcuHifKiCpBI= X-Received: by 2002:a05:690c:6011:b0:786:5c6f:d242 with SMTP id 00721157ae682-78fb40b11bbmr350117787b3.69.1767464930189; Sat, 03 Jan 2026 10:28:50 -0800 (PST) MIME-Version: 1.0 Date: Sat, 3 Jan 2026 19:28:39 +0100 X-Gm-Features: AQt7F2puyNcHmvrnrC2iLZ6HZJ9RQc3A3jWgGd0zvsbZJIYisINApQOu3_3ExQk Message-ID: To: ffmpeg-devel@ffmpeg.org Content-Type: multipart/mixed; boundary="0000000000005188cd06477fffc3" X-MailFrom: SRS0=/TDB=7I=gmail.com=monsterbat02@ffmpeg.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation Message-ID-Hash: H6UHJQ5X3LMO3AIS4EFEY7XZGWTTI2BM X-Message-ID-Hash: H6UHJQ5X3LMO3AIS4EFEY7XZGWTTI2BM X-Mailman-Approved-At: Tue, 06 Jan 2026 02:09:10 +0000 X-Content-Filtered-By: Mailman/MimeDel 3.3.10 X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] avcodec & compat: fix OOB access, integer overflows and DLL hijacking List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Baptiste Bd via ffmpeg-devel Cc: Baptiste Bd Archived-At: List-Archive: List-Post: --0000000000005188cd06477fffc3 Content-Type: text/plain; charset="UTF-8" >>From 57c3d02f6de69268f181436ddbb24b7bbda0c81f Mon Sep 17 00:00:00 2001 From: OxBat Date: Sat, 3 Jan 2026 19:23:44 +0100 Subject: [PATCH] avcodec & compat: fix OOB access, integer overflows and DLL hijacking --- compat/android/binder.c | 6 +++++- libavcodec/dxv.c | 2 +- libavcodec/eatqi.c | 6 ++++++ libavcodec/qdm2.c | 4 ++++ 4 files changed, 16 insertions(+), 2 deletions(-) diff --git a/compat/android/binder.c b/compat/android/binder.c index a214d977cc..1efcf155a1 100644 --- a/compat/android/binder.c +++ b/compat/android/binder.c @@ -41,7 +41,11 @@ static void *dlopen_libbinder_ndk(void) * See also: https://source.android.com/docs/core/architecture/aidl/aidl-backends */ - void *h = dlopen("libbinder_ndk.so", RTLD_NOW | RTLD_LOCAL); + /* PATCH SECURITY DLL Hijacking*/ + void *h = dlopen("/system/lib64/libbinder_ndk.so", RTLD_NOW | RTLD_LOCAL); + if (!h) { + h = dlopen("/system/lib/libbinder_ndk.so", RTLD_NOW | RTLD_LOCAL); + } if (h != NULL) return h; diff --git a/libavcodec/dxv.c b/libavcodec/dxv.c index 07eee253e7..daa233f969 100644 --- a/libavcodec/dxv.c +++ b/libavcodec/dxv.c @@ -73,7 +73,7 @@ typedef struct DXVContext { break; \ case 2: \ idx = (bytestream2_get_byte(gbc) + 2) * x; \ - if (idx > pos) { \ + if (idx > pos || idx > ctx->tex_size) return AVERROR_INVALIDDATA; /* PATCH Index Underflow*/ \ av_log(avctx, AV_LOG_ERROR, "idx %d > %d\n", idx, pos); \ return AVERROR_INVALIDDATA; \ } \ diff --git a/libavcodec/eatqi.c b/libavcodec/eatqi.c index 421ed51009..43425ef619 100644 --- a/libavcodec/eatqi.c +++ b/libavcodec/eatqi.c @@ -111,6 +111,12 @@ static inline void tqi_idct_put(AVCodecContext *avctx, AVFrame *frame, static void tqi_calculate_qtable(TqiContext *t, int quant) { + /* PATCH: Prevent underflow */ + if (quant > 107) { + av_log(t->avctx, AV_LOG_ERROR, "Invalid quantizer value: %d, clamping to 107\n", quant); + quant = 107; + } + const int64_t qscale = (215 - 2*quant)*5; int i; diff --git a/libavcodec/qdm2.c b/libavcodec/qdm2.c index b2136c6824..f2029479c7 100644 --- a/libavcodec/qdm2.c +++ b/libavcodec/qdm2.c @@ -978,6 +978,10 @@ static int process_subpacket_9(QDM2Context *q, QDM2SubPNode *node) GetBitContext gb; int i, j, k, n, ch, run, level, diff; + /* PATCH: Prevent integer overflow */ + if (node->packet->size > INT_MAX / 8) { + return AVERROR_INVALIDDATA; + } init_get_bits(&gb, node->packet->data, node->packet->size * 8); n = coeff_per_sb_for_avg[q->coeff_per_sb_select][QDM2_SB_USED(q->sub_sampling) - 1] + 1; -- 2.52.0.windows.1 --0000000000005188cd06477fffc3 Content-Type: application/octet-stream; name="0001-avcodec-compat-fix-OOB-access-integer-overflows-and-.patch" Content-Disposition: attachment; filename="0001-avcodec-compat-fix-OOB-access-integer-overflows-and-.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_mjymyzuo0 RnJvbSA1N2MzZDAyZjZkZTY5MjY4ZjE4MTQzNmRkYmIyNGI3YmJkYTBjODFmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBPeEJhdCA8bW9uc3RlcmJhdDAyQGdtYWlsLmNvbT4KRGF0ZTog U2F0LCAzIEphbiAyMDI2IDE5OjIzOjQ0ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gYXZjb2RlYyAm IGNvbXBhdDogZml4IE9PQiBhY2Nlc3MsIGludGVnZXIgb3ZlcmZsb3dzIGFuZCBETEwKIGhpamFj a2luZwoKLS0tCiBjb21wYXQvYW5kcm9pZC9iaW5kZXIuYyB8IDYgKysrKystCiBsaWJhdmNvZGVj L2R4di5jICAgICAgICB8IDIgKy0KIGxpYmF2Y29kZWMvZWF0cWkuYyAgICAgIHwgNiArKysrKysK IGxpYmF2Y29kZWMvcWRtMi5jICAgICAgIHwgNCArKysrCiA0IGZpbGVzIGNoYW5nZWQsIDE2IGlu c2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvY29tcGF0L2FuZHJvaWQv YmluZGVyLmMgYi9jb21wYXQvYW5kcm9pZC9iaW5kZXIuYwppbmRleCBhMjE0ZDk3N2NjLi4xZWZj ZjE1NWExIDEwMDY0NAotLS0gYS9jb21wYXQvYW5kcm9pZC9iaW5kZXIuYworKysgYi9jb21wYXQv YW5kcm9pZC9iaW5kZXIuYwpAQCAtNDEsNyArNDEsMTEgQEAgc3RhdGljIHZvaWQgKmRsb3Blbl9s aWJiaW5kZXJfbmRrKHZvaWQpCiAgICAgICogU2VlIGFsc286IGh0dHBzOi8vc291cmNlLmFuZHJv aWQuY29tL2RvY3MvY29yZS9hcmNoaXRlY3R1cmUvYWlkbC9haWRsLWJhY2tlbmRzCiAgICAgICov CiAKLSAgICB2b2lkICpoID0gZGxvcGVuKCJsaWJiaW5kZXJfbmRrLnNvIiwgUlRMRF9OT1cgfCBS VExEX0xPQ0FMKTsKKyAgICAvKiBQQVRDSCBTRUNVUklUWSBETEwgSGlqYWNraW5nKi8KKyAgICB2 b2lkICpoID0gZGxvcGVuKCIvc3lzdGVtL2xpYjY0L2xpYmJpbmRlcl9uZGsuc28iLCBSVExEX05P VyB8IFJUTERfTE9DQUwpOworICAgIGlmICghaCkgeworICAgIGggPSBkbG9wZW4oIi9zeXN0ZW0v bGliL2xpYmJpbmRlcl9uZGsuc28iLCBSVExEX05PVyB8IFJUTERfTE9DQUwpOworICAgIH0KICAg ICBpZiAoaCAhPSBOVUxMKQogICAgICAgICByZXR1cm4gaDsKIApkaWZmIC0tZ2l0IGEvbGliYXZj b2RlYy9keHYuYyBiL2xpYmF2Y29kZWMvZHh2LmMKaW5kZXggMDdlZWUyNTNlNy4uZGFhMjMzZjk2 OSAxMDA2NDQKLS0tIGEvbGliYXZjb2RlYy9keHYuYworKysgYi9saWJhdmNvZGVjL2R4di5jCkBA IC03Myw3ICs3Myw3IEBAIHR5cGVkZWYgc3RydWN0IERYVkNvbnRleHQgewogICAgICAgICAgICAg YnJlYWs7ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgXAogICAgICAgICBjYXNlIDI6ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAogICAgICAgICAgICAgaWR4ID0gKGJ5 dGVzdHJlYW0yX2dldF9ieXRlKGdiYykgKyAyKSAqIHg7ICAgICAgICAgICAgICAgICAgICAgICAg XAotICAgICAgICAgICAgaWYgKGlkeCA+IHBvcykgeyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgXAorICAgICAgICAgICAgaWYgKGlkeCA+IHBvcyB8fCBp ZHggPiBjdHgtPnRleF9zaXplKSByZXR1cm4gQVZFUlJPUl9JTlZBTElEREFUQTsgLyogUEFUQ0gg SW5kZXggVW5kZXJmbG93Ki8gICAgICAgICAgICAgICAgICBcCiAgICAgICAgICAgICAgICAgYXZf bG9nKGF2Y3R4LCBBVl9MT0dfRVJST1IsICJpZHggJWQgPiAlZFxuIiwgaWR4LCBwb3MpOyAgICAg ICBcCiAgICAgICAgICAgICAgICAgcmV0dXJuIEFWRVJST1JfSU5WQUxJRERBVEE7ICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBcCiAgICAgICAgICAgICB9ICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCmRpZmYg LS1naXQgYS9saWJhdmNvZGVjL2VhdHFpLmMgYi9saWJhdmNvZGVjL2VhdHFpLmMKaW5kZXggNDIx ZWQ1MTAwOS4uNDM0MjVlZjYxOSAxMDA2NDQKLS0tIGEvbGliYXZjb2RlYy9lYXRxaS5jCisrKyBi L2xpYmF2Y29kZWMvZWF0cWkuYwpAQCAtMTExLDYgKzExMSwxMiBAQCBzdGF0aWMgaW5saW5lIHZv aWQgdHFpX2lkY3RfcHV0KEFWQ29kZWNDb250ZXh0ICphdmN0eCwgQVZGcmFtZSAqZnJhbWUsCiAK IHN0YXRpYyB2b2lkIHRxaV9jYWxjdWxhdGVfcXRhYmxlKFRxaUNvbnRleHQgKnQsIGludCBxdWFu dCkKIHsKKyAgICAvKiBQQVRDSDogUHJldmVudCB1bmRlcmZsb3cgKi8KKyAgICBpZiAocXVhbnQg PiAxMDcpIHsKKyAgICAgICAgYXZfbG9nKHQtPmF2Y3R4LCBBVl9MT0dfRVJST1IsICJJbnZhbGlk IHF1YW50aXplciB2YWx1ZTogJWQsIGNsYW1waW5nIHRvIDEwN1xuIiwgcXVhbnQpOworICAgICAg ICBxdWFudCA9IDEwNzsKKyAgICB9CisKICAgICBjb25zdCBpbnQ2NF90IHFzY2FsZSA9ICgyMTUg LSAyKnF1YW50KSo1OwogICAgIGludCBpOwogCmRpZmYgLS1naXQgYS9saWJhdmNvZGVjL3FkbTIu YyBiL2xpYmF2Y29kZWMvcWRtMi5jCmluZGV4IGIyMTM2YzY4MjQuLmYyMDI5NDc5YzcgMTAwNjQ0 Ci0tLSBhL2xpYmF2Y29kZWMvcWRtMi5jCisrKyBiL2xpYmF2Y29kZWMvcWRtMi5jCkBAIC05Nzgs NiArOTc4LDEwIEBAIHN0YXRpYyBpbnQgcHJvY2Vzc19zdWJwYWNrZXRfOShRRE0yQ29udGV4dCAq cSwgUURNMlN1YlBOb2RlICpub2RlKQogICAgIEdldEJpdENvbnRleHQgZ2I7CiAgICAgaW50IGks IGosIGssIG4sIGNoLCBydW4sIGxldmVsLCBkaWZmOwogCisgICAgLyogUEFUQ0g6IFByZXZlbnQg aW50ZWdlciBvdmVyZmxvdyAqLworICAgIGlmIChub2RlLT5wYWNrZXQtPnNpemUgPiBJTlRfTUFY IC8gOCkgeworICAgIHJldHVybiBBVkVSUk9SX0lOVkFMSUREQVRBOworICAgIH0KICAgICBpbml0 X2dldF9iaXRzKCZnYiwgbm9kZS0+cGFja2V0LT5kYXRhLCBub2RlLT5wYWNrZXQtPnNpemUgKiA4 KTsKIAogICAgIG4gPSBjb2VmZl9wZXJfc2JfZm9yX2F2Z1txLT5jb2VmZl9wZXJfc2Jfc2VsZWN0 XVtRRE0yX1NCX1VTRUQocS0+c3ViX3NhbXBsaW5nKSAtIDFdICsgMTsKLS0gCjIuNTIuMC53aW5k b3dzLjEKCg== --0000000000005188cd06477fffc3 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org --0000000000005188cd06477fffc3--