Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Baptiste Bd via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: Baptiste Bd <monsterbat02@gmail.com>
Subject: [FFmpeg-devel] [PATCH] tools/zmqsend: fix integer overflow check
Date: Sat, 3 Jan 2026 17:20:49 +0100
Message-ID: <CABgBe0pPjDbD6u0m8d0NBx++q9gDHWJAgsRRYSO=oDCd9RWSSA@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1407 bytes --]

>From 8286eb98a6f40fc1e69507213073486ef06d3a5d Mon Sep 17 00:00:00 2001
From: OxBat <monsterbat02@gmail.com>
Date: Sat, 3 Jan 2026 17:10:07 +0100
Subject: [PATCH] tools/zmqsend: fix integer overflow on 32-bit systems in
 tools/zmqsend.c

---
 tools/zmqsend.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/tools/zmqsend.c b/tools/zmqsend.c
index dc5d426cc8..b2d66bb8bc 100644
--- a/tools/zmqsend.c
+++ b/tools/zmqsend.c
@@ -149,8 +149,16 @@ int main(int argc, char **argv)
         goto end;
     }

-    recv_buf_size = zmq_msg_size(&msg) + 1;
+/* PATCH SECURITY: Fix integer overflow on 32-bit systems */
+    size_t sz = zmq_msg_size(&msg);
+    if (sz == SIZE_MAX) {
+        av_log(NULL, AV_LOG_ERROR, "Message too large (overflow
detected)\n");
+        ret = 1;
+        goto end;
+    }
+    recv_buf_size = sz + 1;
     recv_buf = av_malloc(recv_buf_size);
+
     if (!recv_buf) {
         av_log(NULL, AV_LOG_ERROR,
                "Could not allocate receiving message buffer\n");
@@ -158,6 +166,7 @@ int main(int argc, char **argv)
         ret = 1;
         goto end;
     }
+
     memcpy(recv_buf, zmq_msg_data(&msg), recv_buf_size - 1);
     recv_buf[recv_buf_size-1] = 0;
     printf("%s\n", recv_buf);
@@ -168,4 +177,4 @@ end:
     zmq_close(socket);
     zmq_ctx_destroy(zmq_ctx);
     return ret;
-}
+}
\ No newline at end of file
-- 
2.52.0.windows.1

[-- Attachment #2: 0001-tools-zmqsend-fix-integer-overflow-on-32-bit-systems.patch --]
[-- Type: application/octet-stream, Size: 1412 bytes --]

[-- Attachment #3: Type: text/plain, Size: 163 bytes --]

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org

                 reply	other threads:[~2026-01-06  2:10 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CABgBe0pPjDbD6u0m8d0NBx++q9gDHWJAgsRRYSO=oDCd9RWSSA@mail.gmail.com' \
    --to=ffmpeg-devel@ffmpeg.org \
    --cc=monsterbat02@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git