From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 72C6841207 for ; Tue, 19 Apr 2022 07:10:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 43B6368B35A; Tue, 19 Apr 2022 10:10:13 +0300 (EEST) Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EB17968B2A8 for ; Tue, 19 Apr 2022 10:10:06 +0300 (EEST) Received: by mail-ej1-f47.google.com with SMTP id l7so31008920ejn.2 for ; Tue, 19 Apr 2022 00:10:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=57zFsQ/1CbyK1PVH0XROYyu2X2YFYM/W0Wtn4OYwxpk=; b=mmzXCRGBvVBfYJC0cfyG411ehXCHOVJmM5SdA4sa5j6c1C7uQDneBDE4QQJ5hiQvbb PW/4lFXh+6JX8dHghHo1o+ZEEoBfc756Y0hZLKlpGdyDUg/rgb5fR2OIMjbZFt01fSKX kjWMqnu6koX+HIXKFr+f/R6B95fd1dBdR2/8tslsIRtC+25yjGfQbfUB7ZgRIwuJxn1S trBgds+mBNCBDfD9HF4U9OLAQnBlOajVB5a2rqPwEZD6bFOE+Bp3rO+1I+Va6hi3h35s Czd+cCCDlE0aB88TqF7eiLf7IC3UwjvOPEbVweZ6SjvZRf+2NaR1QuSFFSb3r05LlMiI K3ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=57zFsQ/1CbyK1PVH0XROYyu2X2YFYM/W0Wtn4OYwxpk=; b=HjXyK6THJkmzFhnHQTu2K3NJwbYsAwBsodnHI/NE6R4hH3YA1ZMRSi+vx61XBFGYV2 79p7MjlwkrKX5FdbX5NOqZiMYFCW1Jh3rZ3D2wxz91T6L2TefPKKcM5WB4z94A1FephX uNH1lKPX5hXi0lOCDeUmsD5oQdIMLOMmT40LrtQQXvoAiw1OZc6BBgYFuE/jNycaO2fX TPJYHvcqJq5sYeYw9Qkv0cBMHahYBoWRZ5Z5Zijs5VwX1jIab8hfxYj4+XOgoY2n2N0A hKtWjyUuOu9IjITsUomUb0xWfbqGqJft14AfbKGZngR/ZxG545IswWvzO0hYThxcl5pv yWCA== X-Gm-Message-State: AOAM532tv0ix8VbCxnIipC6lsoPnAA4YYpjBpzedvsrVmwCNIsaoQY6v 3eRH6ti82JGBUN1y7heDBnGqQSB2h+Uo8w1c8MB7OFtMOwmT4w== X-Google-Smtp-Source: ABdhPJzkzVO+3ow/xEzBDNj1W9ZJDHiUjqA/pjLyD83B/hjX7kJyLsO0KaGSC3cOZKGAvKiOd/9bGn6k1s8PPaeGZg8= X-Received: by 2002:a17:906:49d4:b0:6d6:e5ec:9a23 with SMTP id w20-20020a17090649d400b006d6e5ec9a23mr12179974ejv.79.1650352205936; Tue, 19 Apr 2022 00:10:05 -0700 (PDT) MIME-Version: 1.0 References: <20220413161515.6999-1-jamrial@gmail.com> In-Reply-To: From: "Diederick C. Niehorster" Date: Tue, 19 Apr 2022 09:09:49 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 1/2] avdevice/dshow: remove unused variables X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, Apr 19, 2022 at 8:10 AM Roger Pack wrote: > > LGTM. Not LGTM, see below > On Wed, Apr 13, 2022 at 10:15 AM James Almer wrote: > > > > Remnant from f125c504d8fece6420bb97767f9e72414c26312a > > > > Signed-off-by: James Almer > > --- > > libavdevice/dshow.c | 8 -------- > > 1 file changed, 8 deletions(-) > > > > diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c > > index 1e69620880..ac8b64366f 100644 > > --- a/libavdevice/dshow.c > > +++ b/libavdevice/dshow.c > > @@ -814,10 +814,6 @@ dshow_cycle_formats(AVFormatContext *avctx, enum dshowDeviceType devtype, > > / ctx->requested_framerate.num : 0; > > int requested_width = ctx->requested_width; > > int requested_height = ctx->requested_height; > > - // audio > > - int requested_sample_rate = ctx->sample_rate; > > - int requested_sample_size = ctx->sample_size; > > - int requested_channels = ctx->channels; > > > > if (IPin_QueryInterface(pin, &IID_IAMStreamConfig, (void **) &config) != S_OK) > > return; > > @@ -854,10 +850,6 @@ dshow_cycle_formats(AVFormatContext *avctx, enum dshowDeviceType devtype, > > requested_framerate = fmt_info->framerate; > > requested_width = fmt_info->width; > > requested_height = fmt_info->height; > > - } else { > > - requested_sample_rate = fmt_info->sample_rate; > > - requested_sample_size = fmt_info->sample_size; > > - requested_channels = fmt_info->channels; > > } > > av_free(fmt_info); // free but don't set to NULL to enable below check > > } These should be used further down when checking audio formats. I'll send a patch. Cheers, Dee _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".