From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DB5374218B for ; Wed, 15 Dec 2021 15:09:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2AA4468AF6E; Wed, 15 Dec 2021 17:09:08 +0200 (EET) Received: from mail-ua1-f54.google.com (mail-ua1-f54.google.com [209.85.222.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6A1D168AD3D for ; Wed, 15 Dec 2021 17:09:01 +0200 (EET) Received: by mail-ua1-f54.google.com with SMTP id a14so41635524uak.0 for ; Wed, 15 Dec 2021 07:09:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=BWe7rTlEB8CbyUv7SQKsYorv4qZFncFJns6KN6A4xxE=; b=FwPtJxG4cHfQ2XaKOKd3V5ioxpDR3J45xn52LIQLww4kCCS1nQUxhmJYDnsdxn/rwq dpY/Ii0KdDL9pKOanlkX+mzHJnCegslnw9FxbCnZeKHGDsUiy8JcbyUOxWuUwAc+E3g9 itWeKHkPe1hI1fEt4g1L5C+lVmM6BPavhI0o3WKuAmwt4Z3ZJNfljQGWX8737lF0USw3 GWU2/Mb3RNxaL8KEtcQ4H0QEKFRQGzxjacCmBheVLhrnXsd2aSM3WiyNbMWc1c5ev4e3 DqupyPFghe9PMfQsf++kU4T5GUt8j/19GYk/wkjEszelHVanB+V1ZaUw0rBI2QrWZ2Sl brOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=BWe7rTlEB8CbyUv7SQKsYorv4qZFncFJns6KN6A4xxE=; b=4awZBdFaGEga35ftAFPKCmUKWN3nEEI8Kc9aBTqFkQfA35HiwY9FtXqSVWtAqDU73T G8erD4m7EVnZhAvPNYiFhyZZtenkUCZzSTjXQ3hQnZ/s5Yj3xWJRAsyOujxheZTfxveZ q5sEhxou0bqosaXjxLeQagbyiia3BHtxkKkyKeZ3ugIvcpQJl7WyOAfkhbPpv8wIEa0I SW2aas9kRGabdqHmi7tBwKvwl+TEBawIPXfwxuhafO2JgdhPlwmWSdCEPG1V7kvG3qd0 LTMPyLKLjA1buzyomWYYNYM5ZKnpx4wObzEiD7NOPAQUV6YZEYfLuUjaoJn0qhiMVjvf Btnw== X-Gm-Message-State: AOAM531MQcOt8yBjkFCqbddMTH4+ji8FJHVf+oZsRA4XuHfwkFD2CkcC VJoa8mjNfH/761ymoZfj+5sWVZ9QEkIc51m6+onu6uOIbgU= X-Google-Smtp-Source: ABdhPJxDMw0kFdRNF+ryfMvznqNp506tedJs8hAIhkoxoxp4GNdjW5tCabsR8h1nYYJkJEUyA3nY81HWw1foHIZMt5o= X-Received: by 2002:a9f:2d8c:: with SMTP id v12mr9729635uaj.25.1639580939524; Wed, 15 Dec 2021 07:08:59 -0800 (PST) MIME-Version: 1.0 References: <20211125171932.GC2829255@pb2> <20211213152557.GL2829255@pb2> <20211214161924.GM2829255@pb2> <20211215145235.GU2829255@pb2> In-Reply-To: <20211215145235.GU2829255@pb2> From: "Diederick C. Niehorster" Date: Wed, 15 Dec 2021 16:08:43 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] 5.0 release X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi Michael, On Wed, Dec 15, 2021 at 3:52 PM Michael Niedermayer wrote: > > On Tue, Dec 14, 2021 at 05:42:01PM +0100, Diederick C. Niehorster wrote: > > Hi Michael, > > > > On Tue, Dec 14, 2021 at 5:19 PM Michael Niedermayer > > wrote: > > > > > > > > > The patches do not say in their commit messages that they have been reviewed > > > maybe you want to repost them with that changed. > > > > Thanks for having a look! > > I have mentioned this here: > > https://ffmpeg.org/pipermail/ffmpeg-devel/2021-December/289461.html > > > > Or do you mean that for each specific patch, if there were previous > > review comments, i should mention that it was updated in response to > > the review? For some that may be hard (e.g. i was asked to change the > > order of some commits). > > Patches which where approved already and not changed since then could > contain that information in the commit message. We tend to use some > Reviewed-by: ... > for that > that may speed up future review and commit > > I dont know dshow and dont have a proper setup to test it so i wont be > applying or reviewing these patches Ah, i see. I have made changes here in response to other review comment since i got that LGTM for the series. I'll contact the dshow maintainer again for that (I assume he would be the only one who should be committing my patchset?). Thanks, Dee _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".