From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B2B43402AC for ; Mon, 20 Dec 2021 08:11:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E8D3668AF50; Mon, 20 Dec 2021 10:11:06 +0200 (EET) Received: from mail-vk1-f170.google.com (mail-vk1-f170.google.com [209.85.221.170]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 039E368ADF7 for ; Mon, 20 Dec 2021 10:11:01 +0200 (EET) Received: by mail-vk1-f170.google.com with SMTP id m200so5625422vka.6 for ; Mon, 20 Dec 2021 00:11:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=lRXFfn+vuvZk4nJhBaK+7fmDRTKdRU3t9H9JR0up9QI=; b=ZFfZByvFjnFXTb1QqWJTqrrVhCuP5ycK2OvRAcbyoCK/Jhm6G7KZG42a0nDruqtaxS 3zaTgzLXhycQ3daK61GRCiF/He6RFKLqm3RvXuh+yNfarayDTiB+bcACs4PrO6l0UPcC Ydg6RIJB48t4BGnD9LCchqYziSOOCg9Hj7cnI5Suk5sI3XzKZXyTcRyDkOxOWTg3ERcO RuKn77n5qunqVAJUVwAguJ/Ld4cQPhvJwuRH55bq1wArv4S6nG4ZubN/wAGJJrfQcfSj TkmlVGlxTjRdTYuMseaIEgJwAswAttc1dDvciFPCiaRfS18Fafsx4ZfcEdSOAC51Lo4t TFSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=lRXFfn+vuvZk4nJhBaK+7fmDRTKdRU3t9H9JR0up9QI=; b=dkKJVrjcHfBt/19Rls6LlqoMJXQrGK7iYYlvbFPN0x4OHbA3kOoLEpMrVCnI2Iwk4D ij9g9dtLYRpyzUu3+JG/FbWkmhWlGpHktDS165Gq4CN7qrgyeH/Dp/odPCWxxV9hpd0l qf2wiiBWq6fStyDBRWLjWvb5quXKQ9fm80fL9ylOM3rc9tFjiyOw4h4tM6/KpTMShHHA klnw1VA3wM89nHUg9mHveAsO6rArkYVbIJrrh6XO1+iZNAKDx6kEqGGyZ3kL5PP+xSPG OIOep+VSJaswNTBkZiLe73dyTq/E56LSI6klW6EeYti7xxyni6QD0AK2ZrhQnXcmOhtx CrDw== X-Gm-Message-State: AOAM5316AguLBCsTJlrlKu8LViLs67XrKaHDksHjHOExfC0/Bzu6d+/f SlcRVV0BC/QLLI1LRr+ksZYc7vIM2CELO4rM0mVrTDsMu9zjUg== X-Google-Smtp-Source: ABdhPJy8U8uETm/lsRMqJ9Hg+PzEXosqj2VV4BdxE4rjsVf5db5b3RLj4gf4khC8ljKu9B5nuEWeF8G2nPmuaW9Furk= X-Received: by 2002:a05:6122:ca0:: with SMTP id ba32mr720127vkb.26.1639987859090; Mon, 20 Dec 2021 00:10:59 -0800 (PST) MIME-Version: 1.0 References: <20211219192134.1296-1-dcnieho@gmail.com> <20211219192134.1296-13-dcnieho@gmail.com> In-Reply-To: From: "Diederick C. Niehorster" Date: Mon, 20 Dec 2021 09:10:43 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v5 12/13] avdevice/dshow: discover source color range/space/etc X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, Dec 20, 2021 at 2:27 AM Andreas Rheinhardt wrote: > > Diederick Niehorster: > > @@ -545,11 +759,40 @@ dshow_cycle_formats(AVFormatContext *avctx, enum dshowDeviceType devtype, > > } else { > > av_log(avctx, AV_LOG_INFO, " pixel_format=%s", av_get_pix_fmt_name(pix_fmt)); > > } > > - av_log(avctx, AV_LOG_INFO, " min s=%ldx%ld fps=%g max s=%ldx%ld fps=%g\n", > > + av_log(avctx, AV_LOG_INFO, " min s=%ldx%ld fps=%g max s=%ldx%ld fps=%g", > > vcaps->MinOutputSize.cx, vcaps->MinOutputSize.cy, > > 1e7 / vcaps->MaxFrameInterval, > > vcaps->MaxOutputSize.cx, vcaps->MaxOutputSize.cy, > > 1e7 / vcaps->MinFrameInterval); > > + if (extended_format_info) { > > + enum AVColorRange col_range = dshow_color_range(extended_format_info); > > + enum AVColorSpace col_space = dshow_color_space(extended_format_info); > > + enum AVColorPrimaries col_prim = dshow_color_primaries(extended_format_info); > > + enum AVColorTransferCharacteristic col_trc = dshow_color_trc(extended_format_info); > > + enum AVChromaLocation chroma_loc = dshow_chroma_loc(extended_format_info); > > + if (col_range != AVCOL_RANGE_UNSPECIFIED || col_space != AVCOL_SPC_UNSPECIFIED || col_prim != AVCOL_PRI_UNSPECIFIED || col_trc != AVCOL_TRC_UNSPECIFIED) { > > + const char *range = av_color_range_name(col_range); > > + const char *space = av_color_space_name(col_space); > > + const char *prim = av_color_primaries_name(col_prim); > > + const char *trc = av_color_transfer_name(col_trc); > > + av_log(avctx, AV_LOG_INFO, " (%s, %s/%s/%s", > > + range ? range : "unknown", > > + space ? space : "unknown", > > + prim ? prim : "unknown", > > + trc ? trc : "unknown"); > > + if (chroma_loc != AVCHROMA_LOC_UNSPECIFIED) { > > + const char *chroma = av_chroma_location_name(chroma_loc); > > + av_log(avctx, AV_LOG_INFO, ", %s", chroma ? chroma : "unknown"); > > + } > > + av_log(avctx, AV_LOG_INFO, ")"); > > + } > > + else if (chroma_loc != AVCHROMA_LOC_UNSPECIFIED) { > > + const char *chroma = av_chroma_location_name(chroma_loc); > > + av_log(avctx, AV_LOG_INFO, "(%s)", chroma ? chroma : "unknown"); > > + } > > This looks an awful lot like avcodec_string(). The logic is modeled after that indeed, but i only need a small part of what avcodec_string does, and don't have avcodeccontext here, so can't use avcodec_string. Is there a change you think i should make here? Thanks! Dee _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".