Re: [FFmpeg-devel] [PATCH v5 09/13] avdevice: add info about media types(s) to AVDeviceInfo

["Diederick C. Niehorster" <dcnieho@gmail.com>]

Hi Andreas,

On Mon, Dec 20, 2021 at 1:59 AM Andreas Rheinhardt
<andreas.rheinhardt@outlook.com> wrote:
>
> Diederick Niehorster:
> > diff --git a/libavdevice/avdevice.h b/libavdevice/avdevice.h
> > index 8370bbc7f2..6f24976dcc 100644
> > --- a/libavdevice/avdevice.h
> > +++ b/libavdevice/avdevice.h
> > @@ -457,6 +457,8 @@ void avdevice_capabilities_free(AVDeviceCapabilitiesQuery **caps, AVFormatContex
> >  typedef struct AVDeviceInfo {
> >      char *device_name;                   /**< device name, format depends on device */
> >      char *device_description;            /**< human friendly name */
> > +    enum AVMediaType *media_types;       /**< array indicating what media types(s), if any, a device can provide. If null, cannot provide any */
> > +    int nb_media_types;                  /**< length of media_types array, 0 if device cannot provide any media types */
>
> Personally, I'd prefer it if this were unsigned given that negative
> values don't make sense. But this is just a personal preference.

I agree with you, but almost all nb_ in ffmpeg are int, so I guess its
best to use that here too and avoid any surprises.

I have applied all your comments, except the two i asked questions
about, and you comment on patch 8 to allocate media_types on the
stack, since it is to be returned to caller as you noticed yourself
later.

Thanks for the comments!
Dee
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".