From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E8F29426FD for ; Tue, 22 Mar 2022 19:08:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1F7FA68B16F; Tue, 22 Mar 2022 21:08:13 +0200 (EET) Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 25A7E68049F for ; Tue, 22 Mar 2022 21:08:05 +0200 (EET) Received: by mail-ej1-f43.google.com with SMTP id o10so19558020ejd.1 for ; Tue, 22 Mar 2022 12:08:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EZZeU5mTGJK8kRO1ygrxk8rXnUVfQG4pnS0L3G7kNoo=; b=GLKN9z0Zy3f7sIwU96yajKCLqw8iROuXfeXq7lng+y5SPYs2XLUVtMzaCR+lA0DTiP 09Vd1LwiQ0o5tFeHQzJWy1lfahRe5aw6Ohs2Fnyc1kc8ifch+huE3sUK+gn85Dk1oSwJ ms0gOeoJl00PpsKWcs/Yfi6u5klxGx2B257m8MFgJHXm/dm5iSbxta4kZp3gn5clAG1E 1xDFuionRStg6+VAD9n368TbubBoBdefjjzayKc7OUS0hU/ZSfhb98uGkLzk2K64Kqz9 GNMSzHgYa+Iey8737UMEfQ9o1P65TlGVoqwaclt0EWLw/bFCgqM7Dej5iIrWuJuVy51G g0Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EZZeU5mTGJK8kRO1ygrxk8rXnUVfQG4pnS0L3G7kNoo=; b=eCHKgBdq6VfPPBOaxdsHy8nIYLyXunAmrVxRvrLcR7ELhX8QwLPRahQb/QwMNdDxm9 7gvxiF8Zno5dDL4RxdSc26l3vtCD7EJprl5xgb4dLwT1N5x/98hbb/7PY4NQjX42Zhm+ bfplm1Obn33v0P97F2dcNylaVTwDxGpM11nU45tUypNx/Fo0qx+1/iyuP/gJm68EZCWf 9/muOiN+ys5dDwYv0xvFU3U+0icizns5GQzqOB2zzyyR0++yDyLxcAq+3oivzoHMpLMC /0KYKj4H8+mkXsAgbVXCKWaljdQXiTpD9dZdkAOwlnDHmf5ucD+FTXFv8W8AyOO7Datp iBQQ== X-Gm-Message-State: AOAM532srAedcQrsnni8y6g5DtgJoVSYIl4bmJ1DwcyUH5dgaMfCXJ20 j7fN7pE2hXLVpyZqi6V6TBSiiXMRjDjc8JwZEFyFrxZmmK69BQ== X-Google-Smtp-Source: ABdhPJxQFvxLNqlyi3Y7aYEJpJROM7vp2VqBNrb5BtON7wJ5Iz+AH4wI5cqA1sB8qGHWlrKMlaEAPzC2FTyIMMxcsSs= X-Received: by 2002:a17:906:c253:b0:6e0:592a:49f8 with SMTP id bl19-20020a170906c25300b006e0592a49f8mr793701ejb.707.1647976084143; Tue, 22 Mar 2022 12:08:04 -0700 (PDT) MIME-Version: 1.0 References: <20220322133957.81743-1-toots@rastageeks.org> <20220322133957.81743-2-toots@rastageeks.org> In-Reply-To: From: "Diederick C. Niehorster" Date: Tue, 22 Mar 2022 20:07:46 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 1/6] Fix dshow device name/description X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Romain Beauxis Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, Mar 22, 2022 at 3:10 PM Roger Pack wrote: > > On Tue, Mar 22, 2022 at 7:40 AM wrote: > > > > From: Romain Beauxis > > > > diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c > > index 6039578ff9..4ee3f6e194 100644 > > --- a/libavdevice/dshow.c > > +++ b/libavdevice/dshow.c > > @@ -552,8 +552,8 @@ dshow_cycle_devices(AVFormatContext *avctx, ICreateDevEnum *devenum, > > if (!device) > > goto fail; > > > > - device->device_name = av_strdup(friendly_name); > > - device->device_description = av_strdup(unique_name); > > + device->device_name = av_strdup(unique_name); > > + device->device_description = av_strdup(friendly_name); > > if (!device->device_name || !device->device_description) > > goto fail; > > > > LGTM. > The device enumeration API was added only recently to dshow, guess a > bug crept in. > Thanks! LGTM. Indeed, this was code introduced by my patch, committed to the ffmpeg repo only 91 days ago. Indeed, this should have been the other way around given the documentation of struct AVDeviceInfo. All the best, Dee _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".