Re: [FFmpeg-devel] [PATCH v2 4/5] libswscale: Enable hscale_avx2 for all input sizes.

From: Alan Kelly <alankelly-at-google.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2 4/5] libswscale: Enable hscale_avx2 for all input sizes.
Date: Mon, 18 Jul 2022 09:54:39 +0200
Message-ID: <CABaBdZq2hG=M4k-2F7vpHuv=4moo-HRun0-F21NEbaH2HosGiA@mail.gmail.com> (raw)
In-Reply-To: <20220716111431.GG2088045@pb2>

Hi Michael,

I have tried to recreate this locally in a clean client applying the
patches as sent in the email thread. I have tried gcc and mingw and this
passes for me. Are you sure you applied both patches 3 & 4? If only patch 4
is applied, then I get the error you have.

Thanks,

Alan

On Sat, Jul 16, 2022 at 1:14 PM Michael Niedermayer <michael@niedermayer.cc>
wrote:

> On Fri, Jul 15, 2022 at 05:03:56PM +0200, Alan Kelly wrote:
> > Hi Michael,
> >
> > Thanks for looking at this. I fixed the test issue.
>
> seems to be still failing here:
> make distclean ; ./configure && make -j32  tests/checkasm/checkasm &&
> tests/checkasm/checkasm --test=sw_scale
> checkasm: using random seed 1328711543
> MMXEXT:
>  - sw_scale.yuv2yuvX [OK]
> SSE2:
>  - sw_scale.hscale   [OK]
> SSE3:
>  - sw_scale.yuv2yuvX [OK]
> SSSE3:
>  - sw_scale.hscale   [OK]
> SSE4.1:
>  - sw_scale.hscale   [OK]
> AVX2:
>    hscale_8_to_15__fs_4_dstW_8_avx2 (sw_scale.c:235)
>    hscale_8_to_15__fs_4_dstW_24_avx2 (sw_scale.c:235)
>    hscale_8_to_15__fs_8_dstW_8_avx2 (sw_scale.c:235)
>    hscale_8_to_15__fs_8_dstW_24_avx2 (sw_scale.c:235)
>    hscale_8_to_15__fs_12_dstW_8_avx2 (sw_scale.c:235)
>    hscale_8_to_15__fs_12_dstW_24_avx2 (sw_scale.c:235)
>    hscale_8_to_15__fs_16_dstW_8_avx2 (sw_scale.c:235)
>    hscale_8_to_15__fs_16_dstW_24_avx2 (sw_scale.c:235)
>    hscale_8_to_15__fs_32_dstW_8_avx2 (sw_scale.c:235)
>    hscale_8_to_15__fs_32_dstW_24_avx2 (sw_scale.c:235)
>    hscale_8_to_15__fs_40_dstW_8_avx2 (sw_scale.c:235)
>    hscale_8_to_15__fs_40_dstW_24_avx2 (sw_scale.c:235)
>  - sw_scale.hscale   [FAILED]
>  - sw_scale.yuv2yuvX [OK]
> checkasm: 12 of 504 tests have failed
>
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> It is a danger to trust the dream we wish for rather than
> the science we have, -- Dr. Kenneth Brown
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".