From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7820E42152 for ; Thu, 16 Dec 2021 16:10:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6896468998A; Thu, 16 Dec 2021 18:10:05 +0200 (EET) Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 486E968998A for ; Thu, 16 Dec 2021 18:09:58 +0200 (EET) Received: by mail-yb1-f172.google.com with SMTP id j2so65726825ybg.9 for ; Thu, 16 Dec 2021 08:09:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=fVprdl3A9BOUssGqX7AocCikX4IT9+xTn85sO0dGw6Q=; b=tc1jSNGEhUURJ8qv2qhe6YOx1/WTvBmPCu7fVpaNV+O8+TtLxiGdFDbooZqRNcH2I2 aIqgd5BRMHNgkVfBGuPch6sQIj/DySzqbMPgzrEeS8x5Y4m30VJ+Z4vsckzDjJJHzn5p Bw3X/Z7fZzoFW8DlnIJYv9uKYdakMEkM+cNMfTKDNpR013v3ofMKdVDrKYExhAXjKCed 7s0TTbc3l3AN4nUfe9rW7X8Jk7vSwSpwSAORNTiqgWpDRvsGsJYlNCjkVmNlT+f8kBL/ SiuOMMdfRFIYN5FK600uhQ14TxWBNMSuUgOHeHu14KPhJxLxe7EMvZBE5lvsZ51nMNn4 wbOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=fVprdl3A9BOUssGqX7AocCikX4IT9+xTn85sO0dGw6Q=; b=eVT1gJco9nb4I2bVK0TuG3YOB+JbQIyODsicFHn6500sTEHeKccoxnTkpwUCNtM+3p cM34OhILFL/Cbmg+AiDfRTPArsklha2iryUkkEIL0DFfGMOry31pGFj1HTN7OAg9whTo E+38663QUccHpdOTnM4HtUpCHdm13rXWoKxzuh1l9HDz5UjvQPH+TsX43Z50Abjix9xb FbbROmUU5PmI7uU13IrTzSu7TifOMmc6G4ZgNtvwPO1GyO2BW4QHNfGjxIvJSN3U6Vmv pvQ9uEIKfmMAJN+SaOd1fTUA8z4ShyH3PfPdWe4SLbA0odqq6qPMOE0JkmJSxaBIbtNH 4BcA== X-Gm-Message-State: AOAM531JQ8dVukiEJIjKSjZh9KOHN84vaGqLWx7om0VOzjRBaOs0/Ub3 OFD7Yjo2Eqvg3ZZ8wDfHKNpTfW16RWHk2eqIsHFkQx0qBeU= X-Google-Smtp-Source: ABdhPJxrIDt+nj97CKLFgWcbTa7T9RTr8KipI1SKTuzDOgdDNfeuaKJyKKVBHSwTseh2R6tpWsy6LZ/ZMIER8R/9Duw= X-Received: by 2002:a25:4e88:: with SMTP id c130mr14142767ybb.705.1639670996208; Thu, 16 Dec 2021 08:09:56 -0800 (PST) MIME-Version: 1.0 References: <20211216160548.2035835-1-alankelly@google.com> In-Reply-To: <20211216160548.2035835-1-alankelly@google.com> From: Alan Kelly Date: Thu, 16 Dec 2021 17:09:45 +0100 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] x86/swscale: fix minor coding style issues X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Thanks Lynne for the patch. On Thu, Dec 16, 2021 at 5:05 PM Alan Kelly wrote: > --- > libswscale/x86/swscale.c | 14 +++++++------- > tests/checkasm/sw_scale.c | 3 +-- > 2 files changed, 8 insertions(+), 9 deletions(-) > > diff --git a/libswscale/x86/swscale.c b/libswscale/x86/swscale.c > index 164b06d6ba..c49a05c37b 100644 > --- a/libswscale/x86/swscale.c > +++ b/libswscale/x86/swscale.c > @@ -578,13 +578,13 @@ switch(c->dstBpc){ \ > break; \ > } > > - if (EXTERNAL_AVX2_FAST(cpu_flags)){ > - if ((c->srcBpc == 8) && (c->dstBpc <= 14)){ > - if(c->chrDstW % 16 == 0) > - ASSIGN_AVX2_SCALE_FUNC(c->hcScale, c->hChrFilterSize); > - if(c->dstW % 16 == 0) > - ASSIGN_AVX2_SCALE_FUNC(c->hyScale, c->hLumFilterSize); > - } > + if (EXTERNAL_AVX2_FAST(cpu_flags)) { > + if ((c->srcBpc == 8) && (c->dstBpc <= 14)) { > + if (c->chrDstW % 16 == 0) > + ASSIGN_AVX2_SCALE_FUNC(c->hcScale, c->hChrFilterSize); > + if (c->dstW % 16 == 0) > + ASSIGN_AVX2_SCALE_FUNC(c->hyScale, c->hLumFilterSize); > + } > } > > if (EXTERNAL_AVX2_FAST(cpu_flags)) { > diff --git a/tests/checkasm/sw_scale.c b/tests/checkasm/sw_scale.c > index 011cb46428..f4912e6c2c 100644 > --- a/tests/checkasm/sw_scale.c > +++ b/tests/checkasm/sw_scale.c > @@ -217,9 +217,8 @@ static void check_hscale(void) > } > ff_sws_init_scale(ctx); > memcpy(filterAvx2, filter, sizeof(uint16_t) * (SRC_PIXELS * > MAX_FILTER_WIDTH + MAX_FILTER_WIDTH)); > - if (cpu_flags & AV_CPU_FLAG_AVX2){ > + if (cpu_flags & AV_CPU_FLAG_AVX2) > ff_shuffle_filter_coefficients(ctx, filterPosAvx, width, > filterAvx2, SRC_PIXELS); > - } > > if (check_func(ctx->hcScale, "hscale_%d_to_%d_width%d", > ctx->srcBpc, ctx->dstBpc + 1, width)) { > memset(dst0, 0, SRC_PIXELS * sizeof(dst0[0])); > -- > 2.34.1.173.g76aa8bc2d0-goog > > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".