From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 819C945305 for ; Tue, 17 Jan 2023 22:07:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BE5B868BEA4; Wed, 18 Jan 2023 00:07:04 +0200 (EET) Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com [209.85.167.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 575BC68BC2D for ; Wed, 18 Jan 2023 00:06:59 +0200 (EET) Received: by mail-oi1-f175.google.com with SMTP id r9so2958326oig.12 for ; Tue, 17 Jan 2023 14:06:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=GXv7jXff4f2ZUNkNgPTtePyx5IJqrEIZ9e2mX8WnKz4=; b=dhVSx8HkETgfRxIWMv5BAYHHb6iMj+tCXVbZTSj99CxeKYJG4A/rdeAkx5I4WioMoW dHjsO3DtIExZ6h5rtW7hCqJ6lTBa18afvqzigXri/IPkCMAR2xDdagJH6JvMtVchzfzc SPm+qOT2XUE0tz0SmvAhKdnSMbnuL3AIDPAk9KJ4NMjDepvhN0ciuJQw0GncQTbCYZ0E vge0VOSTpAGWJ8fr5PP47OJiLJPY+toCIVAaracRcidmtk8S9JCuSDRX6WOE2Cx6pi7a bqkVWiV7PbrQtvybcjyPYyfAvF4BpE8PN9Vdrd5Wc/3WjssI5FJ9F+gPv9rLVb1JfmH0 2Xhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GXv7jXff4f2ZUNkNgPTtePyx5IJqrEIZ9e2mX8WnKz4=; b=6W99rMG7DXhkmTDkd4t6BMXVzd4laj0//zfyxEZ1kOXcjIv4CaMB+5AS2ekB/IqG/4 WQaJWJgei9K33erYZj9OHf9znigIA9mijol229ZE+zeh3hvuS7l8udOc5TS0EzplmTvZ Due6/Z1vAelUG2+aAkXB5V8rmbM6HMjpszzKptt+YqWXuc+DRH7PxHlbCgw2uDlEjl8A qsW+0TzWg+i0E+ncQvrNyazBMF8Bp910UWNkFZAbtqiXbgsawDABLV5oEkYoXfPCyXim q9SWQBkuDnTAt8cDAmWisrisZxuUpBfyPWgPjFMGw8sTF7WO6ED5cyoXRNuW72zoagjr DKYQ== X-Gm-Message-State: AFqh2kokRh9TDVpH88owHRc+wGD+QNcqFar1LJT866+TPUwQ4B6Fl+kr Isq55GJtUIDLJzykaFddWHuyiZx+cLMfwoKOtOn0gaDJnCudG/cK X-Google-Smtp-Source: AMrXdXsei2j8LuEe4ds+bxAEFrH41LqlEqIhsoxcmmbN5ZdRELFrO1GY+qvuRLwXgyJJx36HOkbSYfvEXsICwi4Hhss= X-Received: by 2002:aca:120b:0:b0:364:b253:8534 with SMTP id 11-20020aca120b000000b00364b2538534mr262964ois.256.1673993217138; Tue, 17 Jan 2023 14:06:57 -0800 (PST) MIME-Version: 1.0 References: <20230105104151.2055-1-Dmitriy.Ovchinnikov@amd.com> In-Reply-To: From: James Zern Date: Tue, 17 Jan 2023 14:06:46 -0800 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v3] lavc/libvpx: remove thread limit X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, Jan 10, 2023 at 5:23 PM James Zern wrote: > > On Tue, Jan 10, 2023 at 2:47 AM mypopy@gmail.com wrote: > > > > On Thu, Jan 5, 2023 at 6:42 PM Dmitrii Ovchinnikov > > wrote: > > [...] > > > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > > > index 9aa5510c28..0627e13973 100644 > > > --- a/libavcodec/libvpxenc.c > > > +++ b/libavcodec/libvpxenc.c > > > @@ -942,7 +942,7 @@ static av_cold int vpx_init(AVCodecContext *avctx, > > > enccfg.g_timebase.num = avctx->time_base.num; > > > enccfg.g_timebase.den = avctx->time_base.den; > > > enccfg.g_threads = > > > - FFMIN(avctx->thread_count ? avctx->thread_count : av_cpu_count(), 16); > > > + avctx->thread_count ? avctx->thread_count : av_cpu_count(); > > > enccfg.g_lag_in_frames= ctx->lag_in_frames; > > > > > Do you check the change with the old version libvpx? as I know, older > > versions libvpx setting the number of threads higher than 16 will > > cause a crash, so I think at least a version check needs to be added > > > > Do you have a bug or version in mind? There were some performance > regressions [1] over the releases and some issues with changing the > number of tiles, but I don't remember a crash for a high thread count > (though there have been plenty of crashes related to threads in > general [2]). The range check predates 1.4.0, which is the minimum > required by ffmpeg. > I merged the changes without a check. If there is a problem with a specific version we can add a check. > [1] https://crbug.com/webm/1574 > [2] https://crbug.com/webm/851 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".