From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 49BA041D3F for ; Wed, 25 May 2022 00:43:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4BB3868B4FE; Wed, 25 May 2022 03:43:29 +0300 (EEST) Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id ABE8E68B49E for ; Wed, 25 May 2022 03:43:22 +0300 (EEST) Received: by mail-yb1-f182.google.com with SMTP id q184so4857032ybg.11 for ; Tue, 24 May 2022 17:43:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jRMRki8ofO7/GpwN0TIYeglyW3YgFzr5fCYwhp1dkyU=; b=gFzPisF+eNj78E0TeottKYfJlGTY6X1Yzrlj6Llv/XsQh46Qceq94wBLKJRcth9l7o PjTS+P814tiHiLT/eq8rHGU+7VK2368nEwDbx9C+OyTTlDt5ticZbpe1PL5uFnA0lmE2 X4Ua+Bpeo6Jd9opvFADQfsOe/h07rnlLozcfZtztYHK54h53UnHOsppvMUqkWZA/BGOE tViu35aYRHwNxGgtPSEG7TI/sMsO3uaChte7sqZqltVM2OrVrGFe4jwulWpryzUGyXDl cSI0ysSKMHemnl3Aak4p7RVo0LOeBPzHSAAQEcn5TaPFwZD/3JOqiR+ladUQdPK+PcVt TQQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jRMRki8ofO7/GpwN0TIYeglyW3YgFzr5fCYwhp1dkyU=; b=A+ZC/MPd96nbtwj57dGq5t8SZHwKGwZ5uz32eHwLRKLWS5YeaGmauc6zPfzFDKC3AX Km9l/slwlAoPvY5CEHPwaJf/ZwRSvvmfLVJqvFDJbdn3VX79hspwWeJfE7fqD7LCvEeh 2nY5tS0CTyHQKEyh+WCdWa1AECXgJ78sJDG+JOG7yoN12j8U0EqUHZ+XS85SFTBFib2o YrVJIa7kgVXtxWDmezZvgis9sWIRbcibcmgTxbm7OX6d2SdGqLuRpHea/rPq1OpdHfSZ TjRklYg9zqLd0VkZOeJCEF0vLr7G3t/YQ08vkt5skb/Kq0v4C+Cv2q2oSSlmNvgxn54W I/Tw== X-Gm-Message-State: AOAM533ttXvcD47F4WGvg2RvJ7/00xNKz1myM7aYDRq8wCI9brsGxky5 r23oijYp1biPHtO5aKfZ79mVxNWKh5t/ZwI011eY7sq3kR5qHQ== X-Google-Smtp-Source: ABdhPJxfnU3SPEHh5FVGlsUFgJgXDiWnQ3Dk7YJz+DG4UgT7Fs3Wp2U0NgfChhG5PqIG+yI+nnlgHb8lOF4WZcqRjeI= X-Received: by 2002:a25:4cc6:0:b0:64d:b8ca:3380 with SMTP id z189-20020a254cc6000000b0064db8ca3380mr27476612yba.233.1653439399702; Tue, 24 May 2022 17:43:19 -0700 (PDT) MIME-Version: 1.0 References: <20220419170324.3342219-1-bohanli@google.com> <20220419181850.3392814-1-bohanli@google.com> In-Reply-To: From: James Zern Date: Tue, 24 May 2022 17:43:08 -0700 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/libaomenc: Add unmet target level warning X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Bohan Li Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, May 17, 2022 at 12:45 PM James Zern wrote: > > On Tue, Apr 19, 2022 at 11:20 AM Bohan Li > wrote: > > > > When target levels are set, this patch checks whether they are > > satisfied by libaom. If not, a warning is shown. Otherwise the output > > levels are also logged. > > > > This patch applies basically the same approach used for libvpx. > > > > Signed-off-by: Bohan Li > > --- > > libavcodec/libaomenc.c | 64 ++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 64 insertions(+) > > > > lgtm. > + } else if (target_levels[i] < 31) { > + // Log the encoded level if a target level was given > + av_log(avctx, AV_LOG_INFO, > + "Output level for operating point %d is %d.%d.", > + i, 2 + (levels[i] >> 2), levels[i] & 3); > + } Actually this is a bit spammy. If there's only one operating point set then I'd expect a single line output, but this seems to print all 32 regardless. Is that expected? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".