Re: [FFmpeg-devel] [PATCH v2] avcodec/libaomenc: Add unmet target level warning

[James Zern <jzern-at-google.com@ffmpeg.org>]

On Tue, May 17, 2022 at 12:45 PM James Zern <jzern@google.com> wrote:
>
> On Tue, Apr 19, 2022 at 11:20 AM Bohan Li
> <bohanli-at-google.com@ffmpeg.org> wrote:
> >
> > When target levels are set, this patch checks whether they are
> > satisfied by libaom. If not, a warning is shown. Otherwise the output
> > levels are also logged.
> >
> > This patch applies basically the same approach used for libvpx.
> >
> > Signed-off-by: Bohan Li <bohanli@google.com>
> > ---
> >  libavcodec/libaomenc.c | 64 ++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 64 insertions(+)
> >
>
> lgtm.

> +                } else if (target_levels[i] < 31) {
> +                    // Log the encoded level if a target level was given
> +                    av_log(avctx, AV_LOG_INFO,
> +                           "Output level for operating point %d is %d.%d.",
> +                           i, 2 + (levels[i] >> 2), levels[i] & 3);
> +                }

Actually this is a bit spammy. If there's only one operating point set
then I'd expect a single line output, but this seems to print all 32
regardless. Is that expected?
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".