From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 40D4C405B1 for ; Tue, 26 Jul 2022 19:02:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7B1F968B840; Tue, 26 Jul 2022 22:02:29 +0300 (EEST) Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6D46A68B761 for ; Tue, 26 Jul 2022 22:02:23 +0300 (EEST) Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-31f56c42ab5so16517937b3.10 for ; Tue, 26 Jul 2022 12:02:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=3kZzvCuTfUVm4qpzWwrsGgizW+lafRcDZzn+mD7gGOM=; b=Ut2GlYQZcZTxGyUDrZReb1s1ZVfe+vB7DB6YeuB6k+8r8KEyn8VecTBfTKCuv2LUY2 5RVL8Xl7ZXoI9pXuC3LBybKcPSyJf+2vT4qAysFTurJWLMQfvppjj2WC4QKEia6RBJH3 P6Akn/rWmzVIPuDX2aeMZLd4nXeHVPYQodUm2s1LC2nyZNsxxcWRB/Ii9/Sdo/jgPGRG ypX669C9gg3LkjtHTxAFJ4W86MnTmvHB1dyxzux8zjhqrzpKQnVgDBnVsG9NhzlcyH/6 Eqd96CKLpmNQwGonye/nleKcqT34YPZQCs1FxV9uUG7rAYGIQslLziux4yXVE92EgCRO 5J2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=3kZzvCuTfUVm4qpzWwrsGgizW+lafRcDZzn+mD7gGOM=; b=Qnz7fQVs4tAhUmXT14ItMuRjLDWDLgUht1z6ZSzUHoGH3vuN9b15zDXmARq0f1X8KT GVzE1dmHy/y6GOeROVW0WnaAj0ok/+iQhWq1oRxYn3yOh85vNsgLmZtQ4vWv5RmzKzLM bsbhRll+fi46q63QiCmAXGmm4rjzr6JiSgc6Dp/l0xjhXvWBmYyZlFN29fwoV1XOWxXG n7CrZp5y4KQxRzGkBhkIRHYAQHOpEqDNK8kRrjDkokmwkNKyWbX2om88Fjc+5cfAcpfL elfc8xsWJoscSg7K/0bXbOir0Lj9Yek7n1VFYYyunJqqHZoM5iPwAfEzvE7i4WBVxU+G EIzg== X-Gm-Message-State: AJIora/dFfwnGQJ8kqEPGB3gXLVxo4hYJhhgo7nepSfcdyKEYIC4vt7c +owvfTbGu/jeJzrl5t0iivr87wtIBBOa6pHsWnCLjONfwcc= X-Google-Smtp-Source: AGRyM1s3Jy6A2zaTg7KwIRPtvS/q/zKqSQknpckuxJkpH/pJanmYYii/UPYI2owSw0j1iMmdxMY52qI8eHH++lwmocM= X-Received: by 2002:a0d:d513:0:b0:31f:5267:f9c4 with SMTP id x19-20020a0dd513000000b0031f5267f9c4mr2765306ywd.247.1658862141426; Tue, 26 Jul 2022 12:02:21 -0700 (PDT) MIME-Version: 1.0 References: <20220630210434.1551769-1-vigneshv@google.com> In-Reply-To: From: James Zern Date: Tue, 26 Jul 2022 12:02:10 -0700 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: Rework the AVIF parser to handle multiple items X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, Jul 22, 2022 at 11:21 AM Vignesh Venkatasubramanian wrote: > > On Wed, Jul 13, 2022 at 9:12 AM Vignesh Venkatasubramanian > wrote: > > > > On Mon, Jul 11, 2022 at 3:25 PM James Zern > > wrote: > > > > > > On Thu, Jun 30, 2022 at 2:04 PM Vignesh Venkatasubramanian > > > wrote: > > > > > > > > Stores the item ids of all the items found in the file and > > > > processes the primary item at the end of the meta box. This patch > > > > does not change any behavior. It sets up the code for parsing > > > > alpha channel (and possibly images with 'grid') in follow up > > > > patches. > > > > > > > > Signed-off-by: Vignesh Venkatasubramanian > > > > --- > > > > libavformat/isom.h | 4 ++ > > > > libavformat/mov.c | 148 ++++++++++++++++++++++++++++----------------- > > > > 2 files changed, 97 insertions(+), 55 deletions(-) > > > > > > > > [...] > > > > > > @@ -4692,9 +4755,25 @@ static int mov_read_meta(MOVContext *c, > > > AVIOContext *pb, MOVAtom atom) > > > tag = avio_rl32(pb); > > > atom.size -= 4; > > > if (tag == MKTAG('h','d','l','r')) { > > > + int ret; > > > avio_seek(pb, -8, SEEK_CUR); > > > atom.size += 8; > > > - return mov_read_default(c, pb, atom); > > > + ret = mov_read_default(c, pb, atom); > > > + if (ret < 0) > > > > > > In some other cases these two lines are combined, if ((ret = ... > > > > > > > Done. > > > > > + return ret; > > > + if (c->is_still_picture_avif) { > > > + int ret; > > > + // Add a stream for the YUV planes (primary item). > > > + ret = avif_add_stream(c, c->primary_item_id); > > > + if (ret) > > > > > > This could be updated too and use '< 0' to match other code. > > > > > > > Done. > > > > > + return ret; > > > + // For still AVIF images, the meta box contains all the > > > + // necessary information that would generally be > > > provided by the > > > + // moov box. So simply mark that we have found the moov box so > > > + // that parsing can continue. > > > + c->found_moov = 1; > > > + } > > > + return ret; > > > } > > > _______________________________________________ > > > ffmpeg-devel mailing list > > > ffmpeg-devel@ffmpeg.org > > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > > > To unsubscribe, visit link above, or email > > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > > > > > > > -- > > Vignesh > > Any further comments on this one? > > Please note that i have abandoned the second patch in this list. But > this one is still up for merging. > This looks like it needs to be rebased. I'll take a look after that. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".