From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E814D40780 for ; Wed, 29 Jun 2022 19:21:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9648568B713; Wed, 29 Jun 2022 22:21:00 +0300 (EEST) Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E424C68B321 for ; Wed, 29 Jun 2022 22:20:54 +0300 (EEST) Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-318889e6a2cso157930427b3.1 for ; Wed, 29 Jun 2022 12:20:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=X0ve9r1oLhK7EibZnRCHOJ+zEuakJs4Lcw7I4hWjMIM=; b=ize+DRdSFgQzPNggUNKmJ5eE6vFiEBttCqjfHQyCn0LYj/Sw4xVSMJ8fsi5PkV3S3Y Mg13Eaoa6g0VigClNlqY043DY2QXCBLkIeW5Yl8NgTfn1QzdaejYyxXJwzs7MXqkomGl IfFDmiKenjucONSd7xyFabxo8Px7O1HmnGddUFa5pIoCxJ+zmQIwU18kUge0ISGsGlOq ZJDLE9if2JRPMYbVbc4ipcB9HkAH6oMsV5JNUOBLkCGSs8v7DDUQuVjhnzkt5mN73BiI 4R5o6oJF5IiGmGFi2enquNxQhX/4zJ5Ysn+sbQIzX1kF4l4hu+FYzWbQhBbvfxBks5ds QspQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=X0ve9r1oLhK7EibZnRCHOJ+zEuakJs4Lcw7I4hWjMIM=; b=O78TrA2XOW/iIGmlaOnx1vw11WpMfiiT+nLLGDKK0srvmmZUTiS4C9piBRDN+8aLd0 vjgG95jl6L/H7SUkYC8PQz86zFs8s6DatwX8q7c6xyHlWJyBwVfMuyvRLtttUeSLHpxF 3DK2+cYinD1toHEclb108HzKefuvNUS1+spYkpEog4D3WP0UUds1A6Ns1PJUA3ik6Uvn S5ye0uPbstsdhjxuOUn6cd2tk+Hc0teG31ysP/Qsy64ojQR5aelooWT/TRbgsUe7I10b U8+SgXj6nHXHa+MTi5948WfHV6sfYIYzgF4TtWAG5k4Zvup9tgDnX2WmA7Armi71ZCkN 09HA== X-Gm-Message-State: AJIora8FRiS4kaoQSBfZuuK0oYIujPfN+RHVJVyRCx9U3+Qlspmsvhq8 fC2FPTXezDr2h7Nno+J7wuIa2VfA+Rl7MPfFvXgZDKuWomwq1A== X-Google-Smtp-Source: AGRyM1tJU7xUfdZrlSMS0fBsnjY2jSD8t+XvWcc/opVW5K1ZrtiWcGsPJeethsd34C5s/dO8MD22lJVOXrW5rjKrXLw= X-Received: by 2002:a0d:f607:0:b0:31b:b1d2:37bf with SMTP id g7-20020a0df607000000b0031bb1d237bfmr5512390ywf.313.1656530452869; Wed, 29 Jun 2022 12:20:52 -0700 (PDT) MIME-Version: 1.0 References: <20220628185620.2957852-1-vigneshv@google.com> In-Reply-To: From: James Zern Date: Wed, 29 Jun 2022 12:20:41 -0700 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avformat/mov: Only read the primary item for AVIF X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, Jun 28, 2022 at 12:02 PM James Zern wrote: > > On Tue, Jun 28, 2022 at 11:56 AM Vignesh Venkatasubramanian > wrote: > > > > Update the still AVIF parser to only read the primary item. With this > > patch, AVIF still images with exif/icc/alpha channel will no longer > > fail to parse. > > > > For example, this patch enables parsing of files in: > > https://github.com/AOMediaCodec/av1-avif/tree/master/testFiles/Microsoft > > > > Adding two fate tests: > > 1) demuxing of still image with 1 item - this test will pass regardlesss I fixed the 'regardless' typo. > > of this patch. > > 2) demuxing of still image with 2 items - this test will fail without > > this patch and will pass with patch applied. > > > > Partially fixes trac ticket #7621 > > > > Signed-off-by: Vignesh Venkatasubramanian > > --- > > libavformat/isom.h | 1 + > > libavformat/mov.c | 41 ++++++++++--------- > > tests/fate/mov.mak | 13 ++++++ > > .../fate/mov-avif-demux-still-image-1-item | 11 +++++ > > .../mov-avif-demux-still-image-multiple-items | 11 +++++ > > 5 files changed, 57 insertions(+), 20 deletions(-) > > create mode 100644 tests/ref/fate/mov-avif-demux-still-image-1-item > > create mode 100644 tests/ref/fate/mov-avif-demux-still-image-multiple-items > > > > lgtm. I'll submit this soon if there aren't any comments. applied, thanks for the patch. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".