From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A87774513C for ; Wed, 11 Jan 2023 01:23:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0D49468B0A7; Wed, 11 Jan 2023 03:23:23 +0200 (EET) Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0D8D3680043 for ; Wed, 11 Jan 2023 03:23:16 +0200 (EET) Received: by mail-oi1-f169.google.com with SMTP id s66so10989651oib.7 for ; Tue, 10 Jan 2023 17:23:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=YV1yZw+z9IFAeWeweJbvCM6CmtG0jPCAcS618yENu84=; b=Kumq9ulbznBFPn+sqXDrRP4ZS290XUe3J4zesmQS4vVn2o9N1o4qdW8YdqBy2cIUq0 05vCBiewoICkz0GnAwrknxN8Orav2vAPQrEskHHqfjD26yGjoqXT6wTy8MHw0mjwQuel 9hwJA8TWuWPcoGj0FcjorNsOvMr1xm5eI3VRZ+PFs+EVVkIgwJ9GBhZbSKKsExqJIg2y fmGf8XqAedzOC65YnJeiwEAC7dnwISSDEfUQazAEL6sBG9grtqcYhy+XRaksxAY1SZzd LTrYDNJ63moHHo4vvx+UShlQlySUSDYfBEKHuxapoWeQBuNS4YLCB0JMyiZQfXjBpa8J aBSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YV1yZw+z9IFAeWeweJbvCM6CmtG0jPCAcS618yENu84=; b=YM21rBZ6k9MRexgH/YKrjInViep25kB5aqXLSMOqlJ7W2qZUnyIKF9vV3OqyKrE9Hg ixhux1nBXEyEXyn1ix/c/75AB+pV3huLRFzT7y9imp1tnHbILiJFYVUUpmDbKMbxswyN FJREMzy9GewLWlgnPRtjYgdOK+DaxfGo2sOf3z7u+T9pyvMT2Vbo3maLB2zMs0bamLGC 5dyITdscl/+LKZwv7Vkwe0XejHvxTvlbzzynH9WWN/ikbQjA2hEnvZo+X81HXh9FOgYi w4XSOCUC+KW8ja349f4h9BNnzJOi4El26ohNzUBC9UX7BUKttPnX7aHO5dAdb6cWrU4T bSrg== X-Gm-Message-State: AFqh2kpL+BZyn/MEOD62j4i594ss8hbTa7hS5q/jgZ4ov7ohDdgL0Z9o syZCYRMa3KGLtVgQxLQvjBVf82R8zlPr97+Ye2hGUw9ngEuORZQzB5SMhw== X-Google-Smtp-Source: AMrXdXsN1YTRDhjfxJ2fZvCAiN0f8WUK+hp+U9NMMKiP/A7XNd2O/f1KO/NrG/42/1HVXuNLTMkkN/3Mbvw0OP91194= X-Received: by 2002:a54:4887:0:b0:360:e48c:a755 with SMTP id r7-20020a544887000000b00360e48ca755mr3525668oic.152.1673400193931; Tue, 10 Jan 2023 17:23:13 -0800 (PST) MIME-Version: 1.0 References: <20230105104151.2055-1-Dmitriy.Ovchinnikov@amd.com> In-Reply-To: From: James Zern Date: Tue, 10 Jan 2023 17:23:02 -0800 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v3] lavc/libvpx: remove thread limit X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, Jan 10, 2023 at 2:47 AM mypopy@gmail.com wrote: > > On Thu, Jan 5, 2023 at 6:42 PM Dmitrii Ovchinnikov > wrote: > [...] > > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > > index 9aa5510c28..0627e13973 100644 > > --- a/libavcodec/libvpxenc.c > > +++ b/libavcodec/libvpxenc.c > > @@ -942,7 +942,7 @@ static av_cold int vpx_init(AVCodecContext *avctx, > > enccfg.g_timebase.num = avctx->time_base.num; > > enccfg.g_timebase.den = avctx->time_base.den; > > enccfg.g_threads = > > - FFMIN(avctx->thread_count ? avctx->thread_count : av_cpu_count(), 16); > > + avctx->thread_count ? avctx->thread_count : av_cpu_count(); > > enccfg.g_lag_in_frames= ctx->lag_in_frames; > > > Do you check the change with the old version libvpx? as I know, older > versions libvpx setting the number of threads higher than 16 will > cause a crash, so I think at least a version check needs to be added > Do you have a bug or version in mind? There were some performance regressions [1] over the releases and some issues with changing the number of tiles, but I don't remember a crash for a high thread count (though there have been plenty of crashes related to threads in general [2]). The range check predates 1.4.0, which is the minimum required by ffmpeg. [1] https://crbug.com/webm/1574 [2] https://crbug.com/webm/851 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".