From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 86F10437D5 for ; Tue, 28 Jun 2022 18:21:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7B08E68B97B; Tue, 28 Jun 2022 21:21:31 +0300 (EEST) Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4BAA268B970 for ; Tue, 28 Jun 2022 21:21:25 +0300 (EEST) Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-3178acf2a92so125841547b3.6 for ; Tue, 28 Jun 2022 11:21:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=Ne7O9DN6AsXy1qBH4rUpjnWTpEksQsJZYHzS4dNHqG8=; b=gHy97jf/sGsCVCzxDjiYZu/ga/XYN7cDcWSXzGXKrxbXXq5WNLhWUhXZIu+GKePv18 3d3zAAhxBNnoM18O1b54E/voyj+c7uLrBkcuf0RBUD64zTxZEW44GZMnIl61zrp4mvCK JXfD5m7XCeADpFLMbjRnYAYMkcqzoesr8RaLt6BpRjNnVXT10JbfXGazP+wqr5a8LHJ+ 4qnoyiYNh5RsdQWtJR5Vt2V7gs/s7Ggvk6dUVuXgE8/dR2qrJuqkOTvbEsJAk5/oNARD QYPDtBSJKy2Ikh7ocOI52MW/gX8flU6MV5kJ+FzGwPTS6azhU0BCmmfEkhcB1xn8grCX qX/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=Ne7O9DN6AsXy1qBH4rUpjnWTpEksQsJZYHzS4dNHqG8=; b=fv+fLnuwsrwYlbVEeVTlCbAGGAqsSBFsHaKx6WMCmKIbPcLZyFXzqnUHk3N8Iiw5oJ 2yTk5xkxpDJWI/tn06uU6bWTnaqS449TEd5dlg3NCYSFE4BawmG8u0T0kSzYxSFYvn87 Zj29LXj+dqrQQgqbE66U1nxu4k7LsVrAG0S5StvsQ8XoPo/uF71FfqSPaBff4Ink4Op7 ee63osa76RYe4EBS/h0o87Zpu1hx2Y3LzJiYRsvZMNPelLJAs6d1cgNzgDh1TZqN1HoI nkYUz6C8d+uknxPjH/OM7hcye1KoQfRvoedaKAg9EDd6NVK60aoQYZA55DHCB3q/bXRY qrhA== X-Gm-Message-State: AJIora/oDFkKK+rpwFKraGIVBT7sVhi2Iw8eFX0Z+lHWVrhJjKur+Bz+ BbeclXxB3NglAhwHoTP55DAFb5Y/kbmWXNbOlemh3aa7Z/FFk/Dr X-Google-Smtp-Source: AGRyM1uIqkVYMtkOk75n9mG3d+/pnr/8YjQrOVvHCAuttgxvvX2eokkj2KmmCPoD+0MDC122jaMA2HrqoScteqcSkLw= X-Received: by 2002:a81:78d:0:b0:2e5:d440:d921 with SMTP id 135-20020a81078d000000b002e5d440d921mr22489736ywh.251.1656440483090; Tue, 28 Jun 2022 11:21:23 -0700 (PDT) MIME-Version: 1.0 References: <20220424183514.986374-1-vigneshv@google.com> <085f0277-e678-4d20-f2bf-fbf55ed959d8@gyani.pro> In-Reply-To: From: James Zern Date: Tue, 28 Jun 2022 11:21:12 -0700 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avformat/mov: Only read the primary item for AVIF X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, Jun 13, 2022 at 9:32 AM Vignesh Venkatasubramanian wrote: > > On Fri, Jun 10, 2022 at 10:34 AM Vignesh Venkatasubramanian > wrote: > > > > On Thu, Jun 9, 2022 at 12:50 AM Gyan Doshi wrote: > > > > > > > > > > > > On 2022-06-08 10:51 pm, Vignesh Venkatasubramanian wrote: > > > > On Thu, Jun 2, 2022 at 1:35 PM James Zern wrote: > > > >> On Wed, Jun 1, 2022 at 1:38 PM Vignesh Venkatasubramanian > > > >> wrote: > > > >>> On Wed, Jun 1, 2022 at 10:30 AM James Zern wrote: > > > >>>> On Sun, Apr 24, 2022 at 11:35 AM Vignesh Venkatasubramanian > > > >>>> wrote: > > > >>>>> Update the still AVIF parser to only read the primary item. With this > > > >>>>> patch, AVIF still images with exif/icc/alpha channel will no longer > > > >>>>> fail to parse. > > > >>>>> > > > >>>>> For example, this patch enables parsing of files in: > > > >>>>> https://github.com/AOMediaCodec/av1-avif/tree/master/testFiles/Microsoft > > > >>>>> > > > >>>> Can some of the failing files or similar ones be added to fate? > > > >>> There are no fate tests for AVIF parsing as of now. I was thinking > > > >>> about adding some for the muxing. But i am not sure what can be done > > > >>> here for the parsing. > > > >>> > > > >> Thanks. Are there any for general mov/mp4 parsing that could be > > > >> extended? This looks good otherwise. > > > > From what i see, most of the mov tests only seem to be for muxing. I'm > > > > not entirely certain about how to add a test for AVIF parsing. If > > > > anybody has an idea, i'd be open to adding it. > > > > > > Basic test would use the framemd5 muxer to compare demuxed packets with > > > a reference. > > > See fate-ffmpeg-streamloop > > > > > > > Thank you i have added a couple of fate tests. > > > > I am not sure how to add the AVIF files to the fate test server. I > > have them on Google Drive here: > > > > https://drive.google.com/file/d/1diZoM0Ew7Co3Yh5w5y1J-3IiBYVmUv9J/view?usp=sharing > > https://drive.google.com/file/d/1DdrD1mW36evt40a4RkeLYpx-oojmbc3z/view?usp=sharing > > > > These links should be publicly available without any sign in required. > > Please let me know if there is another preferred way of sharing test > > files and i can share it that way. > > > > Also, i forgot to mention that these files have to be uploaded under a > new directory called "avif" in the fate server. > Can you send a separate patch with the tests disabled and marked by a TODO to enable them after the files are uploaded? https://ffmpeg.org/developer.html#Adding-files-to-the-fate_002dsuite-dataset _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".