From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 24A3340608 for ; Thu, 25 Aug 2022 19:22:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 030DF68B98B; Thu, 25 Aug 2022 22:22:05 +0300 (EEST) Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E054168B357 for ; Thu, 25 Aug 2022 22:21:58 +0300 (EEST) Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-33da3a391d8so153897447b3.2 for ; Thu, 25 Aug 2022 12:21:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc; bh=904fbomptHr4Q1GkBq4F+z4sfYH0/TPSUkkJoUwAEjE=; b=tMi0etDXZv2gUnFjb1trLgDE6fx7c5cZI+xgkMxR7cKecXRJi8mfz5npvkXUcVEElr 4KIgvR8xGC1kk1G2pRz6FL6/VYl00xPyACbM7kjwRlavSC3QPHuxGIqg78BaiQKIUCdM JkidAsFf6hxGKHAGdkxK2MDHrbUFMQCnl+Aht9vRYOY2trYvPJP9i1k32Jfgx7x5NIaw 2yYq47+uNyn3qyDFgQnofSJOCYM6N52VlUrj+Abeb09xD00IHyzYoRLl7lReaGWmkl1D pzdEeAIoXBMxzJxDaowLFTVSytp7KGuEyc2eI3mOqRZHc/w35rwUxOeCXPfd6f4oDHQC txXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc; bh=904fbomptHr4Q1GkBq4F+z4sfYH0/TPSUkkJoUwAEjE=; b=yX7FXdcd3vX7XQw5dn/Akdnzw5zLSTZdcCLbMxoPDrKirbRHO/E/crShwlrounZUVY 8fjhpiCW3p0Q4GlVqajEIKBLpynTAStjlE2aS5/nAD7xQHnWHSqQThUOBqCfsrtsIpcJ 4lZpVKU/ZVGeqEY1UfIIuKHOTYcTFd3zN9DfGPhz3bSkxwSdphsBk8IMsxHH+odScQcB GKpApEYK9vH6zWbhBkCdM7W/vOWwpx9WL3UShf7n9zyktE5ITM+40EqhS9G/Vj0NghbH OLLY8iS98nuGwSddJX/MzArqyCCoEcaPyf1s3d2Huj6NdTMR9LKQ1+oF8JxIfYlivIGN KoQA== X-Gm-Message-State: ACgBeo2FyMK3bUeVh9N2gTiJtHePzdm8icRxz9YDp3+PsU0kH7FLSLZS uOcwXzTZkj52QdvUVOXvdEvuvLve9BaJkprJjEZJByNJ7cZ4Xw== X-Google-Smtp-Source: AA6agR4pjxyFPqKjn4KV4kNwl11fFu6nRHrMaYFdvh5B1yR/FeEVvgnCgUPX1x4U8tzltYsdKoJUY79Txvy78qxLnVc= X-Received: by 2002:a0d:d54d:0:b0:333:e8ab:7c7d with SMTP id x74-20020a0dd54d000000b00333e8ab7c7dmr5230069ywd.247.1661455316935; Thu, 25 Aug 2022 12:21:56 -0700 (PDT) MIME-Version: 1.0 References: <20220825171618.1264-1-jamrial@gmail.com> <11620435-fb87-7dba-f761-411bb0bb683b@gmail.com> In-Reply-To: <11620435-fb87-7dba-f761-411bb0bb683b@gmail.com> From: James Zern Date: Thu, 25 Aug 2022 12:21:46 -0700 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: add init cleanup flag X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, Aug 25, 2022 at 10:39 AM James Almer wrote: > > On 8/25/2022 2:34 PM, James Zern wrote: > > On Thu, Aug 25, 2022 at 10:16 AM James Almer wrote: > >> > >> Signed-off-by: James Almer > >> --- > >> There doesn't seem to be any proper API to check if an encoder is open. > >> > > > > true. > > > >> libavcodec/libaomenc.c | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > > > > lgtm. > > Will apply, thanks. > > > > >> diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c > >> index 485f554165..fb9a6ff8b2 100644 > >> --- a/libavcodec/libaomenc.c > >> +++ b/libavcodec/libaomenc.c > >> @@ -400,7 +400,7 @@ static av_cold int aom_free(AVCodecContext *avctx) > >> #if defined(AOM_CTRL_AV1E_GET_NUM_OPERATING_POINTS) && \ > >> defined(AOM_CTRL_AV1E_GET_SEQ_LEVEL_IDX) && \ > >> defined(AOM_CTRL_AV1E_GET_TARGET_SEQ_LEVEL_IDX) > >> - if (!(avctx->flags & AV_CODEC_FLAG_PASS1)) { > >> + if (ctx->encoder->iface && !(avctx->flags & AV_CODEC_FLAG_PASS1)) { I missed this, it should be 'ctx->encoder.iface'. > > > > This check is fine, though the codec control call should fail if iface is null. > > > >> int num_operating_points; > >> int levels[32]; > >> int target_levels[32]; > >> @@ -1544,6 +1544,7 @@ FFCodec ff_libaom_av1_encoder = { > >> FF_CODEC_ENCODE_CB(aom_encode), > >> .close = aom_free, > >> .caps_internal = FF_CODEC_CAP_NOT_INIT_THREADSAFE | > >> + FF_CODEC_CAP_INIT_CLEANUP | > >> FF_CODEC_CAP_AUTO_THREADS, > >> .defaults = defaults, > >> .init_static_data = av1_init_static, > >> -- > >> 2.37.2 > >> > >> _______________________________________________ > >> ffmpeg-devel mailing list > >> ffmpeg-devel@ffmpeg.org > >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > >> > >> To unsubscribe, visit link above, or email > >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".