From: James Zern <jzern-at-google.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: add init cleanup flag
Date: Thu, 25 Aug 2022 12:21:46 -0700
Message-ID: <CABWgkXKg=aLUzPWGZ7f7pdDRF34ZSGQxu1uOCvOm3Yp+kcja=w@mail.gmail.com> (raw)
In-Reply-To: <11620435-fb87-7dba-f761-411bb0bb683b@gmail.com>
On Thu, Aug 25, 2022 at 10:39 AM James Almer <jamrial@gmail.com> wrote:
>
> On 8/25/2022 2:34 PM, James Zern wrote:
> > On Thu, Aug 25, 2022 at 10:16 AM James Almer <jamrial@gmail.com> wrote:
> >>
> >> Signed-off-by: James Almer <jamrial@gmail.com>
> >> ---
> >> There doesn't seem to be any proper API to check if an encoder is open.
> >>
> >
> > true.
> >
> >> libavcodec/libaomenc.c | 3 ++-
> >> 1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >
> > lgtm.
>
> Will apply, thanks.
>
> >
> >> diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c
> >> index 485f554165..fb9a6ff8b2 100644
> >> --- a/libavcodec/libaomenc.c
> >> +++ b/libavcodec/libaomenc.c
> >> @@ -400,7 +400,7 @@ static av_cold int aom_free(AVCodecContext *avctx)
> >> #if defined(AOM_CTRL_AV1E_GET_NUM_OPERATING_POINTS) && \
> >> defined(AOM_CTRL_AV1E_GET_SEQ_LEVEL_IDX) && \
> >> defined(AOM_CTRL_AV1E_GET_TARGET_SEQ_LEVEL_IDX)
> >> - if (!(avctx->flags & AV_CODEC_FLAG_PASS1)) {
> >> + if (ctx->encoder->iface && !(avctx->flags & AV_CODEC_FLAG_PASS1)) {
I missed this, it should be 'ctx->encoder.iface'.
> >
> > This check is fine, though the codec control call should fail if iface is null.
> >
> >> int num_operating_points;
> >> int levels[32];
> >> int target_levels[32];
> >> @@ -1544,6 +1544,7 @@ FFCodec ff_libaom_av1_encoder = {
> >> FF_CODEC_ENCODE_CB(aom_encode),
> >> .close = aom_free,
> >> .caps_internal = FF_CODEC_CAP_NOT_INIT_THREADSAFE |
> >> + FF_CODEC_CAP_INIT_CLEANUP |
> >> FF_CODEC_CAP_AUTO_THREADS,
> >> .defaults = defaults,
> >> .init_static_data = av1_init_static,
> >> --
> >> 2.37.2
> >>
> >> _______________________________________________
> >> ffmpeg-devel mailing list
> >> ffmpeg-devel@ffmpeg.org
> >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >>
> >> To unsubscribe, visit link above, or email
> >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-08-25 19:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 17:16 James Almer
2022-08-25 17:34 ` James Zern
2022-08-25 17:39 ` James Almer
2022-08-25 19:21 ` James Zern [this message]
2022-08-25 19:28 ` James Almer
2022-08-25 19:32 ` James Zern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABWgkXKg=aLUzPWGZ7f7pdDRF34ZSGQxu1uOCvOm3Yp+kcja=w@mail.gmail.com' \
--to=jzern-at-google.com@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git